Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230404141853.4868-1-claudia.rosu@nxp.com> <20230404141853.4868-2-claudia.rosu@nxp.com>
In-Reply-To: <20230404141853.4868-2-claudia.rosu@nxp.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 4 Apr 2023 11:07:30 -0700
Message-ID: <CABBYNZKAu18kKjM6G4z-NbSBtqLSWWgOiVFaSYioCMVrnmXQ1A@mail.gmail.com>
Subject: Re: [PATCH 1/1] Bluetooth: Set ISO Data Path on broadcast sink
To:     Claudia Draghicescu <claudia.rosu@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Claudia,

On Tue, Apr 4, 2023 at 7:24=E2=80=AFAM Claudia Draghicescu <claudia.rosu@nx=
p.com> wrote:
>
> This patch enables ISO data rx on broadcast sink.
> Signed-off-by: Claudia Draghicescu <claudia.rosu@nxp.com>
> ---
>  net/bluetooth/hci_event.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 6cf9ae5b14d3..6ecd10069b6e 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -6997,6 +6997,7 @@ static void hci_le_big_sync_established_evt(struct =
hci_dev *hdev, void *data,
>                 bis->iso_qos.bcast.in.latency =3D le16_to_cpu(ev->interva=
l) * 125 / 100;
>                 bis->iso_qos.bcast.in.sdu =3D le16_to_cpu(ev->max_pdu);
>
> +               hci_iso_setup_path(bis);
>                 hci_connect_cfm(bis, ev->status);

While the use of hci_iso_setup_path seems correct here we probably
need to remove hci_connect_cfm since we need to wait the result of
Data Path before signal to the socket the controller is ready to
receive data.

>         }
>
> --
> 2.34.1
>


--=20
Luiz Augusto von Dentz