Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp4369352rwe; Mon, 17 Apr 2023 11:31:36 -0700 (PDT) X-Google-Smtp-Source: AKy350bJMwV+97meiRELM+xf3q9yml7TVzLpKbHc3in4A+w0OLapqmOqv67HLZY8Pu4cDGIQRu2Y X-Received: by 2002:a05:6a20:430f:b0:ef:ef0d:7dd9 with SMTP id h15-20020a056a20430f00b000efef0d7dd9mr4478078pzk.51.1681756296291; Mon, 17 Apr 2023 11:31:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681756296; cv=none; d=google.com; s=arc-20160816; b=NCwF2BHmbJ5p/8fpH7ozvZ7UPkJl2TljC/bqNM0LiYHDt7uWHmYYnmfDmriXk/e+Dl JTRl9H3bX/pchwAQtBrBwrsog+L9IMgItB7djU8t8CZRSMuPHWAFusgMwl8SdIcD/dNt 8gyPFHV+roY/MKtSfZnWk05yqAxrr/gYSFivGU7vRLnoe2HfQkiVvTFcwASARDk8dr20 t6JPrJT2Lmaek3HoNK/EUuI+314oLaDdy9vv/j08ODCFUg5jcXS8TGBIUggk7GJmmFtU P4PBga0Y+LkakW4l9t28LTfsQXJAH3N2+vHKPJrRBxh5yUhH0U5R2sIwl4yqEDSFxCvg RB0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=OTqRdH7UecH5Qy8MpruteM1UaFHlMiKNr7UF3N933wI=; b=In8DMsBO0AuaI8eDIjqbGpW7vZP9129JT+xdDP677ZvYYXcKlV0veZ2H6mp2xsi1su lvcqJ1a5BB0gmtQqpQMLs+OfOleWyhXit6MVkpVxXJ0zSrnA9nvtgCj2e9ugkLA7fbYc CaVJwnYNeukB4tbEiaB+2T4RyYEQhu5P7IaW+aWxv9n1uJBHor4xEJnaAB+F/yItRVmT JLzlXm/ks7MFc0wCswSA+/RhNfXJyuNO5QSLEFdfPvHJPSgIrxUi6NkcozXjE/MoWJEx IR1CiOimhYej4QHknm5FQLBY1u4vzXPDcJYYy/Llg5h4CTaNPTQfQpXeD6DC7423j5tj mMbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=chUnqH0Q; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t29-20020a63225d000000b005184eb693a1si13064687pgm.94.2023.04.17.11.31.13; Mon, 17 Apr 2023 11:31:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=chUnqH0Q; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230093AbjDQSau (ORCPT + 99 others); Mon, 17 Apr 2023 14:30:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbjDQSat (ORCPT ); Mon, 17 Apr 2023 14:30:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE8055FF9; Mon, 17 Apr 2023 11:30:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 49C306294F; Mon, 17 Apr 2023 18:30:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 67695C4339C; Mon, 17 Apr 2023 18:30:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681756219; bh=3e9vKiBUmmEVBKScxPSb0rPDmENNsW9Ti6H05k9fcNE=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=chUnqH0QIixvPMWv6v7K7XaUa9VexvyBA46wTWxni8GGiS7YLLKytoDCXjYdQqBda lVTRagGdYLAPZVdRbNn/04ktmSmFj5o2FQXvkyc4i8NhW3x/k2BBraVod1ftrvTVZK 0XK43evBL3g63FgkqK6gttd3tAk+uYlxi4OQ5fNnWBNo+JiwriJ/bqFDJt4Gjq3Ku9 t0/wT/v3NiSKp78t6K/XXsWsYu/X3ZpXSIZbxLK6rJDGNqjqXwAH+rIkuSUKlO+NhW SmjFWFn9xTNTy8IiZUMx6+cqVjaMZfP4XO/WvZfrlyJ5uErZ55azwRuuauTCWWtN1f VYrle1GG+Hdtg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 41BC5C395C8; Mon, 17 Apr 2023 18:30:19 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] bluetooth: Perform careful capability checks in hci_sock_ioctl() From: patchwork-bot+bluetooth@kernel.org Message-Id: <168175621926.2755.7232782905292014769.git-patchwork-notify@kernel.org> Date: Mon, 17 Apr 2023 18:30:19 +0000 References: <20230416081404.8227-1-lrh2000@pku.edu.cn> In-Reply-To: <20230416081404.8227-1-lrh2000@pku.edu.cn> To: Ruihan Li Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, stable@vger.kernel.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz : On Sun, 16 Apr 2023 16:14:04 +0800 you wrote: > Previously, capability was checked using capable(), which verified that the > caller of the ioctl system call had the required capability. In addition, > the result of the check would be stored in the HCI_SOCK_TRUSTED flag, > making it persistent for the socket. > > However, malicious programs can abuse this approach by deliberately sharing > an HCI socket with a privileged task. The HCI socket will be marked as > trusted when the privileged task occasionally makes an ioctl call. > > [...] Here is the summary with links: - bluetooth: Perform careful capability checks in hci_sock_ioctl() https://git.kernel.org/bluetooth/bluetooth-next/c/313016d28888 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html