Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH BlueZ 3/3] tools/iso-tester: Add Broadcast tests for encrypted BIG
Date:   Wed, 19 Apr 2023 16:43:54 +0300
Message-Id: <20230419134354.61950-4-iulia.tanasescu@nxp.com>
In-Reply-To: <20230419134354.61950-1-iulia.tanasescu@nxp.com>
References: <20230419134354.61950-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WY2MoD6F/prRC4LDMN9JssZk1zZd8y6C3eML3KMCyROJjPAHP3Y+Yx/vMY87?=
 =?us-ascii?Q?Qk2T3hqVyzrFXS5rK9OA7Q+laaR/uTSHsEs6xHnBiwGr1+pzwXh3xRk5Bp1b?=
 =?us-ascii?Q?I7bM5ThH8/yn07zTdGy0E7mI5HThQskNq/gKN0filsTp8zqlZQ6UNvn6A0sL?=
 =?us-ascii?Q?isCxRw9GtEAOK90GR//MUgeeNleXkZTBl6AZzlWReEMz0HUGaDNXX6f/D1Yj?=
 =?us-ascii?Q?RFKBbdEKRQTLebzg4qDAK/cV3j5WI9zuYxvdaUnrruNsXo/KtTK2MKHdqw3z?=
 =?us-ascii?Q?joohyxiomxeLrl3vDf9kZt4lP7M7nwkC2gKPMPcRIng5j2BWny+UCXPjMiIs?=
 =?us-ascii?Q?HpN8cVNNG5MD6aOYK9sSVOqTz6aY/gwnGyPohFF6sNDBIaVDoqk9Ou8F4QRO?=
 =?us-ascii?Q?8Hp8ze2T/JL4fiPCZjhxaNvKo4+5ezZYllrGq4uAp4SGbL410zEg1C42n92W?=
 =?us-ascii?Q?Jw4p4kbB02bDlXmlwSwAVJSPu4ZYIuSKSkfCYsY8jrPrJqoz7Vxr2T1/IRYC?=
 =?us-ascii?Q?tnoRFzPTpfeHl6SuhxFNJDf96zIwxBnB+uBBTUoKwkdp9LlF6GHaE8vPdOd4?=
 =?us-ascii?Q?izpAGIw4fibfBv7hc5pWFFZdKUgooqHYurVsKHv2cg5dfye1WyUKewGy7gL/?=
 =?us-ascii?Q?aXCM38cW7a/YlJLRG1m9SZbjrcBkNBJ+Rj0Ywuj/kdKla9W3HZjw6lTdSpec?=
 =?us-ascii?Q?17RN3InC+nxkWJrYB5z4ONs0gpSNZucm8BLVXF3jwXS0yti27feIq4DKEAZB?=
 =?us-ascii?Q?D+wsJtf9YEYnU8jthwT9PSSJmZcIl0XGouJ7RWQQOaN9Ld+SQDGmYp7y3i/E?=
 =?us-ascii?Q?vi7NcKLazOzlvwhmShUpLUJQSHPDdGYGxfauuefWABUkEitggD7G8YU/B6ty?=
 =?us-ascii?Q?Gy8FzqZ6oebfNHvLaj3U4vOWxhRdzkI3WIrH13xgEPgNjd6WHBNU3ZnnZBbw?=
 =?us-ascii?Q?da7br95ND3ciBU0JPLXQOBngSrddQwqfel6MdxFVOjDBEpsy2h2VZZvE4458?=
 =?us-ascii?Q?kVuR3ViCxSxJGtc+TYCJswUpbGLabSQkIRc6Y1CZFGgJdfRvL9coxAQX6w/S?=
 =?us-ascii?Q?+imnFSFazrxKxlIJiwh3Gh84rxzU+3QWLAJ1vtdVPvc71YxeIaL9QOa+mxsa?=
 =?us-ascii?Q?75f7hpZHf/K9lmgzZuWLKrPGVgmDxeJy2hPjpin/Z6YrK2pE44eeDpqhXuS7?=
 =?us-ascii?Q?Xf3rcjEhi/zbnLnGrTBTCQP4LRnyAFs4j/Ctf/K7xQUnNTZEuQc97BExXUy4?=
 =?us-ascii?Q?z7I2xzXGQM4i6uxLMtC7Z4JDkqzy4CBYMOqbz8LZesLyRRUmF18a6Y5sJsCr?=
 =?us-ascii?Q?s7pI9KhHjYcGNkwIV/8WKA7DvLKMAR4Sr68iu6itbP07AqQcqIaAohcaNBGC?=
 =?us-ascii?Q?Xdt+m12HA2CIkfTeko2DlnVkjIB1Ev6uOCzUnSlRSiSn/4WGl5OEMldZSbBH?=
 =?us-ascii?Q?ZwoVav7+GNa2zCqC3b1n/DiSaWxUjImu/4nXXabnpmm1nw0SpCg5p0oZy6lD?=
 =?us-ascii?Q?gDtgE1p/fLUpyHZ+Emh2Tb+mSeFs/EpkLhMnxBp34cebaR2M7X65aip27eOS?=
 =?us-ascii?Q?ZKM9cMcWGq7BEtXTFYPyefJceFhb8dff3JAmgS2Au4Qu8x2AlDIj7+r1ek3f?=
 =?us-ascii?Q?4g=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8724b120-eda7-47c7-c406-08db40dc3469
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 13:44:32.1202
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RkXCRWGiANGeondsBnuEbjU/kYFLgzv3g9uqlHGs+b7jc+Yd6uEBJOqFNHIMXEB2f5mVQHTpRee1oBHVTJe74Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7914
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

This adds the following tests for encrypted broadcast:

ISO Broadcaster Encrypted - Success
ISO Broadcaster Receiver Encrypted - Success

---
 emulator/btdev.c   |  8 ++++++
 emulator/bthost.c  |  5 +++-
 emulator/bthost.h  |  4 ++-
 monitor/bt.h       |  2 ++
 tools/iso-tester.c | 64 +++++++++++++++++++++++++++++++++++++++++-----
 5 files changed, 74 insertions(+), 9 deletions(-)

diff --git a/emulator/btdev.c b/emulator/btdev.c
index a04f34d4b..7980a5280 100644
--- a/emulator/btdev.c
+++ b/emulator/btdev.c
@@ -5,6 +5,7 @@
  *
  *  Copyright (C) 2011-2012  Intel Corporation
  *  Copyright (C) 2004-2010  Marcel Holtmann <marcel@holtmann.org>
+ *  Copyright 2023 NXP
  *
  *
  */
@@ -6162,6 +6163,13 @@ static int cmd_big_create_sync_complete(struct btdev *dev, const void *data,
 	dev->big_handle = cmd->handle;
 	bis = conn->data;
 
+	if (bis->encryption != cmd->encryption) {
+		pdu.ev.status = BT_HCI_ERR_ENC_MODE_NOT_ACCEPTABLE;
+		le_meta_event(dev, BT_HCI_EVT_LE_BIG_SYNC_ESTABILISHED, &pdu,
+					sizeof(pdu.ev));
+		return 0;
+	}
+
 	pdu.ev.handle = cmd->handle;
 	memcpy(pdu.ev.latency, bis->sdu_interval, sizeof(pdu.ev.interval));
 	pdu.ev.nse = 0x01;
diff --git a/emulator/bthost.c b/emulator/bthost.c
index 8cdfa0c06..3179bb3d2 100644
--- a/emulator/bthost.c
+++ b/emulator/bthost.c
@@ -3137,7 +3137,8 @@ void bthost_set_pa_enable(struct bthost *bthost, uint8_t enable)
 	send_command(bthost, BT_HCI_CMD_LE_SET_PA_ENABLE, &cp, sizeof(cp));
 }
 
-void bthost_create_big(struct bthost *bthost, uint8_t num_bis)
+void bthost_create_big(struct bthost *bthost, uint8_t num_bis,
+				uint8_t enc, const uint8_t *bcode)
 {
 	struct bt_hci_cmd_le_create_big cp;
 
@@ -3150,6 +3151,8 @@ void bthost_create_big(struct bthost *bthost, uint8_t num_bis)
 	cp.bis.latency = cpu_to_le16(10);
 	cp.bis.rtn = 0x02;
 	cp.bis.phy = 0x02;
+	cp.bis.encryption = enc;
+	memcpy(cp.bis.bcode, bcode, sizeof(cp.bis.bcode));
 	send_command(bthost, BT_HCI_CMD_LE_CREATE_BIG, &cp, sizeof(cp));
 }
 
diff --git a/emulator/bthost.h b/emulator/bthost.h
index 92182687f..cdc12dc1c 100644
--- a/emulator/bthost.h
+++ b/emulator/bthost.h
@@ -5,6 +5,7 @@
  *
  *  Copyright (C) 2011-2012  Intel Corporation
  *  Copyright (C) 2004-2010  Marcel Holtmann <marcel@holtmann.org>
+ *  Copyright 2023 NXP
  *
  *
  */
@@ -102,7 +103,8 @@ void bthost_set_ext_adv_params(struct bthost *bthost);
 void bthost_set_ext_adv_enable(struct bthost *bthost, uint8_t enable);
 void bthost_set_pa_params(struct bthost *bthost);
 void bthost_set_pa_enable(struct bthost *bthost, uint8_t enable);
-void bthost_create_big(struct bthost *bthost, uint8_t num_bis);
+void bthost_create_big(struct bthost *bthost, uint8_t num_bis, uint8_t enc,
+				const uint8_t *bcode);
 bool bthost_search_ext_adv_addr(struct bthost *bthost, const uint8_t *addr);
 
 void bthost_set_cig_params(struct bthost *bthost, uint8_t cig_id,
diff --git a/monitor/bt.h b/monitor/bt.h
index 97501c7dc..2548f0dcd 100644
--- a/monitor/bt.h
+++ b/monitor/bt.h
@@ -5,6 +5,7 @@
  *
  *  Copyright (C) 2011-2014  Intel Corporation
  *  Copyright (C) 2002-2010  Marcel Holtmann <marcel@holtmann.org>
+ *  Copyright 2023 NXP
  *
  *
  */
@@ -3720,6 +3721,7 @@ struct bt_hci_evt_le_big_info_adv_report {
 #define BT_HCI_ERR_CONN_FAILED_TO_ESTABLISH	0x3e
 #define BT_HCI_ERR_UNKNOWN_ADVERTISING_ID	0x42
 #define BT_HCI_ERR_CANCELLED			0x44
+#define BT_HCI_ERR_ENC_MODE_NOT_ACCEPTABLE	0x25
 
 struct bt_l2cap_hdr {
 	uint16_t len;
diff --git a/tools/iso-tester.c b/tools/iso-tester.c
index aad4b6574..c5c6f0aec 100644
--- a/tools/iso-tester.c
+++ b/tools/iso-tester.c
@@ -214,7 +214,10 @@
 #define AC_11ii_1 QOS_1(10000, 10, 40, 0x02, 2)
 #define AC_11ii_2 QOS_1(10000, 10, 40, 0x02, 2)
 
-#define QOS_BCAST_FULL(_big, _bis, _in, _out) \
+#define BCODE {0x01, 0x02, 0x68, 0x05, 0x53, 0xf1, 0x41, 0x5a, \
+				0xa2, 0x65, 0xbb, 0xaf, 0xc6, 0xea, 0x03, 0xb8}
+
+#define QOS_BCAST_FULL(_big, _bis, _encryption, _bcode, _in, _out) \
 { \
 	.bcast = { \
 		.big = _big, \
@@ -224,8 +227,8 @@
 		.framing = 0x00, \
 		.in = _in, \
 		.out = _out, \
-		.encryption = 0x00, \
-		.bcode = {0}, \
+		.encryption = _encryption, \
+		.bcode = _bcode, \
 		.options = 0x00, \
 		.skip = 0x0000, \
 		.sync_timeout = 0x4000, \
@@ -237,24 +240,40 @@
 
 #define BCAST_QOS_OUT(_interval, _latency, _sdu, _phy, _rtn) \
 	QOS_BCAST_FULL(BT_ISO_QOS_BIG_UNSET, BT_ISO_QOS_BIS_UNSET, \
-		{}, QOS_IO(_interval, _latency, _sdu, _phy, _rtn))
+		0x00, {0x00}, {}, \
+		QOS_IO(_interval, _latency, _sdu, _phy, _rtn))
+
+#define BCAST_QOS_OUT_ENC(_interval, _latency, _sdu, _phy, _rtn) \
+	QOS_BCAST_FULL(BT_ISO_QOS_BIG_UNSET, BT_ISO_QOS_BIS_UNSET, \
+		0x01, BCODE, {}, \
+		QOS_IO(_interval, _latency, _sdu, _phy, _rtn))
 
 #define BCAST_QOS_OUT_1(_interval, _latency, _sdu, _phy, _rtn) \
 	QOS_BCAST_FULL(0x01, BT_ISO_QOS_BIS_UNSET, \
-		{}, QOS_IO(_interval, _latency, _sdu, _phy, _rtn))
+		0x00, {0x00}, {}, \
+		QOS_IO(_interval, _latency, _sdu, _phy, _rtn))
 
 #define BCAST_QOS_OUT_1_1(_interval, _latency, _sdu, _phy, _rtn) \
 	QOS_BCAST_FULL(0x01, 0x01, \
-		{}, QOS_IO(_interval, _latency, _sdu, _phy, _rtn))
+		0x00, {0x00}, {}, \
+		QOS_IO(_interval, _latency, _sdu, _phy, _rtn))
 
 #define BCAST_QOS_IN(_interval, _latency, _sdu, _phy, _rtn) \
 	QOS_BCAST_FULL(BT_ISO_QOS_BIG_UNSET, BT_ISO_QOS_BIS_UNSET, \
+		0x00, {0x00}, \
+		QOS_IO(_interval, _latency, _sdu, _phy, _rtn), {})
+
+#define BCAST_QOS_IN_ENC(_interval, _latency, _sdu, _phy, _rtn) \
+	QOS_BCAST_FULL(BT_ISO_QOS_BIG_UNSET, BT_ISO_QOS_BIS_UNSET, \
+		0x01, BCODE, \
 		QOS_IO(_interval, _latency, _sdu, _phy, _rtn), {})
 
 #define QOS_OUT_16_2_1 BCAST_QOS_OUT(10000, 10, 40, 0x02, 2)
+#define QOS_OUT_ENC_16_2_1 BCAST_QOS_OUT_ENC(10000, 10, 40, 0x02, 2)
 #define QOS_OUT_1_16_2_1 BCAST_QOS_OUT_1(10000, 10, 40, 0x02, 2)
 #define QOS_OUT_1_1_16_2_1 BCAST_QOS_OUT_1_1(10000, 10, 40, 0x02, 2)
 #define QOS_IN_16_2_1 BCAST_QOS_IN(10000, 10, 40, 0x02, 2)
+#define QOS_IN_ENC_16_2_1 BCAST_QOS_IN_ENC(10000, 10, 40, 0x02, 2)
 
 struct test_data {
 	const void *test_data;
@@ -870,6 +889,13 @@ static const struct iso_client_data bcast_16_2_1_send = {
 	.bcast = true,
 };
 
+static const struct iso_client_data bcast_enc_16_2_1_send = {
+	.qos = QOS_OUT_ENC_16_2_1,
+	.expect_err = 0,
+	.send = &send_16_2_1,
+	.bcast = true,
+};
+
 static const struct iso_client_data bcast_1_16_2_1_send = {
 	.qos = QOS_OUT_1_16_2_1,
 	.expect_err = 0,
@@ -892,6 +918,14 @@ static const struct iso_client_data bcast_16_2_1_recv = {
 	.server = true,
 };
 
+static const struct iso_client_data bcast_enc_16_2_1_recv = {
+	.qos = QOS_IN_ENC_16_2_1,
+	.expect_err = 0,
+	.recv = &send_16_2_1,
+	.bcast = true,
+	.server = true,
+};
+
 static void client_connectable_complete(uint16_t opcode, uint8_t status,
 					const void *param, uint8_t len,
 					void *user_data)
@@ -1008,7 +1042,9 @@ static void setup_powered_callback(uint8_t status, uint16_t length,
 		if (isodata->bcast) {
 			bthost_set_pa_params(host);
 			bthost_set_pa_enable(host, 0x01);
-			bthost_create_big(host, 1);
+			bthost_create_big(host, 1,
+					isodata->qos.bcast.encryption,
+					isodata->qos.bcast.bcode);
 		} else if (!isodata->send && isodata->recv) {
 			const uint8_t *bdaddr;
 
@@ -1883,6 +1919,13 @@ static int listen_iso_sock(struct test_data *data)
 		}
 	}
 
+	if (setsockopt(sk, SOL_BLUETOOTH, BT_ISO_QOS, &isodata->qos,
+						sizeof(isodata->qos)) < 0) {
+		tester_print("Can't set socket BT_ISO_QOS option: %s (%d)",
+					strerror(errno), errno);
+		goto fail;
+	}
+
 	if (listen(sk, 10)) {
 		err = -errno;
 		tester_warn("Can't listen socket: %s (%d)", strerror(errno),
@@ -2257,6 +2300,9 @@ int main(int argc, char *argv[])
 
 	test_iso("ISO Broadcaster - Success", &bcast_16_2_1_send, setup_powered,
 							test_bcast);
+	test_iso("ISO Broadcaster Encrypted - Success", &bcast_enc_16_2_1_send,
+							setup_powered,
+							test_bcast);
 	test_iso("ISO Broadcaster BIG 0x01 - Success", &bcast_1_16_2_1_send,
 							setup_powered,
 							test_bcast);
@@ -2268,6 +2314,10 @@ int main(int argc, char *argv[])
 	test_iso("ISO Broadcaster Receiver - Success", &bcast_16_2_1_recv,
 							setup_powered,
 							test_bcast_recv);
+	test_iso("ISO Broadcaster Receiver Encrypted - Success",
+							&bcast_enc_16_2_1_recv,
+							setup_powered,
+							test_bcast_recv);
 
 	return tester_run();
 }
-- 
2.34.1