Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e8cbf8c3-f2ff-2e4d-ab00-e3579f745e9f@molgen.mpg.de>
Date:   Wed, 19 Apr 2023 16:54:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH BlueZ v3] obexd: support to reply folder name to store
 file
Content-Language: en-US
To:     Guiting Shen <aarongt.shen@gmail.com>
Cc:     linux-bluetooth@vger.kernel.org
References: <20230419145019.11548-1-aarongt.shen@gmail.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20230419145019.11548-1-aarongt.shen@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Guiting,


Am 19.04.23 um 16:50 schrieb Guiting Shen:

> On 19.04.23 19:49 Paul Menzel wrote:
>> Am 19.04.23 um 12:19 schrieb Guiting Shen:
>>> From: Aaron_shen <aarongt.shen@gmail.com>
> 
>> The old name is still documented as the author for the commit. Did you
>> execute the second command?
> 
>>      git commit --amend --author="Aaron Shen <aarongt.shen@gmail.com>"
> 
>> Or with your real name:
> 
>>      git commit --amend --author="Guiting Shen <aarongt.shen@gmail.com>"
> 
>> You can verify the success with `git show` and look at the meta data.
> 
> Sorry, I forgot to make new patch to send.

No problem.

>> The obex agent usually reply the filename by getting the default filename
> 
>> s/reply/replies/
> 
>> Do you mean *returns* instead of *replies*?
> 
> Yes, I mean to return the filename or folder name to reply the AuthorizePush
> request from obexd manager.
> Do I use 'returns' instead of 'replies' in v4 patch?

At least for me that would be more correct.

>>> from the filename property of the transfer object which is not convenient.
>>> The patch helps that the obex agent can reply folder name or new filename
>>> or null which will use the default filename if new_name is NULL and the
>>> default folder if the new_folder is NULL in opp_chkput().


Kind regards,

Paul


PS: By the way, your replies are not correctly threaded. The message 
header says you are using git-send-email to compose/send this message – 
the one I am replying to right now with Message-Id:

20230419145019.11548-1-aarongt.shen@gmail.com