Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     luiz.dentz@gmail.com
Cc:     iulia.tanasescu@nxp.com, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 2/2] shared/bass: Add initial code for handling BASS
Date:   Wed, 26 Apr 2023 15:40:33 +0300
Message-Id: <20230426124033.22297-1-iulia.tanasescu@nxp.com>
In-Reply-To: <CABBYNZK70qisom+iSyCoTh2XF70zNAcZUN6bKT2G6k2RoBRq8g@mail.gmail.com>
References: <CABBYNZK70qisom+iSyCoTh2XF70zNAcZUN6bKT2G6k2RoBRq8g@mail.gmail.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H7JPUmkIUncAc/teYAQlWujtwTKwCJHfuJPCvjCcm5duRXdvjoFtceynCQaI?=
 =?us-ascii?Q?1RyGF/rP0yiEK+YzmC6x76HjVgIAZSMGn2cHzXhu4/o8qTNZuiRGyMF9Axu+?=
 =?us-ascii?Q?UXrqK6PLKLPc6SvyMNkNGI+LqLVSi9E8HV4E91E7W16gawCZJ5xiMKRWlHXV?=
 =?us-ascii?Q?yeQkJIX5Yyhy1BsRIbuDiP2zjIicfs2uXqIbuPXeOCkRXki0QJhtYQAxdvDf?=
 =?us-ascii?Q?x7pT+jdcsg+WqvKfF9bzIC2J4kmqU6wRuxVN6T89yT1ITaJKUOdwUTx6cXT3?=
 =?us-ascii?Q?eozJyhcZb5MZrpnNvPjIewi53RZbb18XDGM1IC40KiJiA/4wMqkfkEnkkOka?=
 =?us-ascii?Q?DwMSIFwSjWmYePypUBe6nH1FTRrOyAXDNkmGQi52t8qB0e7eGwwLkkuHsaMd?=
 =?us-ascii?Q?6kLpfxerOmON6vKN9SeXL+zNcHghYcWYIDkgD0zVGTZ4mZG2WlKVoBHI+oqV?=
 =?us-ascii?Q?4UF/ii7Sk3y/DhjP+Mze91pqu6Dukr2ruVM/yIywU8v7+oYscSCw6EjqdJET?=
 =?us-ascii?Q?bwOKdTtpAPUE/YGUhEDxiFnK28Hj9AeV4GO9NHhDOGaP5kWtgY1xQGEqeMiw?=
 =?us-ascii?Q?Gb0uXSx+JAOZZjs6fmvm2fXZgjEOrUt4n5ZqL+3xfayS1aeWuLQjU8lqfIVr?=
 =?us-ascii?Q?AkIzvGjOCp6gIFirQ55utXtI8wOg1zDygRTiaMlnOZKhlpMTN9W+gSoSmvq9?=
 =?us-ascii?Q?/U6hsEp5z4g4G5kl/qQ3gn44gSCcXYMPYCetp91qNiGwK8aCe9AxNltzBvFd?=
 =?us-ascii?Q?TOyywZ9b25ZMhSsyTMsxMP5c2h1uFeGOUtf6FGmXTk3acvtixFBOZHvb4AbH?=
 =?us-ascii?Q?XlW2qaa+INR4O+9QCNQZEEPl7dC5QpAhkh3NvvDmuhWJ35OoKFipzq0KLYM/?=
 =?us-ascii?Q?em19F68V+Fs9wiG1BewxPxrn1QZtp8KWz2VxF3o7uZGeqnYnB7XM4aACc0AJ?=
 =?us-ascii?Q?1K9asbVHHYTQ4i0jZyh27E+5Xyk5f37e3hfff9cdhMFY4jH/R0Xe8hBkSli/?=
 =?us-ascii?Q?Bv4i6D9DdEuH1iXRpHYTYFKPi1AWPtZjtdBgNXMLzks1oYJb7Dt+61NEn0D5?=
 =?us-ascii?Q?0kbUsX3G8xW/4+ndQ+CfXJCiYG6TT+9ih8H9ELwD6yfCDlBuxwJPnyurzamv?=
 =?us-ascii?Q?SXOn1Pzt94eTfsF+rYaVra/x+tepNQy20YB8qf6023F6EZaJ0yL+YH/XuLfR?=
 =?us-ascii?Q?h+Jid7IONBZFo9FZQFunJmOjP2abPWBcsunnQY0W+tOQ6yYJ+W5OU/yn4x+q?=
 =?us-ascii?Q?3ZhQqqMPfu99cq+juTEQje50jdR3yF9lWxT7o2o3MBy0Rv6KR3diWv6GclQE?=
 =?us-ascii?Q?NwTSw/1uOy5Tg7CeO4QA/TjnIgwbaB3C64+ZQXP/ZDzo0f5eYLdVreBhUC2N?=
 =?us-ascii?Q?/GZu+k+Jd/uuUPgzRMdvQOp5iI0vSuWKUSJjiNiBLpJlc3QzOtjKitIH0My4?=
 =?us-ascii?Q?yKlbRvuXiAFagGzh0CBoECLRepV1LC60Jjxz1m+YcUwd1VbXROa0znbHHwkP?=
 =?us-ascii?Q?EVpa9ME+M/Pi7/iI4GtKIWHUpZl6e1iSRKIrNxzDRS6PCAVycsHKujHvG1qB?=
 =?us-ascii?Q?UdlZdh5jBDoRDi0pCX6kkXFBEtolJ4+oV8eNQj+WUvjPmV/DHYXO13PmnMZF?=
 =?us-ascii?Q?Iw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6463c66d-096e-4ef5-20b5-08db46537682
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 12:40:48.8694
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V2AoDzseJwDWpFMLnt4xYoqgcj4oSVdMZGXKIeeSN/0Lr3pnPGz4/gbaVzl1gH32H/xiLwRKzjHB8jAuF0RqrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7830
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Luiz,

Thank you for the review, I agree that it would be better to implement BASS as
a standalone plugin, in my opinion, instead of incorporating BASS Client as
part of BAP and separating BASS Server, it would be even better to completely
decouple BASS from BAP, so that both Scan Delegator (BASS Server) and
Broadcast Assistant (BASS Client) roles will be implemented as a separate
plugin that may or may not be loaded along with the BAP plugin.

What do you think about this?

Regards,
Iulia