Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CABBYNZK70qisom+iSyCoTh2XF70zNAcZUN6bKT2G6k2RoBRq8g@mail.gmail.com>
 <20230426124033.22297-1-iulia.tanasescu@nxp.com>
In-Reply-To: <20230426124033.22297-1-iulia.tanasescu@nxp.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 26 Apr 2023 09:04:58 -0700
Message-ID: <CABBYNZ+dzTYahh6cuFLuFbQQfF_F0h9udWgRuB_AVKMX385Qcw@mail.gmail.com>
Subject: Re: [PATCH BlueZ 2/2] shared/bass: Add initial code for handling BASS
To:     Iulia Tanasescu <iulia.tanasescu@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Iulia,

On Wed, Apr 26, 2023 at 5:40=E2=80=AFAM Iulia Tanasescu <iulia.tanasescu@nx=
p.com> wrote:
>
> Hi Luiz,
>
> Thank you for the review, I agree that it would be better to implement BA=
SS as
> a standalone plugin, in my opinion, instead of incorporating BASS Client =
as
> part of BAP and separating BASS Server, it would be even better to comple=
tely
> decouple BASS from BAP, so that both Scan Delegator (BASS Server) and
> Broadcast Assistant (BASS Client) roles will be implemented as a separate
> plugin that may or may not be loaded along with the BAP plugin.
>
> What do you think about this?

Yep, go for it, this should also make it easier to create proper unit
tests without having to involve bt_bap instances.

> Regards,
> Iulia


--=20
Luiz Augusto von Dentz