Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 1 May 2023 02:23:38 +0800
From:   Ruihan Li <lrh2000@pku.edu.cn>
To:     linux-bluetooth@vger.kernel.org
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Ruihan Li <lrh2000@pku.edu.cn>
Subject: Re: Bluetooth: Fix UAF in hci_conn_hash_flush again
Message-ID: <rr6fty7uos26m2yh4aphn4bd4q6nrbnjhgfi4kvah7llkuvycp@gryksomvznb4>
References: <20230430171847.156825-1-lrh2000@pku.edu.cn>
 <644eabeb.0c0a0220.1245d.fc0b@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <644eabeb.0c0a0220.1245d.fc0b@mx.google.com>
Precedence: bulk

On Sun, Apr 30, 2023 at 10:56:59AM -0700, bluez.test.bot@gmail.com wrote:
> Test: CheckPatch - FAIL
> Desc: Run checkpatch.pl script
> Output:
> Bluetooth: Fix UAF in hci_conn_hash_flush again
> WARNING: Reported-by: should be immediately followed by Link: with a URL to the report
> #92: 
> Reported-by: syzbot+8bb72f86fc823817bc5d@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=8bb72f86fc823817bc5d
> 
> WARNING: Unknown link reference 'Closes:', use 'Link:' instead
> #93: 
> Closes: https://syzkaller.appspot.com/bug?extid=8bb72f86fc823817bc5d
> 

Well, CI is out of date, as the mainline has changed this from 'Link:' to
'Closes:' [1].

 [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=44c31888098a590b8ec5ba37009e5a983f7c4b46

> CHECK: Alignment should match open parenthesis
> #163: FILE: net/bluetooth/hci_conn.c:2473:
> +	while ((conn = list_first_entry_or_null(head,
> +				struct hci_conn, list)) != NULL) {
> 
> total: 0 errors, 2 warnings, 1 checks, 57 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> /github/workspace/src/src/13227257.patch has style problems, please review.
> 
> NOTE: Ignored message types: UNKNOWN_COMMIT_ID
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.

Thanks,
Ruihan Li