Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1012514rwr; Thu, 4 May 2023 12:48:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6uIdKiXgkp9HuLLFfoSDsMPmC5vC4n3fw1Lamfc+1QqjJ9aqydygt/PZke2Lwx+Zftjrz5 X-Received: by 2002:a05:6a20:d396:b0:f8:5cc:d869 with SMTP id iq22-20020a056a20d39600b000f805ccd869mr3613315pzb.35.1683229683354; Thu, 04 May 2023 12:48:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683229683; cv=none; d=google.com; s=arc-20160816; b=RyXH326w3ZRIQcu5bMeMBanYkNxGFE/vEAIHKsB+c3ErstEPFO9cP1ljhdEEAyiAqT BfzmdC4SN8BJ/psZXifKFHJxZv9jFTJlgfEGt7rPP5k2WM1zYn0nwdBSu0HDb+qxm2qH i7qMcPm5MvWo5+jIQ7TRMOR/lcNY2dQdiUnKJSXtgsDeIjzG2rgRvWbvp+61MgKxC9MH 65KROb8yWYEzt5HYhGwiqIj6ORowVoIgGlJgAWXfDitutAgj2q3JHeWwcsJaGn5WylVx STDWZmLGOgpcYMc/xBJRh9HqNlIzIvKx0UaQ819AgrtOntkMN6kaiOFrEFE3sMjVd3/p odDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=weOIKE0Ead9+N4t9jIC5x2Ja4B7uI2ISxhqxIzxSiHE=; b=aLtiPWvCNrB+BNGciy/I7m2wVT44vE0VSBkepSragq+WcSzKu3lght+UivLhsN0LKl bHwnXCY0Sh+AJ8kkylOw9605j++wR5PQSYHJ79kp+SFfDFAuUb4LUQw2frZrqOBxCSfU J321JK7IFaRsBD242iZqYWDiNPbQEmlWL6J8uLy8NlAknD4GCT2iQHaf4xZoU0LCtaQx byP/JfDOCxw1vBR2cL3qJKKQDKsITeeq7H9vqR7P1l1z3wbJLifz5HuFzOumHDKPgxDK 7wsO+/k1sfMyFvq9ckmHScbpIJallCscqV6tASww/tv+5FAR5XUr+wcoC7h0OHVPgil8 hmRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="IAsR/AYw"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e4-20020a636904000000b0052c94fac45asi120789pgc.846.2023.05.04.12.46.49; Thu, 04 May 2023 12:48:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="IAsR/AYw"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230334AbjEDTqY (ORCPT + 99 others); Thu, 4 May 2023 15:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230369AbjEDTpk (ORCPT ); Thu, 4 May 2023 15:45:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8856714923; Thu, 4 May 2023 12:44:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8922063747; Thu, 4 May 2023 19:44:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BE03C4339E; Thu, 4 May 2023 19:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683229451; bh=eJwsPTF1sGf3gATrqhUnKCreLCEh7/RrYOxXYQr156c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IAsR/AYwNQdnXMXtOlIf6EfV0tEwjQobED/oRbgX3WLxPr1bGnBnmbiY/84rpMIKV vL3i4k+TbrAwbXAb/ECexF3XXjMCb8whuEmd/mlaRQ+J0X4siQnGPn6Vbj1o+DsznC v6eX42f4op4EBnTSwEUyNw4Exay7IUFIOsI185Imr/UsATdztZShhEmMCXxoGl0Npm O+Ksd6yMpZfGZUP8GcC9ZImEg7ktWYpdWMlF+9QK0+BGVpwrE7UHxaZRoQrxt2fXAd tdmpbuKUbvP9ySjyU77644XpYR4EfuBuCpoXdf0YsPdaK5431ItmB14AY7VJ5ykYWj dVFh3eSc3MAtg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Min Li , syzbot+9519d6b5b79cf7787cf3@syzkaller.appspotmail.com, Luiz Augusto von Dentz , Sasha Levin , marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.3 58/59] Bluetooth: L2CAP: fix "bad unlock balance" in l2cap_disconnect_rsp Date: Thu, 4 May 2023 15:41:41 -0400 Message-Id: <20230504194142.3805425-58-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230504194142.3805425-1-sashal@kernel.org> References: <20230504194142.3805425-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Min Li [ Upstream commit 25e97f7b1866e6b8503be349eeea44bb52d661ce ] conn->chan_lock isn't acquired before l2cap_get_chan_by_scid, if l2cap_get_chan_by_scid returns NULL, then 'bad unlock balance' is triggered. Reported-by: syzbot+9519d6b5b79cf7787cf3@syzkaller.appspotmail.com Link: https://lore.kernel.org/all/000000000000894f5f05f95e9f4d@google.com/ Signed-off-by: Min Li Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- net/bluetooth/l2cap_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 55a7226233f96..24d075282996c 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -4694,7 +4694,6 @@ static inline int l2cap_disconnect_rsp(struct l2cap_conn *conn, chan = l2cap_get_chan_by_scid(conn, scid); if (!chan) { - mutex_unlock(&conn->chan_lock); return 0; } -- 2.39.2