Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 15:11:26 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Luca Weiss <luca.weiss@fairphone.com>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        Johan Hedberg <johan.hedberg@intel.com>,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: btqca: make sure to handle byte order for
 soc_id
Message-ID: <ZFuX/l7kNrxHtDlD@corigine.com>
References: <20230510-btqca-byte-order-v1-1-82e6a371c5aa@fairphone.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230510-btqca-byte-order-v1-1-82e6a371c5aa@fairphone.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wXrhMNV3J01uX7ASluiBXsgdanYECSQLYB7GmU1Y0b2bOhMvXCAYPJs3WGd6?=
 =?us-ascii?Q?XUHQkXxya/KVOBfQEMGgi08+wZL/jobRyAVcQovqUxFPUnFRJz9qmXF1hCgR?=
 =?us-ascii?Q?/B8sFoBBG9e0y3l8/0tdeyeZkCLAVxh9Euh6D6bU23N6mIEC7HT1FA7TCN5/?=
 =?us-ascii?Q?SnhPelHTtwFKIeuv+DW/9lz39iBzj3KWsdcNqex6onLE1tnijSpZePYALAti?=
 =?us-ascii?Q?I8k2BZEnmbnyEeAYrQidSe3Y2WTDgXlohd5uewcSsTlVvFfq7vkq3tZNAE0u?=
 =?us-ascii?Q?YPaiQq2sU+utPMlVSY2NpHKaxL0cX1kzRS3Xzn6qHgX1MYea0ahhOwszz3eg?=
 =?us-ascii?Q?7b8AFZz7SsrzGR9a+PaulA5pPX6Ycm/0lAm1kEyO8SKDmMWp2UmJTYHdTfL+?=
 =?us-ascii?Q?MmbxFGVMdcfO6C9fhW1gaXDJ+9k71Z/y3RCgZ3JBFaA0fyuqAtvDf50ZpSVG?=
 =?us-ascii?Q?VoXL63d+QT4A2EhqIV1i+0Fhxjy0qqU03ly4n7o1C9uKeeojzEmdwNqpoIed?=
 =?us-ascii?Q?4wEWclWdQlqvvfT7sKYom2xHp5OwoBjYEG5Z5qlcRraEDN6iiqSXazEn1e1e?=
 =?us-ascii?Q?S04bt6SvU6HExANe6b9Bexj3Y1hUyxmUjEvuoMoWTlRSNgT/4JcR8feWJmnC?=
 =?us-ascii?Q?cPBygTo6YW1Fc3Wd9I6TXUtC5odkLKRuJjyudnlEKaiuInC/tZCNtLc6E3yQ?=
 =?us-ascii?Q?1Ax5gv3OkIWy9MAQ9H6ZpQ58w6L7HF8gHPj7jTfAo2cAz8jDxZhDu3CjYuJH?=
 =?us-ascii?Q?sEjtz2qMbAo8tDO8/79r9vCScAEqaSYhXPl92hZ3OeduruV6B4fTXANDXhBF?=
 =?us-ascii?Q?jx+rsFnaSPlLcdqo2M0ye5DOTuTDv76hiHiWVwpBV7brSkltDgZO+PUug/gC?=
 =?us-ascii?Q?S8sG3exVPxVDK3HHmB9KT/OJtMxqJ80HDo5NCJM71g7lipegKvRnHkXsj3zi?=
 =?us-ascii?Q?wfVudyNYCpOH3q0a1Lun6mAnbBeHgE2sHgnuV5s5fAQvi+ZTx74ADU4f1iM1?=
 =?us-ascii?Q?i4k55Tn3Xen61dpKKNJlgwrNh/dSBZqzMduVPTPSFFGwGo/9XiZbdjwLAQUm?=
 =?us-ascii?Q?XPs8ufEbXtseajHTcLTKKgVtgtlhHo/RhX+dLwoPCfW/SdVixCjwcD/g7Ufc?=
 =?us-ascii?Q?YxlNOvVPhfupaqCZSqtRhj0xsstDWwpmqWL5VjzTlprE3CwHQ9iGMBOtSTI5?=
 =?us-ascii?Q?VILEbIPGZepLiLg09LTnCSCRCo4vN0ecFg/gc3FlDcmb3r3zxGQeubX/905W?=
 =?us-ascii?Q?rku0EuZqzypnuUfD5ss4mV5txWIak4sz+2NyjmI2dwQ8UQ3xSKgDhecc6peH?=
 =?us-ascii?Q?1SoDBA4oLIzWeuarq0r3Kk/0ZpqNkcPAp0kF5fALIFqMVUuXBitdodnuEk6j?=
 =?us-ascii?Q?fCMFf3IrlmEj7BXVW1mV5omQeXee8/OhYUt9U8m2iWvpc3DkPaGKJjFNliKT?=
 =?us-ascii?Q?p8i8ud/jpT9+ILTyiBruL8PbaE+FWOqDGeDBYkgw7UApqDf7XsiYoGDf8OMx?=
 =?us-ascii?Q?KqNhgoPD+mma5e+7insY4W+6bAdfLxPPI/Fjzfv1K3ZW2Cs5S9OTejC5Y6qq?=
 =?us-ascii?Q?GuifAKt1RCviDoLS2L3kua56YbcKrHXzXk1pxGh6NG3E0pLqwMzgk7sDermV?=
 =?us-ascii?Q?kYLoyTZYvlMSJ5D0pPkiDNU1oAT8T3R0yNrNxan/4IXk/J4+G1NmCGBLI53m?=
 =?us-ascii?Q?1x9BuQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a525d37-7020-4eda-cf76-08db51581315
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 13:11:32.4158
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GJ2wdTd14BeHmvLi/n5raPs6/CD0lgo16vXZyYrSJsm9B6ZHx0/KIxrAzrYBFZM+oo4Z962tUyqEi8oh2OCLq8/xGnr9Mtw0gknJAtAF3fY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5576
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

On Wed, May 10, 2023 at 11:27:21AM +0200, Luca Weiss wrote:
> The field soc_id in struct qca_btsoc_version is __le32 so we need to
> convert it to host byteorder before using.
> 
> Reported-by: Simon Horman <simon.horman@corigine.com>
> Fixes: 059924fdf6c1 ("Bluetooth: btqca: Use NVM files based on SoC ID for WCN3991")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>