Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230511002252.30868-1-alice@ayaya.dev> <20230511002252.30868-2-alice@ayaya.dev>
In-Reply-To: <20230511002252.30868-2-alice@ayaya.dev>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 15 May 2023 12:17:30 -0700
Message-ID: <CABBYNZJu2bWA=RprU88Q3DhRmmcVEJUPrDmT2-WMEdkLGDe-ag@mail.gmail.com>
Subject: Re: [PATCH BlueZ 2/3] client/player: use long long for off_t print
To:     psykose <alice@ayaya.dev>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Psykose,

On Wed, May 10, 2023 at 5:42=E2=80=AFPM psykose <alice@ayaya.dev> wrote:
>
> %lld is guaranteed to be a 64-bit int, which we enforce via
> -D_FILE_OFFSET_BITS=3D64.
>
> Signed-off-by: psykose <alice@ayaya.dev>

We don't use Signed-off-by for userspace patches.

> ---
>  client/player.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/client/player.c b/client/player.c
> index 7719076c8..856997319 100644
> --- a/client/player.c
> +++ b/client/player.c
> @@ -3578,7 +3578,7 @@ static int transport_send_seq(struct transport *tra=
nsport, int fd, uint32_t num)
>
>                 offset =3D lseek(fd, 0, SEEK_CUR);
>
> -               bt_shell_echo("[seq %d %d.%03ds] send: %zd/%zd bytes",
> +               bt_shell_echo("[seq %d %d.%03ds] send: %lld/%lld bytes",
>                                 transport->seq, secs,
>                                 (nsecs + 500000) / 1000000,
>                                 offset, transport->stat.st_size);
> --
> 2.40.1

Perhaps we just promote offset to intmax_t and then print with %jd,
that way it should work regardless of the actual size of off_t.

--=20
Luiz Augusto von Dentz