Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     luiz.dentz@gmail.com
Cc:     iulia.tanasescu@nxp.com, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/1] Bluetooth: Add support for creating multiple BISes
Date:   Thu, 18 May 2023 10:15:07 +0300
Message-Id: <20230518071507.4640-1-iulia.tanasescu@nxp.com>
In-Reply-To: <CABBYNZ+mRgkn_PiL5=4NuQQudrQZQvdYqVuab3m_S7pRvj9YeQ@mail.gmail.com>
References: <CABBYNZ+mRgkn_PiL5=4NuQQudrQZQvdYqVuab3m_S7pRvj9YeQ@mail.gmail.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cSy2hFmRVDTw8v/e2iPYPp2XH6t6kS6tSrNHvj6VQJuQyrHxq2Izy8NG0Ixj?=
 =?us-ascii?Q?jnh0wdzf8DnSZc32Wgf+EMtqoCGFOLBECZrT479y1sYyxypkePkjXotUBxNZ?=
 =?us-ascii?Q?rd8ob6o5g28ectn/6sCdpscAJBZQzbtlxbT40TUEswhTYz5ApVUR+HAT/7n9?=
 =?us-ascii?Q?fyMsbnlP0Rg0f+8DV99IM5LH01GO1stVvfaY1Oxf7jANsk7h2oVW5oyx8fWP?=
 =?us-ascii?Q?TRi1WoZJw0gIC9IoaWyHMwurv7l8ffU+yC9vkQvHA0nTEY9SQzuFNIDvbnOp?=
 =?us-ascii?Q?hVNlxQ0TBXySI14DX4u7h7WVxd3jOPyR0E35N4YgDflS4muBo62SjL3QFsOS?=
 =?us-ascii?Q?9r+i316wr5k8lyhYNXHh7IzEwfo+hIBIk/CSzqPM1iW+UKFxWpcirTLe8OGx?=
 =?us-ascii?Q?/NI75vqQ+O1CuPHnDWDvq5mwyh4+zUQFTocPip0ctz3uAKESl+/YwJftOq5E?=
 =?us-ascii?Q?vC4Pqj1zrmiOdV/zCmDd2+AJnDpaqwajkN9awk+3dXl3aiPiCKx8MUjC7/3D?=
 =?us-ascii?Q?CTIXC3rqJLj5BBeGcfzVAI68AKEQSaZ8iN8cx3a9h7YcuI9W1jGxbCcegL8G?=
 =?us-ascii?Q?VezoyTVBHTQ/wMRPJ5fW6RY0jWULpk3+WNWl7lOD9WnDgruNBL8J8EJgF6KK?=
 =?us-ascii?Q?Ti+REq2Ci7lZbKlRSxX3rr40RPPAaLwe0ytGCzT4s6YFRz9vg5Rs0/EmHpoC?=
 =?us-ascii?Q?P0A0J+AgFX2iNn0tVpNsuxMaeqP2xwb3RQlzl8eczVqUFlJ6ysTzztYCzmRw?=
 =?us-ascii?Q?nlotsP3CttzblSwW9lQIZae5KY4HivNQFaWVndOgNuQc14+wO9+qHoqcXSuJ?=
 =?us-ascii?Q?/IxKhPS1n3eGiKvvvW/NuOZyQuUResrmsNGqfOBHbjOl6y/AlEjmQZghW7KG?=
 =?us-ascii?Q?KtgS5FGyHOsZw/2/7Eca/dWt4fPoMnQ8+9BgEZUpOTVrBpMhHr72KikL+qNw?=
 =?us-ascii?Q?+OTqcD+d/hAEM12jdCqOA+KxPdhyh/bb9KBVv9+128WCRJTEU3QLnRJtCpXu?=
 =?us-ascii?Q?TKoB4yMRoZ/PZruNSfSY1sbiTQlV/CLkm2ZtaKYqTQXW7b1UzgpntjaMwtO/?=
 =?us-ascii?Q?1KM3x6rPM2zwGti2kQjzR1nOQbM5T0UrQx7l5p5+9wYyaBjSwzrZVO8hVLTF?=
 =?us-ascii?Q?sC0HgpC5w71Sfu+/H+3WzO808VP3QdMYVuyVIB3wBjbKW26ekDVbN2Qr05CN?=
 =?us-ascii?Q?ndTHpbpclxxE6abbhvnHdA9qG1dEyXb9H9oadzfmjOSo47hBZRfRnhnpIxgd?=
 =?us-ascii?Q?uWlhmyGn40GJqwvEfFiutqhweCbrMllVjwuM3tvei0HZ2B1Lq3pybKc+YPQm?=
 =?us-ascii?Q?wfWHQLF8db6GippFtRM6lUji5msUdz2GuAk3fdB+yUjeocCITPgERm++sJjj?=
 =?us-ascii?Q?YXDYFOZQn29Ciwy00PzOuVQ98Y1e3QEq8o2yQkAqOeJfbj3IzVUA+C16AbA1?=
 =?us-ascii?Q?LJppp06pVTrtpN3vcFFZ2dfKCSE2G8sne6Xv87KOzD6MUt0B8lU0kYze+tDH?=
 =?us-ascii?Q?rYiR0zoPZoJkcxNo25F12yifwr2hZjVm085wD0ZMyDi4HWnGz27zqfaK+Sih?=
 =?us-ascii?Q?YestIsSJrKBTPg3T1q0rbjMsDcoNztonRsivQQlpI5XMB/WewW2bcU5g5J6C?=
 =?us-ascii?Q?0w=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89f885b1-5332-4294-fc93-08db576fa626
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 07:15:24.5386
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kVVMrAhMipTzcSR2Nv7Momni2ALcQII5sYTyOs+jJGx1UPp4CytQr0Ur314gz4/qEI7sdARU6YHI1XJo73ttpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7687
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Luiz,

Thank you for the review, let me better explain the flow that I proposed,
because I think I should have added a more detailed description to this
patch.

I added the num_bis field to the QoS structure so that the user can
specify from the start the total number of connections that will be
opened for the BIG, but one socket will always be connected to an
unique BIS.

So the user will first open a socket, set the QoS options with the
num_bis parameter set to the number of BISes, and then the user will
call connect on that socket. The BIG will be created with the specified
number of BISes, but the socket will only be connected to one of them.
The rest of the connection handles will be stored in the "bigs" queue
that I added.

Later on, the user might decide to open new sockets, for the rest of
the BISes that are created and stored in the queue. In this case,
the connect API on the socket will not issue the LE Create BIG command
again, but it will extract a connection handle from the queue and the
socket will be connected instantly.

As for the HCI_CONN_PER_ADV flag, I noticed that it was only checked
in the "bis_cleanup" function, to decide whether the advertising set
and the BIG should be terminated. I removed it because now I am only
terminating the advertising set and the BIG if all of the BIS handles
have been assigned and no other BISes are in the BT_CONNECTED state
for that BIG, so I thought I might not need the flag anymore.

I think it's a better idea to use DEFER_SETUP for binding multiple
BISes to a BIG, instead of using the num_bis QoS parameter, so that
I can keep each socket completely separated from information about
other connections, so I will update the implementation.

Regards,
Iulia