Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yongxin Liu <yongxin.liu@windriver.com>
To:     luiz.von.dentz@intel.com, marcel@holtmann.org
Cc:     linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Bluetooth: add missing hci_codec_list_clear() back
Date:   Sat, 20 May 2023 13:51:47 +0800
Message-Id: <20230520055147.3212541-1-yongxin.liu@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UP6YoeBEaTzciBKXfIfclcw7Bww0jQTLO0evRuovtByN+fJa7jAU9YAF/jie?=
 =?us-ascii?Q?o1dO5akTWh7Rg486RbR/ExPYDsc5lc+iuinwbCrirfMm17OdB8J43nukCRFG?=
 =?us-ascii?Q?tya+UU8hSq3U4mmiHaLutFd8Avat02KHZMdFyI+A7K9N7r5806PgJEUATp1M?=
 =?us-ascii?Q?A07vKLS2LQ+46WywargSWdvFdHxbakwZnecsa5jZyYAbivYr3rUp1/fAq6gs?=
 =?us-ascii?Q?tN23v23KVOVvLa5bUnudNf7XfrtfvshpMBSQ5d+hpECnmZTttORc10W+doeY?=
 =?us-ascii?Q?YF6bcCRYK25tU7R0DePzg0p5bts7fvhxjGMi8Khl49HHEc7iTSZ0XyQ+NfNo?=
 =?us-ascii?Q?IhIxlDS6OmPmqUHWD4KRr8p+ci16UjZZNzlYP4G5ya7cWHht8j6GUMbhsYbe?=
 =?us-ascii?Q?hqsv3VYmXaXRI8j2xx2TAGnVarMElPCH8cPfixRrdD7mjeL7dYgerFe2dWpX?=
 =?us-ascii?Q?X7NW3LQuQFy5V/Kkqo/meDV0qfhaJKLsJjf2yusr34iMAI+KdFZnkkmXfsWV?=
 =?us-ascii?Q?LOkhGLPbHjDX8MNjatZZUXSXTWBTNfyKQfrPS0C1Ytf4PAUdMBRIYcS90QtX?=
 =?us-ascii?Q?VTsXtcrczj1NJAT1jDIBJfLe1e/lt0I6YiDNZLlxdie6/5uHoLLxehidx6Ck?=
 =?us-ascii?Q?GMf/2DAgGO4Weyup2eGt+D9ULs3eY473/y7V0sSs6fFC5QGohxfw7B+dUHve?=
 =?us-ascii?Q?tgD0IUmUZOdIHsWI1jJE2oN75kHjvwhyzDmrZnos6Lx6owjjEIfdYeClaA5z?=
 =?us-ascii?Q?lLV4JAUc9UXvqgyk4OzVwlFGj0YHQdtREwfe4ABX6jqI0F/e1/xmsOWHBecX?=
 =?us-ascii?Q?Yt25zSKFpvsiV/bk+HFCnL4dPu2GgeJRnoyDLtbtdG+yugYUMvlAbAce6YlK?=
 =?us-ascii?Q?AoMPQ2Ryn3hOZCQyW6bCg0igi1F94h2C2pC2Q3GwXwWuxQ78cOxHJwxy3kIZ?=
 =?us-ascii?Q?1YRTECUjKv1NSXfhFtMXfjV7Tr8xxZIIsW3hWRXHdNEHht5xYGioGD4LcRTb?=
 =?us-ascii?Q?m68uwAqidHYFE6tdkpudCjaQGDj8eK+UpWWiVoHEMw8jyvFPGGkvXf1nCoXd?=
 =?us-ascii?Q?HvgSJaQg887BV/BYBSLVTjkG9B0iTQCglOdLWpBnkCnbkzq6VLEiBWgJNhCp?=
 =?us-ascii?Q?NssFGOUDoCtqPekR9Q68C52bfiIi01Do/gDlQObtY01U6k2yAChLbMB+Qd1x?=
 =?us-ascii?Q?dkeilNJe1t0sbqxDTM3TneS+Gupv28Xh9diFxoC97wa4y/vgxkJNCy3dJyz1?=
 =?us-ascii?Q?KgMrfiz5XWxvUhIfHTyTOaFCoJVDWclGxVnXOGZKqhOZ70hyEwawY1BG2bLn?=
 =?us-ascii?Q?nDqRwbWtD7GQGLMLw02J33S5TR0Jgpgs318IB4v7ZUJ7hIslA/QehcLj1c5o?=
 =?us-ascii?Q?yimFvfX6lq/6LTNzaLWOdoEOyKpstJSNlq2aCkwggzen5tvtl3LIgLJ3hUaM?=
 =?us-ascii?Q?R9wrsq28xBmD9f3/jIvpLqp1uxmV1Bm7/4v0rnrffeKHHlmhSwhB6ZgdDRqp?=
 =?us-ascii?Q?aVWipU5ZNM73bpk9jJjmmLr5SC6/IHeQ5lW9RVEmBCjDO8cEuQcMZYvz66bC?=
 =?us-ascii?Q?Qll9+H/nLQlJcS3KLtf+L7n0/441ufQVEBoCusDEgiy27gmH2EnXMBhLlx3C?=
 =?us-ascii?Q?bQ=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3714ae14-2e9c-43df-1007-08db58f6f550
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5175.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2023 05:56:30.7135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bHtaeSnJLOMN729pH5b7v7KwmPraW5gm5go7z4SkQ9PVNvKJ8LF0FKVbgMGKe+xKqvVE5niIiAxK3BxQbkxYxmGkfWFI01FVeG4JuvMhbr8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7551
X-Proofpoint-ORIG-GUID: H_4_w-e3MXoK1G5GsJBRmQAQtKUs8ckR
X-Proofpoint-GUID: H_4_w-e3MXoK1G5GsJBRmQAQtKUs8ckR
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-19_18,2023-05-17_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0
 mlxlogscore=999 adultscore=0 suspectscore=0 lowpriorityscore=0
 malwarescore=0 spamscore=0 impostorscore=0 bulkscore=0 clxscore=1011
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2304280000 definitions=main-2305200046
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

hci_codec_list_clear() was missing in commit d0b137062b2d
("Bluetooth: hci_sync: Rework init stages"). Without it, there
are following kernel memory leaks.

  unreferenced object 0xffff9fe454c12ca0 (size 32):
    comm "kworker/u9:0", pid 82, jiffies 4294756186 (age 75.617s)
    hex dump (first 32 bytes):
      a8 93 7b 76 e4 9f ff ff e0 2d c1 54 e4 9f ff ff  ..{v.....-.T....
      00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    backtrace:
      [<ffffffff9add1386>] __kmem_cache_alloc_node+0x1e6/0x3d0
      [<ffffffff9ad47ea1>] __kmalloc+0x51/0x1a0
      [<ffffffff9bd01025>] hci_codec_list_add.isra.0+0x35/0xc0
      [<ffffffff9bd011e7>] hci_read_codec_capabilities+0x127/0x1f0
      [<ffffffff9bd01465>] hci_read_supported_codecs+0x115/0x1e0
      [<ffffffff9bd02658>] hci_read_local_codecs_sync+0x28/0x40
      [<ffffffff9bd06f5f>] hci_init_sync+0x14f/0x360
      [<ffffffff9bd096b8>] hci_dev_init_sync+0xf8/0x180
      [<ffffffff9bd0b67a>] hci_dev_open_sync+0x8a/0x2e0
      [<ffffffff9bcadbc0>] hci_power_on+0x60/0x220
      [<ffffffff9aad0a37>] process_one_work+0x257/0x580
      [<ffffffff9aad0dc8>] worker_thread+0x58/0x3c0
      [<ffffffff9aadb97b>] kthread+0x10b/0x140
      [<ffffffff9aa023f9>] ret_from_fork+0x29/0x50

Fixes: d0b137062b2d ("Bluetooth: hci_sync: Rework init stages")
Signed-off-by: Yongxin Liu <yongxin.liu@windriver.com>
---
 net/bluetooth/hci_sync.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 647a8ce54062..e94a5648e08a 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4994,6 +4994,7 @@ int hci_dev_close_sync(struct hci_dev *hdev)
 	memset(hdev->eir, 0, sizeof(hdev->eir));
 	memset(hdev->dev_class, 0, sizeof(hdev->dev_class));
 	bacpy(&hdev->random_addr, BDADDR_ANY);
+	hci_codec_list_clear(&hdev->local_codecs);
 
 	hci_dev_put(hdev);
 	return err;
-- 
2.39.2