Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <024df2d86c14fc811701ba27bfa576476bc9c0d6.1684682575.git.pav@iki.fi>
 <168478682055.7079.605631444073463509.git-patchwork-notify@kernel.org>
In-Reply-To: <168478682055.7079.605631444073463509.git-patchwork-notify@kernel.org>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 22 May 2023 13:27:49 -0700
Message-ID: <CABBYNZ+2X1k9J0QJVwBTi9yP3inTOmoroAtovHgv0XZbdBCpPQ@mail.gmail.com>
Subject: Re: [PATCH BlueZ 1/5] iso-tester: always use DEFER_SETUP for multiple
 CIS in same CIG
To:     patchwork-bot+bluetooth@kernel.org
Cc:     Pauli Virtanen <pav@iki.fi>, linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Pauli,

On Mon, May 22, 2023 at 1:20=E2=80=AFPM <patchwork-bot+bluetooth@kernel.org=
> wrote:
>
> Hello:
>
> This series was applied to bluetooth/bluez.git (master)
> by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
>
> On Sun, 21 May 2023 15:27:34 +0000 you wrote:
> > There is a race between multiple connect() for CIS in the same CIG.
> > connect() will both reconfigure the CIG and connect the CIS, but CIG
> > cannot be reconfigured once one CIS has already connected.  That these
> > tests pass currently relies on some timing/event ordering in the
> > emulator.
> >
> > Connecting multiple CIS in same CIG is meant to be done using
> > DEFER_SETUP, so change the tests to use it, so we test the intended
> > usage.
> >
> > [...]
>
> Here is the summary with links:
>   - [BlueZ,1/5] iso-tester: always use DEFER_SETUP for multiple CIS in sa=
me CIG
>     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3Da88c74e29b6e
>   - [BlueZ,2/5] shared/tester: retain test failure status
>     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3D195b9abbae0e
>   - [BlueZ,3/5] btdev: support multiple CIG
>     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3D678265f37c28
>   - [BlueZ,4/5] btdev: report right reason for local Disconnect complete
>     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3D0c32cfdf9462
>   - [BlueZ,5/5] iso-tester: add tests for multiple simultaneous CIG
>     (no matching commit)

Ive ended up making some changes to patch 5/5 so it combines AC 1 with
AC 2, we can probably extend these tests to have more combinations of
different AC, etc, just to make sure the code can handle them
properly.


--=20
Luiz Augusto von Dentz