Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <e52365b8-f5ee-48d9-ba86-34c4b350c8e3@kili.mountain> <744fd69a-c5a3-4e0f-8c47-33096a1cd374@kili.mountain>
In-Reply-To: <744fd69a-c5a3-4e0f-8c47-33096a1cd374@kili.mountain>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 24 May 2023 12:11:08 -0700
Message-ID: <CABBYNZJ2WSHKiQ0ZtqfNZdxaPY+FVO1=gDeNPwSz2zcKWX6ZMA@mail.gmail.com>
Subject: Re: [bug report] Bluetooth: Add initial implementation of BIS connections
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     luiz.von.dentz@intel.com, linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Dan,

On Tue, May 23, 2023 at 11:52=E2=80=AFPM Dan Carpenter <dan.carpenter@linar=
o.org> wrote:
>
> On Wed, May 24, 2023 at 09:38:34AM +0300, Dan Carpenter wrote:
> > Hello Luiz Augusto von Dentz,
> >
> > The patch eca0ae4aea66: "Bluetooth: Add initial implementation of BIS
> > connections" from Mar 9, 2022, leads to the following Smatch static
> > checker warning:
> >
> >       net/bluetooth/hci_conn.c:943 hci_le_remove_cig()
> >       warn: passing zero to 'ERR_PTR'
> >
> > net/bluetooth/hci_conn.c
> >     939 static int hci_le_remove_cig(struct hci_dev *hdev, u8 handle)
> >                                                            ^^^^^^^^^^
> >
> >     940 {
> >     941         bt_dev_dbg(hdev, "handle 0x%2.2x", handle);
> >     942
> > --> 943         return hci_cmd_sync_queue(hdev, remove_cig_sync, ERR_PT=
R(handle), NULL);
> >                                                                        =
  ^^^^^^
> > handle is a u8.  It can hold error codes.
>
> s/can/cannot/.

This is not used as an error though, it is more like INT_PTR, that
said I'm fine changing it if that is triggering static analyzer
errors.

> regards,
> dan carpenter
>


--=20
Luiz Augusto von Dentz