Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH BlueZ 1/2] shared/bass: Add Write Without Response property to the CP characteristic
Date:   Mon, 29 May 2023 11:46:49 +0300
Message-Id: <20230529084650.72126-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20230529084650.72126-1-iulia.tanasescu@nxp.com>
References: <20230529084650.72126-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RpmnXku5ozBGOSwPZFVxA7yxLWoonUa/ARo9r7GGW2V+yPctSoYwoO7WV234?=
 =?us-ascii?Q?af4yGlWUbJKxMV7CpDqpVSVl0JQm4lYyQK8Z7c3LtyljzNPDgKiMx8x5xSw8?=
 =?us-ascii?Q?OelxFeGxzqRyTQdayF17cG0fzABT1SNDBUEz9s0mt3/CRD7LGA40Xbo/Ht3R?=
 =?us-ascii?Q?zBHXCLaAD25ynAo8N4RUd9emtGZPJSEosIqPyzqJLOTXZY0Vecx//GqtbhKK?=
 =?us-ascii?Q?gCIEzRMqiuznDJV2T+AJfgiaZo+YI4AkxDN/74wENFFWSR5IlUt+lOnmQblG?=
 =?us-ascii?Q?mj5w5+/1gjSNSg9qZfjsp5f7P0IOnavRC1Vd9P5M2yhZQpvrBIxnA1krlP9J?=
 =?us-ascii?Q?xoEOBZXA3FBzH52QxckJ1H9Kcm4O0zbN33LfgFbDskiSSwiPBYQQX0kvRu+s?=
 =?us-ascii?Q?h+mYSIpnEHC4S/O6sN43dtUnaJQfDgQNKpGBWUYYobauWr+moNR5lloxLk7D?=
 =?us-ascii?Q?VweUNtxBgRgAcklyfw4UyzHI633JkuVEfJ0piHgtdRJy0YplKqpn7hzTWmNH?=
 =?us-ascii?Q?bsx9hvc6soe5bzt/RlOtw+OTzaJ2IjgAtN6VygDEs7msM66mt9HVoPpUJfM+?=
 =?us-ascii?Q?sHepyJdYHE5iqHOIn9x5KxvIe/n7HnCTI6cZgKhmJLK38psjmI78zJ7xgPJx?=
 =?us-ascii?Q?LsOypp9Vzfi3yfxVIKB2ZSZNFtRgpjYVFyEkIYmaQRzzFgzfzh8UTPO3ztof?=
 =?us-ascii?Q?lLgGC7EO4UUU9FqWcDGQxjBY4eJnThlPFpu/8m0rr6pxUWFgmwjjth/Q7+Fa?=
 =?us-ascii?Q?ZnlnOAKLWtvhAZ2VWQAt93qkNL3tio7XBtvATGlt6dHMBiKLrEiS01VCXuzg?=
 =?us-ascii?Q?i+IIgDFBaKN2+c9k/lEWqtw94arirkm8jc+72t6y4u3TDCFIfU2kRVSoYXrP?=
 =?us-ascii?Q?VthsXKFYCbUZUI/hJnelq/VhvZpdwEbr9vFWFl5L2Lp9z3W7dH+emd5DEHUj?=
 =?us-ascii?Q?knKAXDw4/M9uuCANTnCUF1C1vTImxmfgyMUYo1h3GvyjcUcfsMhU89XQKoes?=
 =?us-ascii?Q?z/ZVKJaZjkIhvxeZaF5hg1czJC/pdFpCwK4LAbawMIuhPHyy3CH5JZD7NPJ6?=
 =?us-ascii?Q?JmGSkfzyJdTb95rdYCh85s9SdCIbx/2lxrjdIX4Zf9KrgKf0JGOJ4W8PivoI?=
 =?us-ascii?Q?WnNsRqq+1W5sK73kTZFa8OY0NS2gY6OUAhPiOicylRMqQPGuLb7Rf4EWtCqO?=
 =?us-ascii?Q?B+dDa7AkRTGA73AR7uuDF3+2oM9b1zaV3lbK3cZSkDIQ+aWj458wyfk5VAnB?=
 =?us-ascii?Q?4uiPhdheqDTEOCT2A3omzw4tiwFPLYEtR7mC6G7xSditFOXpENrrCPIm///w?=
 =?us-ascii?Q?6OJh9VFE4FQ2L4cRjeVUonMyVbitjz/JpQ2AGzmT8fE+ijLadGMnygYCRvir?=
 =?us-ascii?Q?bRLkcad1wVJ8p/x2v3DreKtjzihI1zPq5qPCZ8IjFsiWsDEgZ0JKz7EkksyL?=
 =?us-ascii?Q?SUZsEPIMlwsq/Ew9d2hww9wR3n+uVZmbhnTlcLzDhZyo0jZ6K06BSSkQdYxe?=
 =?us-ascii?Q?uYO5AI/ygY9b9WeA8AFMyOG9vrmjIt4TbY17jLhRYvKt/P12ridLPoPWkgm8?=
 =?us-ascii?Q?xsiT+fm4Aib0Q+82SQwBjEm5meQuyaZELPWKNwaixQyjdY15cQUbya576YFU?=
 =?us-ascii?Q?BA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75e9b5f6-6ad8-4c4d-a9b4-08db60214c12
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 08:47:13.0382
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jToF25yQ6fjrPRr+B0P6S4CHIZdOy+7irZJwYV3XJZJdeWVFPRHQ1M4/ZTB0t3tJwCs55xRPeJyQdwXt6nMgNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7074
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

This adds the Write Without Response property to the Broadcast Audio
Scan Control Point characteristic, which is mandatory according to
specification.

---
 src/shared/bass.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/shared/bass.c b/src/shared/bass.c
index fd4f28ac5..8906ca1ef 100644
--- a/src/shared/bass.c
+++ b/src/shared/bass.c
@@ -567,7 +567,8 @@ static void bass_new(struct bt_bass_db *bdb)
 		gatt_db_service_add_characteristic(bdb->service,
 				&uuid,
 				BT_ATT_PERM_WRITE,
-				BT_GATT_CHRC_PROP_WRITE,
+				BT_GATT_CHRC_PROP_WRITE |
+				BT_GATT_CHRC_PROP_WRITE_WITHOUT_RESP,
 				NULL, bass_bcast_audio_scan_cp_write,
 				bdb);
 
-- 
2.34.1