Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230530141339.100733-1-silviu.barbulescu@nxp.com>
In-Reply-To: <20230530141339.100733-1-silviu.barbulescu@nxp.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 30 May 2023 17:22:42 -0700
Message-ID: <CABBYNZJ1=ehCm5aDnOO=Zk1gYcxzMk6w0+ASaCrccWTNZWoGHA@mail.gmail.com>
Subject: Re: [PATCH BlueZ v3 0/4] Add initial support for BAP broadcast source
To:     Silviu Florian Barbulescu <silviu.barbulescu@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Silviu,

On Tue, May 30, 2023 at 7:15=E2=80=AFAM Silviu Florian Barbulescu
<silviu.barbulescu@nxp.com> wrote:
>
> This patch adds initial support for BAP broadcast source.
>
> The current implementation allows BAP source endpoint registration,
> media transport creation, transport acquiring and sending broadcast ISO d=
ata.
>
> Currently, one BIG containing one BIS is supported.
>
> To test the current implementation use bluetoothctl with the following co=
mmands:
> # endpoint.register 00001852-0000-1000-8000-00805f9b34fb 0x06
> # transport.acquire /org/bluez/hci0/dev_00_00_00_00_00_00/pac_broadcast0/=
fd0
> # transport.send /org/bluez/hci0/dev_00_00_00_00_00_00/pac_broadcast0/fd0=
 <file.wav>

I was trying to test this but it doesn't work for me:

transport.acquire /org/bluez/hci0/dev_00_00_00_00_00_00/pac_broadcast0/fd0
Transport /org/bluez/hci0/dev_00_00_00_00_00_00/pac_broadcast0/fd0 not foun=
d

Anyway I would suggest not to create the endpoint at
device_00_00_00_00_00_00 as that is sort of overkill just to be able
to broadcast, instead we can probably expose it at adapter level e.g:
/org/bluez/hci0/pac_bcast0, and we configure it like:

endpoint.config /org/bluez/hci0/pac_bcast0 /local/endpoint/ep3 [preset]

> The curent implementation checks that ISO_BROADCASTER is suported on the =
board so
> "Check for ISO support in controller" patch is required
> (https://patchwork.kernel.org/project/bluetooth/patch/20230510134557.1148=
6-2-claudia.rosu@nxp.com/)
>
> Silviu Florian Barbulescu (4):
>   Split bt_bap_qos structure into unicast and broadcast structures
>   Update bluetoothctl with support for broadcast source
>   This adds the initial code for BAP broadcast source
>   Update BAP plugin with broadcast source support

Btw, please use proper prefix e.g. shared/bap, client/player, etc, and
there are still some lines that are over 80 columns that need fixing.

>
>  client/player.c            | 223 +++++++++++++++--
>  profiles/audio/bap.c       | 478 ++++++++++++++++++++++++++++++++-----
>  profiles/audio/media.c     | 142 +++++++++--
>  profiles/audio/transport.c |  57 +++--
>  src/shared/bap.c           | 370 ++++++++++++++++++++++------
>  src/shared/bap.h           |  80 +++++--
>  unit/test-bap.c            |  75 +++---
>  7 files changed, 1168 insertions(+), 257 deletions(-)
>
>
> base-commit: 7002ecc8914ab1f22e36bd98c4d46eb760edf767
> --
> 2.34.1
>


--=20
Luiz Augusto von Dentz