Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1685294131.git.pav@iki.fi> <46eefccceb45556120a0d1fa95cf27c576e9649a.1685294131.git.pav@iki.fi>
 <8eacbb0919470938a9ea10fc507d684b6a6d169f.camel@iki.fi>
In-Reply-To: <8eacbb0919470938a9ea10fc507d684b6a6d169f.camel@iki.fi>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 31 May 2023 12:16:53 -0700
Message-ID: <CABBYNZJy7vC4cz5zrm4hkYx0w5hBRykxC5nRnJxEMMgKu1uRKQ@mail.gmail.com>
Subject: Re: [PATCH 1/6] Bluetooth: ISO: fix maximum number of CIS in Set CIG Parameters
To:     Pauli Virtanen <pav@iki.fi>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Pauli,

On Sun, May 28, 2023 at 4:58=E2=80=AFPM Pauli Virtanen <pav@iki.fi> wrote:
>
> su, 2023-05-28 kello 17:44 +0000, Pauli Virtanen kirjoitti:
> > The maximum CIS_Count is 0x1f (Core v5.3 Vol 4 Part E Sec 7.8.97).
> >
> > Fixes: 26afbd826ee3 ("Bluetooth: Add initial implementation of CIS conn=
ections")
> > Signed-off-by: Pauli Virtanen <pav@iki.fi>
> > ---
> >  net/bluetooth/hci_conn.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> > index 1f906f8508bc..7b1a83ec50ae 100644
> > --- a/net/bluetooth/hci_conn.c
> > +++ b/net/bluetooth/hci_conn.c
> > @@ -788,7 +788,7 @@ struct iso_list_data {
> >       int count;
> >       struct {
> >               struct hci_cp_le_set_cig_params cp;
> > -             struct hci_cis_params cis[0x11];
> > +             struct hci_cis_params cis[0x1f];
> >       } pdu;
> >  };
> >
> > @@ -1815,7 +1815,8 @@ static bool hci_le_set_cig_params(struct hci_conn=
 *conn, struct bt_iso_qos *qos)
> >       }
> >
> >       /* Reprogram all CIS(s) with the same CIG */
> > -     for (data.cig =3D qos->ucast.cig, data.cis =3D 0x00; data.cis < 0=
x11;
> > +     for (data.cig =3D qos->ucast.cig, data.cis =3D 0x00;
> > +          data.cis < ARRAY_SIZE(data.pdu.cis);
> >            data.cis++) {
> >               data.count =3D 0;
> >
>
> Probably should also have cleaned up this loop while at it, the command
> takes 0x1f configurations at most, but CIS IDs are <=3D 0xef. For v2...

Can you prioritize this set? I'd like to have it merged asap since
without it CI is failing some tests.


--=20
Luiz Augusto von Dentz