Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230606120824.4705-1-nitin.jadhav@nxp.com>
In-Reply-To: <20230606120824.4705-1-nitin.jadhav@nxp.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 6 Jun 2023 16:14:25 -0700
Message-ID: <CABBYNZJZJTSpm4MNpBq-Q2gUozLz2S9c4p-Zya6CwnWWv=QfxA@mail.gmail.com>
Subject: Re: [PATCH BlueZ v1 0/2] Code handling for VOCS service
To:     NJNXP <nitin.jadhav@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org, devyani.godbole@nxp.com,
        mihai-octavian.urzica@nxp.com, silviu.barbulescu@nxp.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Nitin,

On Tue, Jun 6, 2023 at 5:09=E2=80=AFAM NJNXP <nitin.jadhav@nxp.com> wrote:
>
> Hello Maintainers
>
> This patch series handles code implementation for mandatory features of
> Volume Offset Control Service.
>
> Implementation of following features have been handled in this patch
> series
> - Volume Offset Control Service
> - Volume Offset State Characteristic (Read, Notify)
> - Audio Location Characteristic (Read)
> - Volume Offset Control Point Characteristic (Write)
> - Audio Output Description Characteristic (Read)
> - Set Volume Offset
>
> All the code implementation has been tested using PTS testing the
> verdict is PASS for all mandatory test cases.

Great, though at this stage I think it would be even more important to
have a unit tester for the bt_vcp instance, just as we do have for
bt_bap and bt_bass in unit/test-bap.c and unit/test-bass.c
respectively, this would help us making sure there are no memory
issues and avoid introducing regressions going forward.

> Thank you in advance for your review.
>
> Warm Regards
> Nitin Jadhav
>
> NJNXP (2):
>   Added initial code for handling VOCS
>   Fixed the following issue observed during PTS testing for mandatory
>     test cases - Specified Upper and Lower Limit for Volume offset -
>     Corrected the number of handles for VOCS - VOCS is made as included
>     service of VCS because VOCS is secondary service and VSC is primary
>     service
>
>  lib/uuid.h       |   5 +
>  src/shared/vcp.c | 547 ++++++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 550 insertions(+), 2 deletions(-)
>
> --
> 2.34.1
>


--=20
Luiz Augusto von Dentz