Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3c218601-d21e-7a51-c215-e39e4f0c49c1@molgen.mpg.de>
Date:   Wed, 7 Jun 2023 14:24:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH BlueZ v2 1/2] Added initial code for handling VOCS
To:     Nitin Jadhav <nitin.jadhav@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org, devyani.godbole@nxp.com,
        mihai-octavian.urzica@nxp.com, silviu.barbulescu@nxp.com
References: <20230607121342.6136-1-nitin.jadhav@nxp.com>
 <20230607121342.6136-2-nitin.jadhav@nxp.com>
Content-Language: en-US
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20230607121342.6136-2-nitin.jadhav@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Nitin,


Thank you for your patch.

Am 07.06.23 um 14:13 schrieb Nitin Jadhav:

It’d be great if you used imperative mood in the commit message 
summary/title. Maybe:

Add initial VOCS code

> This adds implementation for VOCS service and characteristics

Please document the datasheet name and version, you used to write the code.

If you summarized the implementation, and also documented how you tested 
this, that’d be great.

> ---
> v2: Corrected prefixs and cosmetic changes (Luiz Augusto von Dentz)
> ---
>   lib/uuid.h       |   5 +
>   src/shared/vcp.c | 537 +++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 542 insertions(+)

[…]


Kind regards,

Paul