Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2295907rwd; Fri, 9 Jun 2023 09:11:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4kXd6iUKoIpfbTkRo2Mw7CYfV6VdMo3+AXjw2fKSYa2C8VMMHbQP6Jo/5iooIWJzyi467C X-Received: by 2002:a05:6a20:4323:b0:102:5e06:1544 with SMTP id h35-20020a056a20432300b001025e061544mr2131425pzk.30.1686327069938; Fri, 09 Jun 2023 09:11:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686327069; cv=none; d=google.com; s=arc-20160816; b=0uxaX3+NIDGpuhM89ZvOuHBRO89G9hdPWglE1IgiyzB+XRmab0mNU3ivaxpnLTfsbc vmYI6SeddK/IeIm29h3NN/r5upQ977b/r9WbuuSLqcVQpSi+hQupNVTAGgEHkNDsVCy6 7sSdjh1fLjRlZVw/f0Q7+cWyNNCgi9Vew3eSrtso0bKKl7QhpsL1LRn8IJ0mU7Bq/dem K4LbD3/CJnoWh3oWW7x/dh0i3aupaS+oB+RAumpv/FiyRv++0gnsTxpcFl/inY7sTkfB 9eh1dB4SrJ33GSyluwIlNGcSh5NkFJlKLa1MTrL9i0d+V5kJzjjOx9l7INctUMsfRFLn 0hhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZASR5/BmaalzeTJJhd66JJTvqi7hh0GteSbPgdTii+8=; b=DVh9BSCSocFy9aVDmwIY47LXA6REhRd5wl4ZK9ZFxQicQBFTEV1dgo9qZo190k3DKy Xt8YNR4gT7fq4UGS+FDDxEyCvRH2mAjrWdODJzeKY0pdZtoKOkuAa1AKT3Wf9GTGtrG0 mSi0mv1++JQEsxAv2y0uGI+oxZWmdAEnQN9+TV4pyDXlnQm2M5BLnMonYHwf/m0IMS1e hTAsqG/SWGZ9/5kQ2hp1vwJCMw+aT/FevhO8fGNiYgTYnOE0jeW0MA6m23urLGVPssFV L7eF2nKgALxb9r/t/4SAJw46pajb2hpD8oVNYzdvzVJ5I1BmukYLYCi1IzVqesrYgKmR XA+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h8qy1aAN; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g2-20020a636b02000000b0053eedcc332esi2670307pgc.763.2023.06.09.09.10.55; Fri, 09 Jun 2023 09:11:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h8qy1aAN; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241560AbjFIP73 (ORCPT + 99 others); Fri, 9 Jun 2023 11:59:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241787AbjFIP73 (ORCPT ); Fri, 9 Jun 2023 11:59:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4A6730CD for ; Fri, 9 Jun 2023 08:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686326321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZASR5/BmaalzeTJJhd66JJTvqi7hh0GteSbPgdTii+8=; b=h8qy1aANWl6VjpJYGa704iWUmO7QK6hrwNUB/KBnQ5snU0RD5i4sxCZCYZ2/daCK9lsIvv 9fHtMm4F7xyzodQYfsisfrQzLiuMi8GdqLxOkcAUNtWNEZ4LMhhHgsGWxklsBNvzIrrVp/ G0t3orNXgtFhASRPrmS11cZyDYQzuTA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-3xJqja4SN4C1wlC-zyTCYQ-1; Fri, 09 Jun 2023 11:58:39 -0400 X-MC-Unique: 3xJqja4SN4C1wlC-zyTCYQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f7eb415010so9440725e9.0 for ; Fri, 09 Jun 2023 08:58:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686326318; x=1688918318; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZASR5/BmaalzeTJJhd66JJTvqi7hh0GteSbPgdTii+8=; b=i3L75sU56BugVdVzoHpwZLSpMdij8hX4rLAalSHCg4HTO00+C9UkO7ws0lEJ6SZySM T4MUY0zxzSeQnDQCmcd5Qz3A9jm8cqxf+vZ8ZcpRISDvZX0gX73oms/rHGhmHWSt9X2Z aU7kcG71Nicsx3ytJb/jSGMm+JDK2o9J/+lRKgH7/LDh4gGQJVQBHMO8KNmgbUCdo8Mu xidJGAvHvN4zv3XZQC0nkUJj+dibA+IKWM9sZQRSzQHdoG2WX0tsdTOYqZwXTdIWaern F3gRezJqoTlHY/epLbOBPZ2ZmdWeATOpEf3rnSrDaGYUbYSAZQEi2nw59MsLNrCL4xFM Ah3w== X-Gm-Message-State: AC+VfDz/bVvNrke27TvPr/4fHPDX9OPlKJWZZwLpitrT4x9wdmCiLfXq d6ayMaPhD8TZNqzCZ4gPhvmGp4EGyXL1dWPD40RnPZLjXM50OeqINhLnH0R3MXJ66Xfzkzvo47d +Nc/+rQhJtL6zAnxSKPtKYkYEeoBJ X-Received: by 2002:a05:600c:3547:b0:3f7:f589:b5ca with SMTP id i7-20020a05600c354700b003f7f589b5camr4161990wmq.15.1686326318079; Fri, 09 Jun 2023 08:58:38 -0700 (PDT) X-Received: by 2002:a05:600c:3547:b0:3f7:f589:b5ca with SMTP id i7-20020a05600c354700b003f7f589b5camr4161975wmq.15.1686326317767; Fri, 09 Jun 2023 08:58:37 -0700 (PDT) Received: from redhat.com ([2a06:c701:7403:2800:22a6:7656:500:4dab]) by smtp.gmail.com with ESMTPSA id y19-20020a05600c365300b003f7f60203ffsm3065248wmq.25.2023.06.09.08.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 08:58:37 -0700 (PDT) Date: Fri, 9 Jun 2023 11:58:34 -0400 From: "Michael S. Tsirkin" To: Xianting Tian Cc: arei.gonglei@huawei.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, herbert@gondor.apana.org.au, davem@davemloft.net, amit@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Xianting Tian Subject: Re: [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs Message-ID: <20230609115818-mutt-send-email-mst@kernel.org> References: <20230609131817.712867-1-xianting.tian@linux.alibaba.com> <20230609131817.712867-2-xianting.tian@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609131817.712867-2-xianting.tian@linux.alibaba.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Fri, Jun 09, 2023 at 09:18:15PM +0800, Xianting Tian wrote: > From: Xianting Tian > > Cpu stall issue may happen if device is configured with multi queues > and large queue depth, so fix it. > > Signed-off-by: Xianting Tian include a Fixes tag? > --- > drivers/crypto/virtio/virtio_crypto_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/crypto/virtio/virtio_crypto_core.c b/drivers/crypto/virtio/virtio_crypto_core.c > index 1198bd306365..94849fa3bd74 100644 > --- a/drivers/crypto/virtio/virtio_crypto_core.c > +++ b/drivers/crypto/virtio/virtio_crypto_core.c > @@ -480,6 +480,7 @@ static void virtcrypto_free_unused_reqs(struct virtio_crypto *vcrypto) > kfree(vc_req->req_data); > kfree(vc_req->sgs); > } > + cond_resched(); > } > } > > -- > 2.17.1