Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, silviu.barbulescu@nxp.com,
        andrei.istodorescu@nxp.com, mihai-octavian.urzica@nxp.com,
        vlad.pruteanu@nxp.com, Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH 0/1] Bluetooth: ISO: Support multiple BIGs
Date:   Tue, 13 Jun 2023 17:20:16 +0300
Message-Id: <20230613142017.9337-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sGF3nACb6GChVoXZe55o+xJ3z2VL7e4XkimnZy2dJKTHNmEtmaW3MpQ9rozo?=
 =?us-ascii?Q?FYYrCbBtik41RC3Yg2AHbEbLXmXrYozf56le/eMXQwfRUCJX4IinyzUMxXyv?=
 =?us-ascii?Q?tf0yll7VXRtl7aMoiX4HQNacD+ha03KhnyuqddNnFf1QaWXAdsdqvEY9QTh9?=
 =?us-ascii?Q?Y9K7KlVsNTNsyG0HKYxXTC+oj5Ifcy93NoelnJnhHq29FMIBqaZcFhCeTOND?=
 =?us-ascii?Q?QhTfRJorpcvGCYHYhqWyqls1BU/S884HT9VwXZ7D7oAHGMjKPan3Kr9ZzLCM?=
 =?us-ascii?Q?XcnwOa+1pKr8dhdzWTIGHqLy6JL+CV1eT8E62PyUcHqFAKnzHRN1E5eHNEWh?=
 =?us-ascii?Q?ibjQbBnjA36ZL0Xb+M9DPi71zDCpGWCc/gUz7LlF9jPvvc2rNRDP0jvcB1Hm?=
 =?us-ascii?Q?V9QMOsrylihmOJdLRhKp4CP10zf/A6dqVxLxao6dPsg05txYfQFNqaUcedbm?=
 =?us-ascii?Q?CJDOfPG7oDi23THISjKotlzteFwg8rWM2LnqWTw5i/8Mk9IT0YReQtjTBpOu?=
 =?us-ascii?Q?qZ+Q9ooXcrGDpdYah8DQpNfKbAhwIjPH5rOfUvaE5iR/Sr3jrArsRqVMrTQK?=
 =?us-ascii?Q?fNqGcZXV6HCW+ffJtfaUgDDBCV1A6VMo9d4ho89bJWIMZFsf3oFuhI17iPtZ?=
 =?us-ascii?Q?iFVksqf6vFHq+ZQYt/2SsOVQH135RNlMrKsksBEpynngJMjjwRmmY6jxI877?=
 =?us-ascii?Q?mZApoKugc4EyJK3szIhgjX4yNkzro2bcqsFxG9vYL5Y7XXkUD2KMoUdm+BGb?=
 =?us-ascii?Q?KW8ygG/LTGAbG/J+MkUQLg6/yfnmhCkFlfWzkBwdwVQgCtdCZ4TWBsalseCX?=
 =?us-ascii?Q?iSe6CQ0EdmY3bg6VPhf2P+8GEV/5x3Pvy07yWb0jcMNXlibwdlCYpVZtwhNR?=
 =?us-ascii?Q?4EGUuDrXPifhxsvL2NqODV135C1L0VNPfMsPtofbtY860X7HxLhKgLqrI/GY?=
 =?us-ascii?Q?EYQHINfVvwQzgwSX2JgejWap9h8aVzDahvu8qo9vyKIeMorgV9VnJbNl5AxV?=
 =?us-ascii?Q?7O8iB2q/z8xOF+CwCfTulvGKhmQiI58US06uw9zlv3fjtjALP6XgFsVMWCTV?=
 =?us-ascii?Q?6C8rR6n+to66q4/qEuLSbeoG60lYRSaqUAOJrQl3Me9Ugoe/l5XX81/gpjjG?=
 =?us-ascii?Q?4s2f9lxpcuIoISQ4kAUFhk2lO+IEuKaaW1ulmYnX9cMYjbM6yo+MP9ThqXJw?=
 =?us-ascii?Q?V5rLNTPdacf6zCiDpLNEGPxlD6wZw7FW03fAuMLwOH084zXAKgyaTABWCTOX?=
 =?us-ascii?Q?544ZGvx0UhRjyOFTSCmrR4U7YmgMxgFR0BzuKd4MBiTVezh3eS+HlmggtR8C?=
 =?us-ascii?Q?4qDs+TZIOiRBm3YCyWWnScDx5PswemWjzExFXBHynFCIkgxTZXn7rw+ItEU8?=
 =?us-ascii?Q?jRufqmxMguZPMplw47TpjtI+EwE3ar0Nzv2YJLjE2al4jATmhWDV68xcEX5a?=
 =?us-ascii?Q?OkhpCASODU7rnbOqwfTnPhYj0I5e3ZJcTpkkpQkODDpGPo7DlJ+jYlJEtvnN?=
 =?us-ascii?Q?KpxAK7jfkTtqvluQPeLeONCIu/D8v8WDDHSfoNt2HEW94Iz6iKaDLADNxypX?=
 =?us-ascii?Q?0R0pY05uhq7KckMI24p2tEE/sBZ/a40N4HnphUoR/tC+VHMRPgdis8FItNJ8?=
 =?us-ascii?Q?/w=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9140647c-951e-45a3-66c1-08db6c195bd4
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 14:20:37.4948
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JFnTDEjnlGqreJBN0JipS/Di2yxtZFrLHDpsZ0rynktEU08DqzkgVCEom8a4bvlmbpKgtZgvXx6F8JyOqrdFuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7076
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

This patch adds support for creating multiple BIGs. According to
spec, each BIG shall have an unique handle, and each BIG should
be associated with a different advertising handle. Otherwise,
the LE Create BIG command will fail, with error code
Command Disallowed (for reusing a BIG handle), or
Unknown Advertising Identifier (for reusing an advertising
handle).

Currently, if the user tries to connect 2 sockets with the
BIG/BIS QoS fields unset, the kernel will assign the same
BIG handle for every BIG, as seen in the btmon log below:

< HCI Command: LE Create Broadcast Isochronous Group (0x08|0x0068) plen 31
        Handle: 0x00
        Advertising Handle: 0x01
        Number of BIS: 1
        SDU Interval: 10000 us (0x002710)
        Maximum SDU size: 40
        Maximum Latency: 10 ms (0x000a)
        RTN: 0x02
        PHY: LE 2M (0x02)
        Packing: Sequential (0x00)
        Framing: Unframed (0x00)
        Encryption: 0x00
        Broadcast Code: 00000000000000000000000000000000

> HCI Event: Command Status (0x0f) plen 4
      LE Create Broadcast Isochronous Group (0x08|0x0068) ncmd 1
        Status: Success (0x00)

> HCI Event: LE Meta Event (0x3e) plen 21
      LE Broadcast Isochronous Group Complete (0x1b)
        Status: Success (0x00)
        Handle: 0x00
        BIG Synchronization Delay: 912 us (0x000390)
        Transport Latency: 912 us (0x000390)
        PHY: LE 2M (0x02)
        NSE: 3
        BN: 1
        PTO: 1
        IRC: 3
        Maximum PDU: 40
        ISO Interval: 10.00 msec (0x0008)
        Connection Handle #0: 10

< HCI Command: LE Create Broadcast Isochronous Group (0x08|0x0068)
        Handle: 0x00
        Advertising Handle: 0x01
        Number of BIS: 1
        SDU Interval: 10000 us (0x002710)
        Maximum SDU size: 40
        Maximum Latency: 10 ms (0x000a)
        RTN: 0x02
        PHY: LE 2M (0x02)
        Packing: Sequential (0x00)
        Framing: Unframed (0x00)
        Encryption: 0x00
        Broadcast Code: 00000000000000000000000000000000

> HCI Event: Command Status (0x0f) plen 4
      LE Create Broadcast Isochronous Group (0x08|0x0068) ncmd 1
        Status: Command Disallowed (0x0c)

Iulia Tanasescu (1):
  Bluetooth: ISO: Support multiple BIGs

 include/net/bluetooth/hci_core.h |  6 ++---
 net/bluetooth/hci_conn.c         | 40 ++++++++++++++------------------
 net/bluetooth/hci_event.c        | 30 ++++++++++++++++++++----
 net/bluetooth/hci_sync.c         |  9 +++++--
 4 files changed, 52 insertions(+), 33 deletions(-)


base-commit: 817efd3cad7481ce2ee25fac5108afecbad56228
-- 
2.34.1