Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230623074657.16618-1-iulia.tanasescu@nxp.com>
In-Reply-To: <20230623074657.16618-1-iulia.tanasescu@nxp.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 26 Jun 2023 13:04:24 -0700
Message-ID: <CABBYNZJxjggNE45_U+adaLLD1FXstt5U91wKJMy=qJoRoZ09LQ@mail.gmail.com>
Subject: Re: [PATCH BlueZ 0/2] shared/bass: Introduce Add Source opcode handler
To:     Iulia Tanasescu <iulia.tanasescu@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org, claudia.rosu@nxp.com,
        mihai-octavian.urzica@nxp.com, silviu.barbulescu@nxp.com,
        vlad.pruteanu@nxp.com, andrei.istodorescu@nxp.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Iulia,

On Fri, Jun 23, 2023 at 12:51=E2=80=AFAM Iulia Tanasescu
<iulia.tanasescu@nxp.com> wrote:
>
> This patch series adds the BASS control point handler
> for the Add Source operation.
>
> If instructed by a Client through the Add Source opcode,
> the BASS Server attempts to synchronize to a Broadcast
> Source, by opening a btio channel.
>
> The BT_IO_OPT_ISO_BC_ADDR btio option has been added,
> to allow binding a socket to a broadcast address.

Im having second thoughts on this, Im not sure if it is a good idea to
introduce BT_IO_OPT_ISO_BC_ADDR, there are already options to set the
address and address type, perhaps we should add what is missing e.g.
num of bis, etc. At least on iso-test the logic I used was that if a
destination is given for listen then it must be a broadcast address.

> The BASS adapter_probe callback has been implemented,
> in order to automatically configure BASS into the adapter
> database. The adapter bdaddr is also stored along with the
> BASS database configuration, and this address will be used
> as the source address when binding the btio channel.
>
> Iulia Tanasescu (2):
>   btio: Add option for binding iso broadcast address
>   shared/bass: Introduce Add Source opcode handler
>
>  Makefile.am           |   2 +-
>  btio/btio.c           |  56 +++++-
>  btio/btio.h           |   3 +-
>  profiles/audio/bass.c |  26 ++-
>  src/shared/bass.c     | 424 ++++++++++++++++++++++++++++++++++++++++--
>  src/shared/bass.h     |  14 +-
>  unit/test-bass.c      |   2 +-
>  7 files changed, 498 insertions(+), 29 deletions(-)
>
>
> base-commit: 37042ca9c6ddcdbbb0899b3d62238935cd53f443
> --
> 2.34.1
>


--=20
Luiz Augusto von Dentz