Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2a43ecd8-faf5-11f7-1a01-c114aa16354b@molgen.mpg.de>
Date:   Wed, 28 Jun 2023 13:34:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v1] Bluetooth: btintel: Add support for GalePeak
Content-Language: en-US
To:     Kiran K <kiran.k@intel.com>
Cc:     linux-bluetooth@vger.kernel.org, ravishankar.srivatsa@intel.com,
        chethan.tumkur.narayan@intel.com
References: <20230628113934.824668-1-kiran.k@intel.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20230628113934.824668-1-kiran.k@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear Kiran,


Thank you for your patch.

Am 28.06.23 um 13:39 schrieb Kiran K:
> Hardware variant for GalePeak core (CNVi) is added.

The code names are officially spelled with a space, I believe: Gale Peak.

Maybe also mention 0x1c.

> Signed-off-by: Kiran K <kiran.k@intel.com>
> ---
>   drivers/bluetooth/btintel.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index dd1e48808ee2..f4d096639080 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -480,6 +480,7 @@ static int btintel_version_info_tlv(struct hci_dev *hdev,
>   	case 0x18:	/* Slr */
>   	case 0x19:	/* Slr-F */
>   	case 0x1b:      /* Mgr */
> +	case 0x1c:	/* GaP */

Why not add the full name in the comment? Maybe: Gale Peak (GaP).

>   		break;
>   	default:
>   		bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)",
> @@ -2648,6 +2649,7 @@ static void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant)
>   	case 0x18:
>   	case 0x19:
>   	case 0x1b:
> +	case 0x1c:
>   		hci_set_msft_opcode(hdev, 0xFC1E);
>   		break;
>   	default:
> @@ -2862,6 +2864,7 @@ static int btintel_setup_combined(struct hci_dev *hdev)
>   	case 0x18:
>   	case 0x19:
>   	case 0x1b:
> +	case 0x1c:
>   		/* Display version information of TLV type */
>   		btintel_version_info_tlv(hdev, &ver_tlv);
>   


Kind regards,

Paul