Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1c40a12b51ccd6ee2ee002276f5b1ba92c377100.1687990098.git.objelf@gmail.com>
 <20b61d77-7397-e3ba-3215-232f49eb8c07@molgen.mpg.de>
In-Reply-To: <20b61d77-7397-e3ba-3215-232f49eb8c07@molgen.mpg.de>
From:   Sean Wang <sean.wang@kernel.org>
Date:   Thu, 29 Jun 2023 14:07:55 -0700
Message-ID: <CAGp9LzqbqAGe0AXN2zH-PViOtu0TcygE265S61QfLxczoHgm3Q@mail.gmail.com>
Subject: Re: [PATCH v3] Bluetooth: btmtk: add printing firmware information
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     Sean Wang <sean.wang@mediatek.com>,
        Chris Lu <chris.lu@mediatek.com>, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        Soul.Huang@mediatek.com, Leon.Yen@mediatek.com,
        Deren.Wu@mediatek.com, km.lin@mediatek.com,
        robin.chiu@mediatek.com, Eddie.Chen@mediatek.com,
        ch.yeh@mediatek.com, jenhao.yang@mediatek.com,
        Stella.Chang@mediatek.com, Tom.Chou@mediatek.com,
        steve.lee@mediatek.com, jsiuda@google.com, frankgor@google.com,
        abhishekpandit@google.com, michaelfsun@google.com,
        mmandlik@google.com, abhishekpandit@chromium.org,
        mcchou@chromium.org, shawnku@google.com,
        linux-bluetooth@vger.kernel.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

HI Paul,

Thanks! I will update the patch with your suggestions.

thanks!
Sean

On Wed, Jun 28, 2023 at 3:44=E2=80=AFPM Paul Menzel <pmenzel@molgen.mpg.de>=
 wrote:
>
> Dear Sean, dear Chris,
>
>
> Thank you for your patch.
>
> Am 29.06.23 um 00:20 schrieb sean.wang@mediatek.com:
> > From: Chris Lu <chris.lu@mediatek.com>
> >
> > Add printing firmware information part when driver loading firmware tha=
t
> > user can get mediatek bluetooth information.
>
> Maybe use the commit message summary/title below:
>
> Bluetooth: btmtk: Log hw/sw version and fw build time
>
> Maybe also paste one log message example to the commit message.
>
> > Co-developed-by: Sean Wang <sean.wang@mediatek.com>
> > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> > Signed-off-by: Chris Lu <chris.lu@mediatek.com>
> > ---
> > v3: resend again with the latest tree
> > ---
> >   drivers/bluetooth/btmtk.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c
> > index 9482401d97fa..8490d59502a5 100644
> > --- a/drivers/bluetooth/btmtk.c
> > +++ b/drivers/bluetooth/btmtk.c
> > @@ -57,6 +57,7 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, c=
onst char *fwname,
> >                             wmt_cmd_sync_func_t wmt_cmd_sync)
> >   {
> >       struct btmtk_hci_wmt_params wmt_params;
> > +     struct btmtk_patch_header *hdr;
> >       struct btmtk_global_desc *globaldesc =3D NULL;
> >       struct btmtk_section_map *sectionmap;
> >       const struct firmware *fw;
> > @@ -75,9 +76,13 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, =
const char *fwname,
> >
> >       fw_ptr =3D fw->data;
> >       fw_bin_ptr =3D fw_ptr;
> > +     hdr =3D (struct btmtk_patch_header *)fw_ptr;
> >       globaldesc =3D (struct btmtk_global_desc *)(fw_ptr + MTK_FW_ROM_P=
ATCH_HEADER_SIZE);
> >       section_num =3D le32_to_cpu(globaldesc->section_num);
> >
> > +     bt_dev_info(hdev, "HW/SW Version: 0x%04x%04x, Build Time: %s",
>
> Why not print 0x%04x/0x%04x, that means with a slash?
>
> > +                 le16_to_cpu(hdr->hwver), le16_to_cpu(hdr->swver), hdr=
->datetime);
> > +
> >       for (i =3D 0; i < section_num; i++) {
> >               first_block =3D 1;
> >               fw_ptr =3D fw_bin_ptr;
>
>
> Kind regards,
>
> Paul