Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230705085131.6643-1-claudia.rosu@nxp.com> <20230705085131.6643-2-claudia.rosu@nxp.com>
In-Reply-To: <20230705085131.6643-2-claudia.rosu@nxp.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 5 Jul 2023 10:38:57 -0700
Message-ID: <CABBYNZ+dh-E=zKARKcF9U6qbAAa-DkS=uOZHi_woicDX_Mu19g@mail.gmail.com>
Subject: Re: [PATCH BlueZ v2 1/1] adapter: Allow broadcaster to be passed up
 to application
To:     Claudia Draghicescu <claudia.rosu@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Claudia,

On Wed, Jul 5, 2023 at 2:02=E2=80=AFAM Claudia Draghicescu <claudia.rosu@nx=
p.com> wrote:
>
> Allow a broadcast advertiser to be passed up to application,
> if the scanner is an ISO Sync Receiver capable device.
> This allows for a broadcast sink to discover broadcast sources.
>
> ---
>  src/adapter.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index 2679d4302..9c971d488 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -7031,6 +7031,16 @@ static bool is_filter_match(GSList *discovery_filt=
er, struct eir_data *eir_data,
>         return got_match;
>  }
>
> +static bool accept_bcast_adv(struct btd_adapter *adapter,
> +                               struct eir_data *eir_data)
> +{
> +       if ((btd_adapter_has_settings(adapter, MGMT_SETTING_ISO_SYNC_RECE=
IVER))
> +               && !(eir_data->flags & (EIR_LIM_DISC | EIR_GEN_DISC)))
> +               return true;
> +
> +       return false;
> +}
> +
>  static void filter_duplicate_data(void *data, void *user_data)
>  {
>         struct discovery_client *client =3D data;
> @@ -7154,12 +7164,18 @@ void btd_adapter_device_found(struct btd_adapter =
*adapter,
>                         return;
>                 }
>
> +               if (accept_bcast_adv(adapter, &eir_data))
> +                       monitoring =3D true;
> +
>                 if (!discoverable && !monitoring && !eir_data.rsi) {
>                         eir_data_free(&eir_data);
>                         return;
>                 }

Lets match by advertising UUID since it should contain a broadcast
audio announcement to be considered a broadcaster.

>                 dev =3D adapter_create_device(adapter, bdaddr, bdaddr_typ=
e);
> +
> +               if (accept_bcast_adv(adapter, &eir_data))
> +                       btd_device_set_temporary(dev, false);

I wouldn't persist broadcasters like that, at least not until we
synchronize with it, that said, if it is using a random address it
probably cannot be stored anyway.

>         }
>
>         if (!dev) {
> --
> 2.34.1
>


--=20
Luiz Augusto von Dentz