Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <859a1c176765dbb9ea394dde387b8ed072365ca8.1689180344.git.pav@iki.fi>
In-Reply-To: <859a1c176765dbb9ea394dde387b8ed072365ca8.1689180344.git.pav@iki.fi>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 12 Jul 2023 10:57:40 -0700
Message-ID: <CABBYNZJu-RmP75pi32jeDPusKOx8L14jkWn0mubG48d_3B-A8g@mail.gmail.com>
Subject: Re: [PATCH BlueZ 1/2] test-runner: set non-quiet printk before
 running tests
To:     Pauli Virtanen <pav@iki.fi>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Pauli,

On Wed, Jul 12, 2023 at 10:00=E2=80=AFAM Pauli Virtanen <pav@iki.fi> wrote:
>
> It is useful to see WARN_ON/bt_dev_err messages when running the tests.
> Enable non-quiet printk levels after boot, so that it is on by default
> and doesn't need to be handled in local test scripts.
> ---
>
> Notes:
>     It could be useful to also check for BUG/WARNING in the bluez test bo=
t.
>
>  tools/test-runner.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/tools/test-runner.c b/tools/test-runner.c
> index d74bb1087..288901a61 100644
> --- a/tools/test-runner.c
> +++ b/tools/test-runner.c
> @@ -136,6 +136,20 @@ static const char *config_table[] =3D {
>         NULL
>  };
>
> +static void enable_printk(void)
> +{
> +       FILE *f;
> +
> +       /* Set non-quiet printk level */
> +       f =3D fopen("/proc/sys/kernel/printk", "w");
> +       if (!f) {
> +               perror("Failed to set printk");
> +               return;
> +       }
> +       fprintf(f, "7 4 1 7");

Can you have a comment on what this 7 4 1 7 is for?

> +       fclose(f);
> +}
> +
>  static void prepare_sandbox(void)
>  {
>         int i;
> @@ -181,6 +195,8 @@ static void prepare_sandbox(void)
>                                 "mode=3D0755") < 0)
>                         perror("Failed to create filesystem");
>         }
> +
> +       enable_printk();
>  }
>
>  static char *const qemu_argv[] =3D {
> --
> 2.41.0
>


--=20
Luiz Augusto von Dentz