Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp1586740rwp; Thu, 13 Jul 2023 13:14:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlHy6NC84RgHALZv4LmsD7NLFnN62bgdzSVvQnCfpMQWS6dZlKJHVxGiVZVy8FQhB0IXSoGd X-Received: by 2002:a50:fc1a:0:b0:51b:fbf3:d9a7 with SMTP id i26-20020a50fc1a000000b0051bfbf3d9a7mr2484385edr.39.1689279246654; Thu, 13 Jul 2023 13:14:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689279246; cv=none; d=google.com; s=arc-20160816; b=XrXJ28WPvAxQdZsUmc+woJeMbBG6jpL0OcZrmqqtgaT/BF+WhUjxE7qXBzkuRvunDY /BHshYLyNugb0hVHBtVjoDoa7MhusBr5Mg8y1b1fbaI7UZK/F5cmrp4tTkMJ8SEM8kDS 9HsJAIjb2R5ynBOTgWxw5HEi6E+kZdT9oQOjKskSHZnXQzK0Ftnvlsj8xUOoXxshyTfT 3A6iUHUf0tTVdQ1iQ0cjDXd7rJkBZtgDWBdkupMKZ/XwO2lMIfbQGKcx6BYoz1OykAOT EbzQr/mWfcF0EeAknvXvr8dD3r7+owTKiXZmO3JowHbCRR567g7jG/dJmJvQ9VHmHOTO Ihsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=oCyb2Ez9Ej52gSPm+qDeXpEj/1xG/qfov1BK+0E0bXo=; fh=Adgm4D9uauTY1JFHIYAwrrqX0iWsUpGyuuKyQ32YpB4=; b=Q7THY20d08hxYUS4v6sqCCg6v2g5pI6B5986AaSr1mUj31YhUcdDTl4f+WeyiAVYES QR3TtdhQSm5BdZEjPf6mnKzrWArIYjzH+zsit1Fn/F7+E4sIn2k/fXYwPgAxasHFtmXG tsScVKqu/W8OXT+Mt/H+JulP4QCWLMf/zJH2qWe8RQuAOskxbf/2rlbC1Z4sIeT6jfeK R7kBs/HDUk3uWAy14waP3WJkYe49iXdvNZvTMzefqpX5/QYEskHqpY8LoN3YzUrYDA/K rWyeDtFZqfIr+3cC0NgQuNKjHFE+lVIYfPZVAsXewKAHWOhmWHvYDCxSLvzrt4SOK5mn ehsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FA7gAP1H; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s12-20020aa7c54c000000b0051de4b6be0esi7205935edr.646.2023.07.13.13.13.42; Thu, 13 Jul 2023 13:14:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FA7gAP1H; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231234AbjGMUKZ (ORCPT + 99 others); Thu, 13 Jul 2023 16:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232912AbjGMUKX (ORCPT ); Thu, 13 Jul 2023 16:10:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 105AF1720 for ; Thu, 13 Jul 2023 13:10:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9FCBE61B5D for ; Thu, 13 Jul 2023 20:10:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 07429C433CA; Thu, 13 Jul 2023 20:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689279022; bh=UMMK3MqMGEcnei/pI+LgVUcWKP7hNJGEf6mAZVt55sw=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=FA7gAP1HZV61HnaHSqDDd97bBaXKAAWBS92e5xywPziSOlzOE7HBvcSGfupiZlrXR 4ultiQPct38F63l19e8R0V7Y3H14uuX9q753hz4OZGycpyI8XIPz6H+3pLs5BThtEc 8Jsj8AhrgQA7vVaQR/lxbL2ahsIc7RKnpH10mmHVfFgNeE1YQW9lXWrwNE7CM3PkbR ys/kliUQijC8G9RuhBeLcd7PoeVORrMxMthz1vGz1x1FRbmlHnsUyABLa91tOtIrSO TITFh/FnaQGsXqP6WJxlMjJy2+yQ/+AfqTLg1RtMTF7ufejPuSJmbaS8ReBi2y26Zn BPZmJx0jrbQdw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id DDB29E4508F; Thu, 13 Jul 2023 20:10:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [RFC PATCH] Bluetooth: btusb: Fix bluetooth on Intel Macbook 2014 From: patchwork-bot+bluetooth@kernel.org Message-Id: <168927902189.26469.5406966566822603728.git-patchwork-notify@kernel.org> Date: Thu, 13 Jul 2023 20:10:21 +0000 References: <20230713102514.699277-1-tomasz.mon@nordicsemi.no> In-Reply-To: <20230713102514.699277-1-tomasz.mon@nordicsemi.no> To: =?utf-8?q?Tomasz_Mo=C5=84_=3Ctomasz=2Emon=40nordicsemi=2Eno=3E?=@ci.codeaurora.org Cc: linux-bluetooth@vger.kernel.org, luiz.dentz@gmail.com, johan.hedberg@gmail.com, marcel@holtmann.org, johnbholland@icloud.com, carles.cufi@nordicsemi.no, pmenzel@molgen.mpg.de X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz : On Thu, 13 Jul 2023 12:25:14 +0200 you wrote: > Commit c13380a55522 ("Bluetooth: btusb: Do not require hardcoded > interface numbers") inadvertedly broke bluetooth on Intel Macbook 2014. > The intention was to keep behavior intact when BTUSB_IFNUM_2 is set and > otherwise allow any interface numbers. The problem is that the new logic > condition omits the case where bInterfaceNumber is 0. > > Fix BTUSB_IFNUM_2 handling by allowing both interface number 0 and 2 > when the flag is set. > > [...] Here is the summary with links: - [RFC] Bluetooth: btusb: Fix bluetooth on Intel Macbook 2014 https://git.kernel.org/bluetooth/bluetooth-next/c/f0408f0a1998 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html