Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Jul 2023 13:51:50 +0800
From:   joeyli <jlee@suse.com>
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     Chun-Yi Lee <joeyli.kernel@gmail.com>,
        linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] Bluetooth: hci_event: Ignore NULL link key in
 hci_link_key_notify_evt()
Message-ID: <20230717055150.GO5866@linux-l9pv.suse>
References: <20230714161210.20969-1-jlee@suse.com>
 <8eeb958e-d947-2f6d-5942-d30746cf1268@web.de>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8eeb958e-d947-2f6d-5942-d30746cf1268@web.de>
User-Agent: Mutt/1.11.4 (2019-03-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjgxQjhrZ2xIVkI3WVRHMWh2SkRQN2xKZkswNTRhTVlwelUzdWVoblJiVW01?=
 =?utf-8?B?aDRYK3B3MFJRNTZFR0xvUTdNMnBrcjNKZW56dEswOFZmMnJoeHBKUUxBL3lB?=
 =?utf-8?B?K0p4d3BCcllIeE1qYmZMYTQ4bzg0MG0rSTZlSHBGYUdkdjE1R1pDOGVZakll?=
 =?utf-8?B?em5ON3JwbzVnQ2M3eDh4dXpmZ2ZhdUdGR0tKRy81UEJIS0FZKzBYRmFwRlVm?=
 =?utf-8?B?bzBWN0dVckczWFYwWjV1am43OFdRMnJFZDMxU1h2WHBocEtwM2VwOTNxQXJ1?=
 =?utf-8?B?a2lzdFd1cWhPMEtaMktkdWZuZk5ONHhKYWNkaDFRd1NpVUdmekNKV01BUmlk?=
 =?utf-8?B?VUtYc2dyb1JWa0UxdU9UTlM3K1VKM0dLTE03ak9wTUZVSzAvb2Jwd0xHWmpt?=
 =?utf-8?B?SnVIK0tUQkwxN0ozbUhuV3hNV3lKWG9Va2hiOENscFdMNFRDMnJUYkE4aWpU?=
 =?utf-8?B?VnMyRFZ4RnhOY3NiZkYyNmtjYjRQc0xIK0VOV1c5Y0tDcjh1ek9PR1grS1hl?=
 =?utf-8?B?SU9GK0JQNzRjcG5LdE1pZVpwdE9rV1M4Z3NTUktQektTdVUzL1RYMlVUb09z?=
 =?utf-8?B?ZUZQay9DcVpGV2NEeW1EaGxUWDg4cnZaNzF2MGkvelF0bkdacnF5UlFXeGFQ?=
 =?utf-8?B?SFVua3EyUlkxUUdvVDhYNU5QcjZEOFQyWlNUeFJ0b2Rqa1AwN1lld3NOVGJF?=
 =?utf-8?B?NzNZNTcxU2JsOFRqUDJLUXpBVnVTR1ZUUzhRMll4MjNPemVrR2FCZzJRRHpN?=
 =?utf-8?B?TngyOHRNR09KcXI1R0FOYTlwZ1pXZjBzOTkxYUFqUGI1VTJRN1RpNFA1VnJR?=
 =?utf-8?B?bzJoV21MNHB6UlF3T3F1WEJuL3Y2RjBUdnhSaFFseTNRdXZsdjdVSFg4VC9j?=
 =?utf-8?B?KyswQVlPTVRGUi9pNGtuTVY1dW1la3RIWlQ5RnVVdCtPdFd4TFVqaTI0NHoy?=
 =?utf-8?B?TGNGbWZjQUUyOEdRRUludEllL2dySTRGdEF6eHhlNURsa1psVTdnUEc0djVX?=
 =?utf-8?B?b0FEekZZcVZ1a29QOEJ3OE9BbkZQeGxqQnFyZTFxWFZkMUVKUVErMXprTS90?=
 =?utf-8?B?b0lIZzRCRW8vTVhkNjFmMHB3NDduc3JQMTJCWVpsdVl0L2dWcnFBdDRkUURa?=
 =?utf-8?B?Rk5MRENXR25IQ0ZFMVI2aExjYjE3cEVsakRKK01FdU5XNnA1MjhvSnU1YnJu?=
 =?utf-8?B?bVZGTmt0NTlUdW1JdWJxOVBEdjgwMFNBejdFM253TDlYRDNEd05aT2laK3do?=
 =?utf-8?B?SDJEajUxWXlkaU5kVWhFcUEwQ3R2bDNRQTRKRFBZVkpoak1lRG5kdkd1UjN0?=
 =?utf-8?B?UWpIdGtoaEVLS2pwMkExRzNzS2hmenp0QXVMeXdvVFBhTWdVdTNOL2Vrc0g0?=
 =?utf-8?B?VDNpQW5HZ2s5WFFMUUpFZUpmdHkvS2d1dGFXV0t6enVrckNjVE1rOXV2TGdy?=
 =?utf-8?B?L3BZMC9HTENSK3B0ZDVEa2pZcC9CRDY2QzhaWEk3WnArRXo1azR6eDdVT2du?=
 =?utf-8?B?VTd5bWtGclY0SGwraGVPelJEYncwc0JmN1lhQmVpa3JobU9tNVZ2UVhvNTFr?=
 =?utf-8?B?SXNmVUpMTk5VMXBzRFhnUGhIZGxsR240Y29Fa3docDFXcGpCWHVuZVBpN3dj?=
 =?utf-8?B?elE5R2lNQ0kyM2FVSXN3YmdRUHRkdUR3T2dlYkNwbnViSGNPWDhlbTVkTFMw?=
 =?utf-8?B?YXU2a1NCT3J4MGE5Z1ZZanRtSzk1dFlEdDRNOG5xeWtxRlpnQ1VyajZFQzhL?=
 =?utf-8?B?NTNDaEtNNE9XTWs1K0UzYmJtVVNpWGwwU3NTSk9uZlpJTDlLQ2Z3aVM0SndM?=
 =?utf-8?B?c3hvT29TRmI3TTNuMnV5QjZZa3NYZlBqNkx1UWNZaVEvU0Jxdzk3djU0N2d0?=
 =?utf-8?B?TkJQeFpjdFA4YmZCRURjd0p3aW45QU4yQUwrRXlRdTlkYUFmL0RnVjhRVWxP?=
 =?utf-8?B?SHVGYlEwVTVtQ083aVZVRW5kN0JGR0h5ZWFzUWRBWktTNzhGSS95dnBoUzFU?=
 =?utf-8?B?WVB3cEtpbUFoWWVMTGYveUdSOFhPZjY4TnhOYkRKbC9COEJIeGVrenZEamVq?=
 =?utf-8?B?OTAxekRVczVtR3ZpVTBNRWtBZDQ2dWVhWnBkQjd4VXJSMlFLV0JLcSs2bTc3?=
 =?utf-8?Q?RA7E=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12b740c5-17f6-4692-dd36-08db8689f0ff
X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB7164.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 05:52:01.6703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WSuLLCVwMC3GyzRtiLrKFVnZAGKPRkPWClf04N+7n5UZ4iU7FciMEzA/8fEYMYw/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9595
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Markus,

Thanks for your review!

On Fri, Jul 14, 2023 at 10:30:17PM +0200, Markus Elfring wrote:
> …
> > We can ignore null link key in the handler of "Link Key Notification
> > event" to relieve the attack. …
> 
> Are imperative change descriptions still preferred?
> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94
> 
> 
> How do you think about to add the tag “Fixes” because of
> an added case distinction?
>

Sorry for I didn't capture your point. The "Link Key Notification event" 
is a term in bluetooth-core spec. What should I change in my patch
description?

Thanks a lot!
Joey Le