Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Jul 2023 18:23:10 +0800
From:   joeyli <jlee@suse.com>
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Chun-Yi Lee <joeyli.kernel@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Marcel Holtmann <marcel@holtmann.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: hci_event: Ignore NULL link key in
 hci_link_key_notify_evt()
Message-ID: <20230717102310.GS5866@linux-l9pv.suse>
References: <20230714161210.20969-1-jlee@suse.com>
 <8eeb958e-d947-2f6d-5942-d30746cf1268@web.de>
 <20230717055150.GO5866@linux-l9pv.suse>
 <7cae670e-b7c5-470b-536b-ab03513cd0a3@web.de>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7cae670e-b7c5-470b-536b-ab03513cd0a3@web.de>
User-Agent: Mutt/1.11.4 (2019-03-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3dNbkRkdk4vV1FLQUJxa2xWbXJVVjYyK1BlSFR2TFRCcERBSERtSzVvVVpV?=
 =?utf-8?B?WWlWdWUxN3dzWFRzczFvVDBpZW8rRFZqL0pNSStXdGRqeHZ4VTdkdnJRdlY1?=
 =?utf-8?B?SjlsQS9VQytpcVlpTW81SnhUTDgweW1DN1RVWjlhNGlQSjNtU2JRSjUxVkJ4?=
 =?utf-8?B?WXlKelBVNGY1d3NKMm9CR3pVR1lMU3QybVRHZVp5UmdJQzRFT243OURDVXZE?=
 =?utf-8?B?WVhkak15NUdwZXFNczVXdlM1cmVrNyt4MFFJamtyZzJEeCs3QTR3VENJZHpx?=
 =?utf-8?B?M2pjYlI3dkJ2b21CSW9PdDNqNlRhL1VqTUNsZml6bTFTUVdmdjEwdFF3QllB?=
 =?utf-8?B?TkVkOXBZam9kMzRXOUpTb3BDTmdSc0EyQktINWZUc21nVG5zWlNKUmdYVzQ0?=
 =?utf-8?B?Wmk5Vk9xZm9xTE9KaW1KVVNuWURGRTFwb2RoQ1JzbTZiMzh1SFhuN01PbUZW?=
 =?utf-8?B?VjVta3pGM01maitkVDc5eWZtLzVQWWtKNXFhSXBIUUE2L2s5allYMHYvaHhH?=
 =?utf-8?B?bk1qODdjdnl0UHh0cWlSRWRTWjdYQktQTDBFczhUaGs2TnZiREVTUUNQWjRQ?=
 =?utf-8?B?NTMwcjZUV2RRaVJraDErWmZqTnpDbnhuSkwrbUwvQ3ErRWE2TE5MVjJuOWFZ?=
 =?utf-8?B?RGxsV0swUTdCRStkL0JVYVJscVBiaG1YRktTOVNhekpMUTZ4UzFqU1RhMHJn?=
 =?utf-8?B?ZGxjWVJMV1gyMlB0cTg2MUIwRDFaOElITXA0bjRRTWozejI3ekxEOGpxS2hO?=
 =?utf-8?B?NTd2K1hIc2o5b2FtNGgwSnNJbXJCTzdsV3BKSHJPRFdCdEFVM2YvcTVRcmVH?=
 =?utf-8?B?ZWMyVEQvQWNRQTA5bSs1YTR6S2laRFpXT2RrbE9YQ2FxZUNtTDFJYS9XNXhB?=
 =?utf-8?B?NlcyajA4V1RsSnJoYUNlVHlIUXhJd2FDNHBXUUZGeitISlNXT2JZYjZ0R1lX?=
 =?utf-8?B?YVVaL3MrQVduTXZ0dFE4Q0dTNmpvWGE3MUtETFB3cUFZQWJUVmtDV3BrU3h2?=
 =?utf-8?B?MGpQMnhtS2Z2Y3BwZVkwTW9oSjBnb05sNm8rR1VQZUlETUFFMytVU05tTGdu?=
 =?utf-8?B?QkttS1RQMHdEbEt6RTNvNERQMGpFMklkaTJmZWkrb1JMc3VOekFyc1hpbktt?=
 =?utf-8?B?ZTFmMllXR21WaERmUGk0Vk8wVjdPVGd6NXc1am13Q3hOcVBrcVZWb3hGN2tS?=
 =?utf-8?B?RGtQa0dURlBWSGZNVXc0bjJkQm80eDRWNjVqRDRKU1MvcHF0REhDYmhQSzFD?=
 =?utf-8?B?RHpybG5vbXFJR251dFBqYzJTeVRUOW8vaDBFdnpIK3UzcFo0REFiWEVpUndX?=
 =?utf-8?B?di9TU3JNZmpFc0JiM0tiRVBJQktZNjRENDlZS1h1RUNBWWNTeHFPQk9wTGhM?=
 =?utf-8?B?b2FWektBcVkrOVZGV0VBcURwb2FLclJSNXpWN2RYc2FKajdycVVYKy8zWEJu?=
 =?utf-8?B?WmVsYWJuUlZMTGFzSUs2N0tLVXRFL0xYL3M4TWwvSE55U1FwU2hCQWd4eFdS?=
 =?utf-8?B?cFRPalZXR3RRMW9nNGpCQmhWOHRJSUJwNHNIM0J5d05QanJnbHRNLzYyNlN4?=
 =?utf-8?B?MzVRaWlPM0sxYXdGZmdGLy9WaTd0cXh4VHhmVVovUUJDQnpjQ0pTYk1zMXI4?=
 =?utf-8?B?dkxRM1UvMWZWd2x0ZEdZdUFDTjFlSW1hL1lNb21ZWVlxSmUwYno3bE5udHZy?=
 =?utf-8?B?ZUJOb2hSZ3Q4QkZtcHF1RjVlTDllL1ZYLzNFVFVDVWltcnZoMWhkNGNkazVu?=
 =?utf-8?B?L3FlZ3NiMmxpbURBbTVoK2NMTU9tT3M4TWx2ajFXTDlBSXdIRURPWmdrYlhE?=
 =?utf-8?B?elJRdS84U2kyaGFIRUlmUUZSa3RKMlFGdlRPS0ZLd2d5d2RubUpTSlVSQmVx?=
 =?utf-8?B?bWljU2oxU21yTXp6N2ZSUEVaNVlsTGdaU2dwZkRBaDNXNzhFUXpYM2dBcDVy?=
 =?utf-8?B?dS9TcFVBaVB6c2pVUld1a0wyWUdZU2phZm1CSS9BR0djL3dnbWRYRHJUR3li?=
 =?utf-8?B?YmtHVURac1hVbGIreGJSVWFldFFxdUk4NlkvenpKZmZmTFlhWTRFc1c1Q0ds?=
 =?utf-8?B?akF4a3h3Vm1xanF0TVJjRFUzdGswbnBTYjNGRmtwdktiWGpVT1k0ZmdPWklB?=
 =?utf-8?Q?h4LM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdfeac40-9680-40f3-e914-08db86afd611
X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB7164.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 10:23:17.3518
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JfCoWh33hbXm7sG54SisWpsJ/ghDOe6LVmGNI2eN6+Gj9Wo2pTnujNL//CAqiLDF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8414
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Markus,

On Mon, Jul 17, 2023 at 08:15:56AM +0200, Markus Elfring wrote:
> >> …
> >>> We can ignore null link key in the handler of "Link Key Notification
> >>> event" to relieve the attack. …
> …
> > Sorry for I didn't capture your point.
> 
> Did you provide sufficient justification for a possible addition of the tag “Fixes”?
>

This patch is against a CVE. The issue is not introduced by any old kernel
patch. So I think it doesn't need Fixes: tag.
 
> 
> > What should I change in my patch description?
> 
> I hope that corresponding imperative wordings can become more helpful
> also according to another Linux development requirement.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94
>

Thanks a lot!
Joey LEe