Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Jul 2023 23:40:07 +0800
From:   joeyli <jlee@suse.com>
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     Chun-Yi Lee <joeyli.kernel@gmail.com>,
        Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Dan Carpenter <dan.carpenter@linaro.org>,
        "David S . Miller" <davem@davemloft.net>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Subject: Re: [PATCH v2] Bluetooth: hci_event: Ignore NULL link key
Message-ID: <20230719154007.GI14791@linux-l9pv.suse>
References: <20230718034337.23502-1-jlee@suse.com>
 <79669635-9a07-7fa2-e73e-bf31f554816d@web.de>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <79669635-9a07-7fa2-e73e-bf31f554816d@web.de>
User-Agent: Mutt/1.11.4 (2019-03-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVJVSHEzZU5Ob2JmUUl6TVMrWjZvR1pZNGpzTGRKQmZTQkltLzhvZGNYVnRa?=
 =?utf-8?B?Z2ZSd3NQYWVPdk5XNTZFRmh4L3RTcUVJbUxuZHZyV0VDWjQvK2NWODdFZWoy?=
 =?utf-8?B?ZjBUMCtYZm92UFFlejJnN0xKNFdiWXJGSGNYTWRLcDRxeUsrSTBDOHo4aDlO?=
 =?utf-8?B?UHFBclpTMnlUN0lUSEltOGZkdEFVTXJwOWxJcHE0cWoyRjVnOEFnL1hQRjVn?=
 =?utf-8?B?Sm92aDB5WENxUWNscVFGQW1lYVJRejQ0amh4UFJ3anM5aFJudHd3N2FFT1Nh?=
 =?utf-8?B?QkhSOW4zeDh3eUZTZHEyRWp3czhFcXMxdlcwaVRsRG55ZTJIM3E3VTRwZktr?=
 =?utf-8?B?QTkrQm1taGdZS1AwTHpPb3kwVW5uUG96QVhQTlBuY2R6L0NpSFV4bjBFRmhH?=
 =?utf-8?B?aFlyYzZ4azd3NDZRNG5CN0NJSWxIUk1mQkVVZXg2d1lrY0ppUGVWc1lTN0R0?=
 =?utf-8?B?THBsNk0ySTZJejBoeHJHK0FLUHRXeVk0V0xRNlVkcTMzbTMraVJkMzNoQ20v?=
 =?utf-8?B?WXhEK2lwOUVobDhiTmZnYlV6ZEZmWFFGQlZPZlZOL3p5UWNUVU5TRVE4Nmxk?=
 =?utf-8?B?TSt4RWVLVkhrY3JUSkRsL3V1a21hMnhDb0tKL3d2aEFoNUpSR2JQOFNYRVhn?=
 =?utf-8?B?bUxmQ3ZuR1c2RFdhbG9BZjNOaHF0amFFM2MzV0dRTTFjRFdNRTJOWmI0dkUy?=
 =?utf-8?B?THovdnBnTVk5SCs3UmxaQjR3azdqT2o1Wi9mWktaWDJyRDgzekZDV2hrWWtu?=
 =?utf-8?B?dlNzWnB5S3BHUGZCczNlS09jTnk5UnBzTVE1WnhrMGRMWENLM3lzblpCVFMy?=
 =?utf-8?B?dnd1NC9OejFTTmZwblowZ1J6SEE2SDllZG5uL1hLYUlnckZHdTRhRVdmNmVH?=
 =?utf-8?B?b0tvbXkwMDY0dWJZN0RtdzBwRG1nMVZ0NHV5MlptL1oyVWNiOERadWxJSXFi?=
 =?utf-8?B?c0VPU2RaOGVyU0JWNjlsMlFRelFONnlLTFROZnNob0JGWnVQUkkvM2JoRmdt?=
 =?utf-8?B?N2l1aDE5d01HNW14cktRcjF6TTNVQUY1anFtTmJuc1VFNG05d2FDbC9VUmtF?=
 =?utf-8?B?UEsxVk9DWkx2WGQ0aDR0OFR1dDhDTEJ1TnBqMzBBMG5JK3FiRzMxN05MRVBw?=
 =?utf-8?B?WFplZWo3S2JXb09YWUQrc1MyRG5HNFV6MjVrdHJUY3I0U1dlcE04VVBjdWdk?=
 =?utf-8?B?UEd6MzhzQmpTaUZPaEZicWtLQzBncDNnZFdLNDFxMlZBNHgvWGpDWkhxYUVZ?=
 =?utf-8?B?SThoNVlvZ29ZVHlEYWQ5djRkektsOWpkSVNxYkFRM3o0TjVUYVBrTWZkQjNR?=
 =?utf-8?B?QThFV3A1Ulp2R2p1NjEyV1czbEJIR1NYSjRydHYwRVdKNWNONnBOUGNTdG8z?=
 =?utf-8?B?QVpFTzdHZzFsY0sxL2N2b0R3MkdneVpDdGUzUEFlWnExU3FVeVBNaUc2YUpU?=
 =?utf-8?B?Zlc0d3hCUHIxRUFSZ3ViYjZBZzVaZmUxNXN2Q3Y4amVPbFpWdTBxaENJVjE2?=
 =?utf-8?B?ZUpiQVpIZ1dDbXoxSzdjTVZBaVMrWmRtcGZFWEVuZU9KeTRKZ014Z1haU2Jh?=
 =?utf-8?B?MWFoWXd4dFpOdUNhYmRzQU8vaG1lVCtOWFAwdlNHWUNPcEh3aXJnRDFBVnRp?=
 =?utf-8?B?REYwOEl2blR3TWxod1Z2VTVTR29GTzdkNUg0TjhyOFd5aFJaZWhjVlp3L0U5?=
 =?utf-8?B?cFdBSU9SUVNVRlZScEExekN6aDdoUE9IY0QrRStOTnp0b2lSeFVWdCtEUUtG?=
 =?utf-8?B?Q0RVcUlaOURKVkY5QS9EWHRFWWV0RnR6eGdSelVNeTFxUEdFeSs2STZRZkcy?=
 =?utf-8?B?NFQrYVpzMzNCaTFoUmN4d3BCbGNLTDhmWXFycnpTbUVoWDRhbGwrS2ljckFO?=
 =?utf-8?B?cm1wNUxGNXNWYmNWWU1JbFRSS0UzVHhOOTR2L1hCQjJIanlKWjBMN29PRWRL?=
 =?utf-8?B?REQ1TlVYOW51OC8xSy9PaGl1VGtPYXpCWC8ra2VwQXlyQnF1THdPQTRoRUln?=
 =?utf-8?B?dEsyKzlNMGhHbEdES0tjRSt1Vyt4eklMRHVZNmxXVy9TMndMM2ViTEgwajBt?=
 =?utf-8?B?a1RvZnM5SkJJMUlhQUVOR0VrMkM4UzJ6bjlUY25aWlQ2RHQ3TmFsNEVSbVdh?=
 =?utf-8?Q?2z1Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab96f12c-e7dc-452a-adbd-08db886e754b
X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB7164.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 15:40:19.9637
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Is5tzaRo1lUn6Xb4Ne3tfDT8PP5m3CDL2dwdGLf3Sqz58KaKFlamf7POMng0KGCP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9297
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Markus,

On Tue, Jul 18, 2023 at 07:50:13AM +0200, Markus Elfring wrote:
> >                         … Base on the paper, attacker can induce the
> > attacked target to generate …
> 
> Would you like to avoid also any wording weaknesses here?
> 
> 
> > We can ignore null link key in the handler of "Link Key Notification
> > event" to relieve the attack. …
> 
> Will corresponding imperative change descriptions become more helpful?
> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc2#n94
>

If possible, could you please direct change my original patch description
for your suggestion? Then I will put it in next version.

Thanks a lot!
Joey Lee