Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nitin Jadhav <nitin.jadhav@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     devyani.godbole@nxp.com, pav@iki.fi, luiz.dentz@gmail.com,
        sathish.narasimman@intel.com, nitin.jadhav@nxp.com
Subject: [PATCH BlueZ v3 1/3] shared/vcp: Fixed the crash observed with VOCS
Date:   Tue, 25 Jul 2023 14:21:24 +0300
Message-Id: <20230725112126.49656-2-nitin.jadhav@nxp.com>
In-Reply-To: <20230725112126.49656-1-nitin.jadhav@nxp.com>
References: <20230725112126.49656-1-nitin.jadhav@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?adUk+pYKkW39KOWL8ldgNGW3HuM4d/YoFSxARjRuhiF224Mk3J7bQ1zsHRAF?=
 =?us-ascii?Q?tEoBxCcVhnCdbCJG/6p16BXR7/eVoIqUwOdZwSoK1EhVcA13KPmtPPJIFsuF?=
 =?us-ascii?Q?lHKr3sN1U6k1kPDUmrLmuMQFF7CcMtpOx0GdOeFhKFqoz2yMM+GTCORJbbJx?=
 =?us-ascii?Q?TV7pyWbawdawd7gWlJIWdNUDV74k1/8KvS4lJ23O9EBGpettIGfS28NeCvqP?=
 =?us-ascii?Q?4WhfEn20wzt4XqfAZALvMU4HbwnuTXX9TPvgOu5gu/WgLRiWqlzrar/6RBZj?=
 =?us-ascii?Q?lzFY9qWy/zN65yDYL9bdw5dk+ddr9UOnfI03QFCNZNy5VKr0qFU+1i/M/dt4?=
 =?us-ascii?Q?HnpAvD1cQ3bSTmm2ngEYnmm4Zkybo8DgpSPR5FQd6pCHyAOHmCKb0Z1xQgtH?=
 =?us-ascii?Q?cyk2wVmXZREBlDp+MZzQkGSd8i490f3mj7bcNUUMVMU9sPQhTmsKyQC2bvox?=
 =?us-ascii?Q?UHPUKlCaWWyAAprAMEgSiA/5Ss5juyESjs1YBAhzO9UuGqyyZ80/8jw7aMni?=
 =?us-ascii?Q?3N3lS1JeHNI8w+QajumGfHy0Ci9Z2TB+c5uLZU6eqOJM1Yxjr48ItriOd/Wj?=
 =?us-ascii?Q?IynekkFouoV4NRaXwJgwRUvAnvt4P66DGsi3Sow/plDWcCu8qFKO7xuwLO/H?=
 =?us-ascii?Q?I1F0cDysRpalGh4W3/3S6akhES3yJ0A6gDkgXgI/984kRUEKEmzYyK3buq5X?=
 =?us-ascii?Q?mh7zVlT50QvCXgpYeqNrRfHRu7JF3EPuxMIW/19yQf81hGFr8JVPBUW6fh/a?=
 =?us-ascii?Q?cUJ4KiUNpH3L2NGHqbIOisRqZwYq7cEUhZ+ZhB9B7CR5YuZA8Nbl34+eSbkl?=
 =?us-ascii?Q?ln5TCQmW4G5zch9nO5+Pb5OoOk6zEKVmAi6lTp4EHyKUh6/42ZwdeXrVV/96?=
 =?us-ascii?Q?tHXtHBOF0YdQoszxJnEdRKH60KELDdYRmo/oYC5HWU8uJeUA6tz0atlpU834?=
 =?us-ascii?Q?kisf7SJbwIRPVhRrYqgQnjHljFIgdPukrwcJMVL+0/ssXAK3FeAcCK+pSznD?=
 =?us-ascii?Q?hRAtgm5yDtFC3vARA2UPQvTH3DZYWzZyLM+JgszkspIua5bnDqb+rO9vDbb0?=
 =?us-ascii?Q?/LX7InhH8h1XEEQ28lYctBA/7BbjsdJ+UrbZeeAZpv7xUVsntRhkrCqEW7FR?=
 =?us-ascii?Q?dFTBco+naBTzUirBiOOXYnwxFeGN1tRTXDV9akeMSkP5nO5OFKJvS4DtQCc5?=
 =?us-ascii?Q?z8Afm9dfLgV6wxe6AyTNHQpI2R8GZj881p9Z7b9GKO5nVW/9kHBlAwqah2zn?=
 =?us-ascii?Q?wXb62rRKCOVnNBc9Kt0tqbpoSqip5siJo4u/x2HYFk3yhoRLHndseGcOj2xI?=
 =?us-ascii?Q?R1ZiPLQ24BY29UPkSkOktDPt1UzbDXyArWrHM4q0LqiuoQ2V7Vrq7YRcutFF?=
 =?us-ascii?Q?O6JQoYyj6VDqzdr3nSt/3cDua11VsljmsbZKOe/+kXhxoD4xw8MKpSRJYhSL?=
 =?us-ascii?Q?lD9trE5meJ0WGiZqxAXW+7x4cC7jt9gm1sIBzjBmd7NYjoNzYo+Khf8oBU5N?=
 =?us-ascii?Q?IQXFPT+Y+St+iYCBq4+wLMtdimkyKB7ScQ675Q0HzeX++es4J8sFjv9WYzdC?=
 =?us-ascii?Q?BG6NaAW9D4HLS9bsdi+MCZ7oBwxSFZSM0TPOTm5j?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab54e28d-1f82-4d6d-4328-08db8d016287
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9126.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 11:22:09.3701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LrmhGZ0GrbYf5C4nVDCQ6J8xnNa4vTMLCXN33CcM8ivaTEKUuRBFqDwseg40FRIy7WaHfpYvNhFO+CVX4tkjJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7580
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Root cause
- There are two types of database- Remote and Local (rdb and ldb).
- In client mode currently the code was written to access ldb.

Fix
- Correcting it, to access rdb has resolved the problem in VOCS.
- Same correction is done for VCS.

Reported-by: Pauli Virtanen <pav@iki.fi>
---
 src/shared/vcp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/shared/vcp.c b/src/shared/vcp.c
index 74bd01729..314618664 100644
--- a/src/shared/vcp.c
+++ b/src/shared/vcp.c
@@ -1719,10 +1719,10 @@ bool bt_vcp_attach(struct bt_vcp *vcp, struct bt_gatt_client *client)
 		return false;
 
 	bt_uuid16_create(&uuid, VCS_UUID);
-	gatt_db_foreach_service(vcp->ldb->db, &uuid, foreach_vcs_service, vcp);
+	gatt_db_foreach_service(vcp->rdb->db, &uuid, foreach_vcs_service, vcp);
 
 	bt_uuid16_create(&uuid, VOL_OFFSET_CS_UUID);
-	gatt_db_foreach_service(vcp->ldb->db, &uuid, foreach_vocs_service, vcp);
+	gatt_db_foreach_service(vcp->rdb->db, &uuid, foreach_vocs_service, vcp);
 
 	return true;
 }
-- 
2.34.1