Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nitin Jadhav <nitin.jadhav@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     devyani.godbole@nxp.com, pav@iki.fi, luiz.dentz@gmail.com,
        sathish.narasimman@intel.com, nitin.jadhav@nxp.com
Subject: [PATCH BlueZ v4 1/3] shared/vcp: Fix the crash observed with VOCS
Date:   Tue, 25 Jul 2023 16:47:40 +0300
Message-Id: <20230725134742.51651-2-nitin.jadhav@nxp.com>
In-Reply-To: <20230725134742.51651-1-nitin.jadhav@nxp.com>
References: <20230725134742.51651-1-nitin.jadhav@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bwcdMmKlUP3dQVzzOo1CF8RLf8gAYBOZ4zBjxSN/VcGHJQyRdo5k/kNud7Fq?=
 =?us-ascii?Q?0hHjY9jJug8RZNbe+bL3whH0wwDiFzHo1l6Cqg5JmToxGVmUTpzAJbpj6dg1?=
 =?us-ascii?Q?9Cxyp/VWqiT1ofXFFCdvybjX4vorj8JfdytqrlQOtkfSczahX9ZtxpPpWA8k?=
 =?us-ascii?Q?8Vztl8zxlpBNk8duO8H4dq8f5t17V+f+UrFBhV0YHDCJnllagPf1XYH7nV2N?=
 =?us-ascii?Q?g61rVCE8DO4eAT1syjtoQuhHv2kiUkQvfHaWOBoOAKU8gWyyykfiJEpmDIUn?=
 =?us-ascii?Q?zZnX3XKV++r5GxE0S5Oas5Iehz41f/G95rVL3MBURPDS8/DLJrjNRizkrqhg?=
 =?us-ascii?Q?SvOdbK8a1UoQ6ft6RYdk992IW6LWF0PrO4R6MKiPIcK+KzJglsHCm+WcHWQG?=
 =?us-ascii?Q?NwdRNRRJaAXkp6GrchJxKi3qk2ZPA6BeDZrATMjZg75r4DiJ1GNKoETl1VuS?=
 =?us-ascii?Q?cns9Eex7pDbQiFPuuwzpufcKJL/6WX27fdFSIfgY6yXZMQeP1gRkO8++mnuS?=
 =?us-ascii?Q?79/gPJTHDVXfiVcUALZa2e0TqMy6ziqsoGbvsYsfHmE4R3EiBDPKsNa3b1k9?=
 =?us-ascii?Q?BfaE+FMvj8Krlsd62TDGB6JbKwl2/M2fgf8IKuzCXCW2opgfIvmrieH62WyE?=
 =?us-ascii?Q?eZP1Dd6qymjiwecD4fjCCBnd7+C9U7VmMHglw2etDe3Lp1Ho9kyD7szW2s3b?=
 =?us-ascii?Q?GBaZJGxzkG91yYzChpcc1JCHPQPrfQlSEbuB+9IpStdAGhk2uDQYhesnOZBH?=
 =?us-ascii?Q?PgTrunx40h2Grax64MGgghnNlsjcWj6yCTrSw+Fvip6N9fJMCo7bhyWTRsxG?=
 =?us-ascii?Q?5RF/93gsvQ69xotTMqFzoroF2WicUVIm/87AO2G/S7HtvvotlqSSY9+Hc2Ep?=
 =?us-ascii?Q?dwEr4s8Oo7R9oQk54TsQ0K+zDFkMcOUDEZl65625tujhqhYzayOt3RFUIn0y?=
 =?us-ascii?Q?gqThtP9BmLfSK4LTyz+1Z6lETwBpLCVOLwN/uqFmpLXAIJAtJbSemRrJeTDt?=
 =?us-ascii?Q?FvUbco/rM4h3tVI7F+T7IRwilPmyBrwvABMUIR/xr3zhhnhUd4kPQRBa0qyS?=
 =?us-ascii?Q?2FAPI11nw7gvzNm3GEbHWi6Nto+kAQkpUSWG9fBFsFFUt3QudC2o0KJyw7mV?=
 =?us-ascii?Q?OFcT/i8IMGszogfeXQZ6Y0G0oQ5AB7esNl/2t5gPljnfX0z2oIf5ocDiftnV?=
 =?us-ascii?Q?I1cBc+ALULP0SWvunPQK8HTpFfHMleVDY3Faa4soyKqW3rVCRwahQ0BOJoKv?=
 =?us-ascii?Q?VO+nZ0Jitb86NIKMWyBgo+sDqsXDqOEvBcdF9E5ihxxSclkjRtW8rNoGiex+?=
 =?us-ascii?Q?d4Zx7L0fMXT+fpsSLP9yTQIsWOEjVt4hjCrxT51dAQ2YZLXb47S0on3ONDoL?=
 =?us-ascii?Q?tnz30m7/5r1jdqPUJ/GVIArh0di0v1rWAi3+wA3JUUvaDahX+T18+R8KGGPu?=
 =?us-ascii?Q?xSu/F82iCgWiZ8rRU9tnjju31Ea4VHIfkomoAFJf8zQv5ed7j+0XI1x7xFdQ?=
 =?us-ascii?Q?lG9vvY270NNme6Mlk2teIUO3sKkARv2HMKiqmNr2yKEA1qH1b2JoodNapzNP?=
 =?us-ascii?Q?V8JCDDM96SDSSviCQDZPC1y9jxBbvwf0d4aJaBTu?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa9e3cd9-729e-44d7-271d-08db8d15c556
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9126.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 13:48:04.8423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a8wWlgxVvvmn8qd+F+ovxhb6we7sZGODHWM3rIl9VziPiCiqmFfwYrWU2UeyTnD1bgowVpJZly5uQLcw+YvZag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9593
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Root cause
- There are two types of database- Remote and Local (rdb and ldb).
- In client mode currently the code was written to access ldb.

Fix
- Correcting it, to access rdb has resolved the problem in VOCS.
- Same correction is done for VCS.

Reported-by: Pauli Virtanen <pav@iki.fi>
---
 src/shared/vcp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/shared/vcp.c b/src/shared/vcp.c
index 74bd01729..314618664 100644
--- a/src/shared/vcp.c
+++ b/src/shared/vcp.c
@@ -1719,10 +1719,10 @@ bool bt_vcp_attach(struct bt_vcp *vcp, struct bt_gatt_client *client)
 		return false;
 
 	bt_uuid16_create(&uuid, VCS_UUID);
-	gatt_db_foreach_service(vcp->ldb->db, &uuid, foreach_vcs_service, vcp);
+	gatt_db_foreach_service(vcp->rdb->db, &uuid, foreach_vcs_service, vcp);
 
 	bt_uuid16_create(&uuid, VOL_OFFSET_CS_UUID);
-	gatt_db_foreach_service(vcp->ldb->db, &uuid, foreach_vocs_service, vcp);
+	gatt_db_foreach_service(vcp->rdb->db, &uuid, foreach_vocs_service, vcp);
 
 	return true;
 }
-- 
2.34.1