Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2cf9a03e-6d81-64cd-3cc2-0b989e5d5824@molgen.mpg.de>
Date:   Wed, 26 Jul 2023 17:11:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH net-next] Bluetooth: Remove unused declaration
 amp_read_loc_info()
Content-Language: en-US
To:     yuehaibing@huawei.com
Cc:     marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230726142817.20504-1-yuehaibing@huawei.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20230726142817.20504-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear YueHaibing,


Thank you very much for your patch.

Am 26.07.23 um 16:28 schrieb YueHaibing:
> This is never used, so remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Should your name be spelled with a space: Yue Haibing?

     $ git config --global user.name "Yue Haibing"
     $ git commit --amend --author="Yue Haibing <yuehaibing@huawei.com>"

> ---
>   net/bluetooth/amp.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
> index 832764dfbfb3..97c87abd129f 100644
> --- a/net/bluetooth/amp.h
> +++ b/net/bluetooth/amp.h
> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
>   
>   int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
>   
> -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);

Was it never implemented, or just forgotten to be removed?

>   void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
>   void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
>   void amp_read_loc_assoc_final_data(struct hci_dev *hdev,


Kind regards,

Paul