Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <23d58498-60a5-9de5-0bf1-71bf636da110@quicinc.com>
Date:   Thu, 27 Jul 2023 16:00:44 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v13 2/2] Bluetooth: hci_qca: Add support for Qualcomm
 Bluetooth SoC QCA2066
Content-Language: en-US
To:     Johan Hovold <johan@kernel.org>
CC:     <marcel@holtmann.org>, <luiz.dentz@gmail.com>,
        <johan.hedberg@gmail.com>, <linux-kernel@vger.kernel.org>,
        <linux-bluetooth@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <quic_bgodavar@quicinc.com>, <quic_hemantg@quicinc.com>
References: <20230727044011.965205-1-quic_tjiang@quicinc.com>
 <20230727044011.965205-3-quic_tjiang@quicinc.com>
 <ZMIdE1ffQEmFMC8V@hovoldconsulting.com>
From:   Tim Jiang <quic_tjiang@quicinc.com>
In-Reply-To: <ZMIdE1ffQEmFMC8V@hovoldconsulting.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/27/23 15:30, Johan Hovold wrote:
> On Thu, Jul 27, 2023 at 12:40:11PM +0800, Tim Jiang wrote:
>> This patch adds support for QCA2066 firmware patch and NVM downloading.
>> as the RF performance of QCA2066 SOC chip from different foundries may
>> vary. Therefore we use different NVM to configure them based on board ID.
>>
>> Signed-off-by: Tim Jiang <quic_tjiang@quicinc.com>
>> ---
>   
>> @@ -1931,6 +1934,12 @@ static const struct qca_device_data qca_soc_data_wcn3998 __maybe_unused = {
>>   	.num_vregs = 4,
>>   };
>>   
>> +static const struct qca_device_data qca_soc_data_qca2066 __maybe_unused = {
>> +	.soc_type = QCA_QCA2066,
>> +	.num_vregs = 0,
>> +};
>> +
>> +
> Stray newline.
[Tim] sorry for this typo, will address it in v14 , thank you.
>
>>   static const struct qca_device_data qca_soc_data_qca6390 __maybe_unused = {
>>   	.soc_type = QCA_QCA6390,
>>   	.num_vregs = 0,
> Johan