Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230725084431.640332-1-simon.mikuda@streamunlimited.com> <20230725084431.640332-9-simon.mikuda@streamunlimited.com>
In-Reply-To: <20230725084431.640332-9-simon.mikuda@streamunlimited.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 27 Jul 2023 11:47:57 -0700
Message-ID: <CABBYNZ+yGTjzDwGCzf7ShUejDRz-THfh8w_=+Cn7xupxXogHng@mail.gmail.com>
Subject: Re: [PATCH BlueZ 8/8] adapter: Ensure that file exists on IRK write
To:     Simon Mikuda <simon.mikuda@streamunlimited.com>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Simon,

On Tue, Jul 25, 2023 at 1:56=E2=80=AFAM Simon Mikuda
<simon.mikuda@streamunlimited.com> wrote:
>
> ---
>  src/adapter.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index 4c3bb091d..fe8ae7604 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -8823,6 +8823,8 @@ static void store_irk(struct btd_adapter *adapter, =
const bdaddr_t *peer,
>
>         g_key_file_set_string(key_file, "IdentityResolvingKey", "Key", st=
r);
>
> +       create_file(filename, 0600);
> +
>         store_data =3D g_key_file_to_data(key_file, &length, NULL);
>         if (!g_file_set_contents(filename, store_data, length, &gerr)) {
>                 error("Unable set contents for %s: (%s)", filename,
> --
> 2.34.1

This looks like a fix as well so reword it and send it separately,
also please add the runtime error in the description.


--=20
Luiz Augusto von Dentz