Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230727013907.29068-1-yuehaibing@huawei.com>
In-Reply-To: <20230727013907.29068-1-yuehaibing@huawei.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 27 Jul 2023 15:21:43 -0700
Message-ID: <CABBYNZ+Fxmkxg3qQMABt-1DcvhMcUnqsOrwGgHXMQum5ezF82Q@mail.gmail.com>
Subject: Re: [PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()
To:     Yue Haibing <yuehaibing@huawei.com>
Cc:     marcel@holtmann.org, johan.hedberg@gmail.com,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
        pmenzel@molgen.mpg.de
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Yue,

On Wed, Jul 26, 2023 at 6:42=E2=80=AFPM Yue Haibing <yuehaibing@huawei.com>=
 wrote:
>
> This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd t=
o Read Loc AMP Assoc")
> and never be implemented.

The commit information above shall be added with Fixes: tag so it can
be properly backported, etc.

> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> v2: fix SOB and update commit log
> ---
>  net/bluetooth/amp.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
> index 832764dfbfb3..97c87abd129f 100644
> --- a/net/bluetooth/amp.h
> +++ b/net/bluetooth/amp.h
> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, stru=
ct amp_mgr *mgr,
>
>  int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
>
> -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
>  void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
>  void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
>  void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
> --
> 2.34.1
>


--=20
Luiz Augusto von Dentz