Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230729004552.1422547-1-lukasz.rymanowski@codecoup.pl>
 <20230729004552.1422547-6-lukasz.rymanowski@codecoup.pl> <907983cc-4175-1130-cb1c-ca42baa40dfa@molgen.mpg.de>
In-Reply-To: <907983cc-4175-1130-cb1c-ca42baa40dfa@molgen.mpg.de>
From:   =?UTF-8?Q?=C5=81ukasz_Rymanowski?= <lukasz.rymanowski@codecoup.pl>
Date:   Sat, 29 Jul 2023 21:11:03 +0200
Message-ID: <CAExxLLAEgGJFyAWV-sX06o9nxTbDoUy=KH6e_jxUOYuhXFbOOQ@mail.gmail.com>
Subject: Re: [PATCH BlueZ 5/5] monitor: Add parsing Service Data of UUID 128
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Paul


On Sat, 29 Jul 2023 at 06:42, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear =C5=81ukasz,
>
>
> Thank you for your patch.
>
> Am 29.07.23 um 02:45 schrieb =C5=81ukasz Rymanowski:
> > In the advertising report, instead of deciding EIR 0x21 into this:
>
> Do you mean deciphering?

Thanks for pointing it out. Just sent v2 for this patch.

>
> >
> >       Unknown EIR field 0x21: 3a048f2ba97ea6ae1b49c619e973a4a701480d130=
d
> >
> > We can do bit better
> >
> >          Service Data UUID 128: Vendor specific
> >            Data: 01480d130d
> > ---
> >   monitor/packet.c | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/monitor/packet.c b/monitor/packet.c
> > index 3031b028f..21e08ccef 100644
> > --- a/monitor/packet.c
> > +++ b/monitor/packet.c
> > @@ -3997,6 +3997,18 @@ static void print_eir(const uint8_t *eir, uint8_=
t eir_len, bool le)
> >                       print_service_data(data, data_len);
> >                       break;
> >
> > +             case BT_EIR_SERVICE_DATA128:
> > +                     if (data_len <=3D 16)
> > +                             break;
> > +
> > +                     print_field("Service Data UUID 128: %s ",
> > +                                             bt_uuid128_to_str(&data[0=
]));
> > +
> > +                     if (data_len > 16)
> > +                             print_hex_field("  Data", &data[16],
> > +                                                             data_len =
- 16);
> > +
> > +                     break;
> >               case BT_EIR_RANDOM_ADDRESS:
> >                       if (data_len < 6)
> >                               break;
>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
>
>
> Kind regards,
>
> Paul

Best
=C5=81ukasz