Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b91708a1-8dd5-f587-03f0-302ee9a85570@molgen.mpg.de>
Date:   Mon, 31 Jul 2023 07:43:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.1
Subject: Re: [PATCH BlueZ 1/2] adapter: Be able to use ConnectDevice for
 discovered devices
Content-Language: en-US
To:     Simon Mikuda <simon.mikuda@streamunlimited.com>
References: <CABBYNZKtfk4O=1VLoh0nb_PtR8hzJsPg53P+_q3+kAUAO+cWxg@mail.gmail.com>
 <20230731041229.1429016-1-simon.mikuda@streamunlimited.com>
Cc:     linux-bluetooth@vger.kernel.org,
        Szymon Janc <szymon.janc@codecoup.pl>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20230731041229.1429016-1-simon.mikuda@streamunlimited.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

[Cc: +Szymon]

Dear Simon,


Thank you for your patch. In the commit summary, an alternative to “Be 
able” could be “Allow”.

Am 31.07.23 um 06:12 schrieb Simon Mikuda:
> This can be useful when you want to specify trasport type for already

tra*n*sport

> paired device (e.g. use LE transport for dual mode device).

Could you please elaborate a little more? Maybe even give an example, 
how this can be tested?

> ---
>   src/adapter.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/src/adapter.c b/src/adapter.c
> index 2679d4302..17f4a637d 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -3763,9 +3763,6 @@ static DBusMessage *connect_device(DBusConnection *conn,
>   	if (!bacmp(&addr, BDADDR_ANY))
>   		return btd_error_invalid_args(msg);
>   
> -	if (btd_adapter_find_device(adapter, &addr, addr_type))
> -		return btd_error_already_exists(msg);
> -
>   	device_connect(adapter, &addr, addr_type, msg);
>   	return NULL;
>   }