Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ec12c138-048e-8ca2-866a-7142667ef62c@streamunlimited.com>
Date:   Mon, 31 Jul 2023 08:24:48 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH BlueZ 1/2] adapter: Be able to use ConnectDevice for
 discovered devices
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     linux-bluetooth@vger.kernel.org,
        Szymon Janc <szymon.janc@codecoup.pl>
References: <CABBYNZKtfk4O=1VLoh0nb_PtR8hzJsPg53P+_q3+kAUAO+cWxg@mail.gmail.com>
 <20230731041229.1429016-1-simon.mikuda@streamunlimited.com>
 <b91708a1-8dd5-f587-03f0-302ee9a85570@molgen.mpg.de>
Content-Language: en-US
From:   Simon Mikuda <simon.mikuda@streamunlimited.com>
In-Reply-To: <b91708a1-8dd5-f587-03f0-302ee9a85570@molgen.mpg.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Paul.

Should I submit new patch with fixed commit message text?

For the testing part:

Precondition: have the linux BT adapter (DUT) ready and some remote 
device you want to connect to

Steps:

- make remote device discoverable
- scan for devices on DUT: bluetoothctl --> scan on
- wait until the remote device pops out on dbus interface
- connect to the remote device using Adapter1.ConnectDevice

To do this you can use these commands:

LE: gdbus call --system --dest org.bluez --object-path /org/bluez/hci0 
--method org.bluez.Adapter1.ConnectDevice "{'Address': 
<'00:00:00:00:00:00'>, 'AddressType': <'public'>}"
BR/EDR: gdbus call --system --dest org.bluez --object-path 
/org/bluez/hci0 --method org.bluez.Adapter1.ConnectDevice "{'Address': 
<'00:00:00:00:00:00'>}"

For example if remote device emits LE advertisements with general 
discoverable flag set and the flag "BR/EDR not supported" is NOT set 
calling reqeuset Device1.Connect would result connecting on BR/EDR 
transport bearer.

BR,

Simon

On 31. 7. 2023 7:43, Paul Menzel wrote:
> [Cc: +Szymon]
>
> Dear Simon,
>
>
> Thank you for your patch. In the commit summary, an alternative to “Be 
> able” could be “Allow”.
>
> Am 31.07.23 um 06:12 schrieb Simon Mikuda:
>> This can be useful when you want to specify trasport type for already
>
> tra*n*sport
>
>> paired device (e.g. use LE transport for dual mode device).
>
> Could you please elaborate a little more? Maybe even give an example, 
> how this can be tested?
>
>> ---
>>   src/adapter.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/src/adapter.c b/src/adapter.c
>> index 2679d4302..17f4a637d 100644
>> --- a/src/adapter.c
>> +++ b/src/adapter.c
>> @@ -3763,9 +3763,6 @@ static DBusMessage 
>> *connect_device(DBusConnection *conn,
>>       if (!bacmp(&addr, BDADDR_ANY))
>>           return btd_error_invalid_args(msg);
>>   -    if (btd_adapter_find_device(adapter, &addr, addr_type))
>> -        return btd_error_already_exists(msg);
>> -
>>       device_connect(adapter, &addr, addr_type, msg);
>>       return NULL;
>>   }