Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b2151d37-b108-7edf-e9d9-870fbde4553c@quicinc.com>
Date:   Mon, 31 Jul 2023 16:58:24 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v1] main: Fix a logical error within parse_config_int()
To:     Paul Menzel <pmenzel@molgen.mpg.de>
CC:     <luiz.dentz@gmail.com>, <linux-bluetooth@vger.kernel.org>
References: <1690789604-3576-1-git-send-email-quic_zijuhu@quicinc.com>
 <698aa5d3-3261-c9d9-d754-d36ae9716eb4@molgen.mpg.de>
Content-Language: en-US
From:   quic_zijuhu <quic_zijuhu@quicinc.com>
In-Reply-To: <698aa5d3-3261-c9d9-d754-d36ae9716eb4@molgen.mpg.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/31/2023 4:48 PM, Paul Menzel wrote:
> Dear Zijun,
> 
> 
> Am 31.07.23 um 09:46 schrieb Zijun Hu:
>> Fix a logical error within parse_config_int().
> 
> Thank you for spotting and fixing this. I guess this warning was printed on the terminal?
no any warnings by following Compilation steps of README.
> 
> Although obvious, instead of duplicating the commit message summary in the body, it would be great, if you still wrote a more elaborate commit message. Maybe:
> 
> Having a config file with the line below
> 
>     …
> 
> causes the config file to be ignored, and the warning below:
> 
>     …
>
the error is very simple, so i don't write more to explain it.
>> ---
>>   src/main.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/main.c b/src/main.c
>> index 150a5af4cca4..13501440b052 100644
>> --- a/src/main.c
>> +++ b/src/main.c
>> @@ -458,7 +458,7 @@ static bool parse_config_int(GKeyFile *config, const char *group,
>>           return false;
>>       }
>>   -    if (tmp < max) {
>> +    if (tmp > max) {
>>           warn("%s.%s = %d is out of range (> %d)", group, key, tmp, max);
>>           return false;
>>       }
> 
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul