Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp2360347rwo; Thu, 3 Aug 2023 08:19:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlFxKvaph85Zu+VWyYuq1oI3x0Ac8Rex2EU8LBZooVzOze7cPADjhYlMB2RmebvJzvoYFXPQ X-Received: by 2002:a19:2d4b:0:b0:4fb:89e3:5ac6 with SMTP id t11-20020a192d4b000000b004fb89e35ac6mr7668015lft.62.1691075943523; Thu, 03 Aug 2023 08:19:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691075943; cv=none; d=google.com; s=arc-20160816; b=bnJVARiCZSU34jk/gFvHr+gTtbk89dp4rApFmPE2/vWCfoh/Wb8kOb62Coj5xHSVA6 6vlyQo7TWpxLD0e5c0VKRp5ywAoiom+KT7fYJN9ufnVYkVCgRicTIMFFvaF2QhLBdvnO Z7vwWk2hRLeb5tHprUeExv7y0y9/DDKHUk8Nlx8MidfE5uW+2GqX7ndR2pyedGkdXrSI vuYaZlSp1Hg2uLf3GPFd1paau9gUFoODgSREIK9NjCEsR9z17WewTBtO+mmWC6NtiFxt GP+ZjNLixYFt9nMUz68w4Z/qlEXKuXJL6R8QE8MfXMdTSQxEu21t1VPaPXBe9eRs1e7m Ye9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=V3mghrz9OrBSYshm4Q7Wp+R2eq4CCboBYWI6GECA7Qk=; fh=PYdc3Yy+SYF8IaMnnDUDsl5F2FT6IMt8VA5fLDPeRQs=; b=EIy8Qti129eHWVGoFgLIfbI1b3jYsmCdGSKZ4Pk4dor6o9RPMjhwqmFz8jVKT3tlbI FM4cvyqHWrJml9RX6MpQnHMWYbm5DOS/anGw+MU7oMrbr3v/3RRVOlnpdkxIXR279m1O o6egZSfhNP4P3kVCC81JGxGGFFH1ceAkHYF6JpEVrngRZwiAUZBDSrHn1bZf5YSGcbqA mUZVXkyzec6e/Ma89u2EdJPgqTa6/CDh7Hiio8PnXrxGF0KRcHWz5TgAXwHDG89G3qxG ln+w9b5qjJqVGP1FlM7OXliXzKNVYqXsb9aTdczZmRXEhdpOAzKVVH65+7sq62OARKwI 4+9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dnZo4TfW; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v1-20020aa7cd41000000b0052309c467c6si1925018edw.211.2023.08.03.08.17.40; Thu, 03 Aug 2023 08:19:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dnZo4TfW; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236278AbjHCO6h (ORCPT + 99 others); Thu, 3 Aug 2023 10:58:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232505AbjHCO6g (ORCPT ); Thu, 3 Aug 2023 10:58:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA278173F; Thu, 3 Aug 2023 07:58:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E4F861DEB; Thu, 3 Aug 2023 14:58:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFD23C433C8; Thu, 3 Aug 2023 14:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691074714; bh=yMg1YEwuJlIFczOQZY8fQXTUaLaqCwPe1K5AJfailb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dnZo4TfWlyzyTmeTVwJWce2tqZsbJPYrVVSOM8snyxCcEa18Q473++Mm5TzoZbXF4 XG/fbkrFrX8fv2hmeJHqpy34ohk+n3uYw4VyKDaeQBvKAblqmLjRXZOr+s5scO1P3S ISgoZraioxE44UFUuwofEcSSikNuLQl4qrcUE5ALRpzMgRVvoYVKXBBKu0QWubvLXt +nivNO666XHDvB7isEqr2AOhNL3doay5dUfd9BsKgbeuSd3Yr2LPd49UxnVCd5HG4b ingQ56KYEVvDxjWb8/cBWUsziSCYyn3eCzRX5ThpJinsY6AVmqyIzTpdAkt/Z5JQKA dqb99rMqyWC/A== Date: Thu, 3 Aug 2023 16:58:28 +0200 From: Simon Horman To: Neil Armstrong Cc: Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marcel Holtmann , Johan Hedberg , Andy Gross , Bjorn Andersson , Konrad Dybcio , Balakrishna Godavarthi , Rocky Liao , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3 2/3] bluetooth: qca: use switch case for soc type behavior Message-ID: References: <20230803-topic-sm8550-upstream-bt-v3-0-6874a1507288@linaro.org> <20230803-topic-sm8550-upstream-bt-v3-2-6874a1507288@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230803-topic-sm8550-upstream-bt-v3-2-6874a1507288@linaro.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Thu, Aug 03, 2023 at 10:45:27AM +0200, Neil Armstrong wrote: > Use switch/case to handle soc type specific behaviour, > the permit dropping the qca_is_xxx() inline functions > and maked the code clearer and easier to update for new nit: maked -> make > SoCs. > > Suggested-by: Konrad Dybcio > Suggested-by: Luiz Augusto von Dentz > Signed-off-by: Neil Armstrong ...