Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230808085540.1475435-1-gioele@svario.it> <20230808085540.1475435-2-gioele@svario.it>
In-Reply-To: <20230808085540.1475435-2-gioele@svario.it>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 8 Aug 2023 11:48:40 -0700
Message-ID: <CABBYNZLfUaVzERO+ddHkoE39mObZ+uAm8EF+VXngKyQZ4rJjRA@mail.gmail.com>
Subject: Re: [PATCH BlueZ 1/1] Makefile.am: Install D-Bus policy in
 /usr/share, not /etc
To:     Gioele Barabucci <gioele@svario.it>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Gioele,

On Tue, Aug 8, 2023 at 11:23=E2=80=AFAM Gioele Barabucci <gioele@svario.it>=
 wrote:
>
> From https://bugs.debian.org/1006631:
>
> > dbus supports policy files in both `/usr/share/dbus-1/system.d` and
> > `/etc/dbus-1/systemd`. [The] recently released dbus 1.14.0, officially
> > deprecates installing packages' default policies into `/etc/dbus-1/syst=
emd`,
> > instead reserving it for the sysadmin. This is the same idea as the
> > difference between `/usr/lib/udev/rules.d` and `/etc/udev/rules.d`.

I'm fine with these changes but we also need to bump dbus dependency
to 1.14 then since it currently requiring 1.6:

PKG_CHECK_MODULES(DBUS, dbus-1 >=3D 1.6, dummy=3Dyes,
                AC_MSG_ERROR(D-Bus >=3D 1.6 is required))

> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 4b9b7e5cd..f23c39d20 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -32,7 +32,7 @@ confdir =3D $(sysconfdir)/bluetooth
>  statedir =3D $(localstatedir)/lib/bluetooth
>
>  if DATAFILES
> -dbusdir =3D $(DBUS_CONFDIR)/dbus-1/system.d
> +dbusdir =3D $(datadir)/dbus-1/system.d
>  dbus_DATA =3D src/bluetooth.conf
>
>  conf_DATA =3D
> --
> 2.39.2
>


--=20
Luiz Augusto von Dentz