Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230808115040.4403-1-claudia.rosu@nxp.com> <20230808115040.4403-4-claudia.rosu@nxp.com>
In-Reply-To: <20230808115040.4403-4-claudia.rosu@nxp.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 8 Aug 2023 16:20:58 -0700
Message-ID: <CABBYNZJEhRvT8w9C-JBcr2pjNdStN3KkYO2zyuLb+2=5NWPhZw@mail.gmail.com>
Subject: Re: [PATCH BlueZ v5 3/7] adapter: Do not filter out broadcast advertiser
To:     Claudia Draghicescu <claudia.rosu@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org, iulia.tanasescu@nxp.com,
        mihai-octavian.urzica@nxp.com, silviu.barbulescu@nxp.com,
        vlad.pruteanu@nxp.com, andrei.istodorescu@nxp.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Claudia,

On Tue, Aug 8, 2023 at 9:45=E2=80=AFAM Claudia Draghicescu <claudia.rosu@nx=
p.com> wrote:
>
> This allows a broadcast advertiser to be passed up to application,
> if the adapter has the capability of being a Synchronized Receiver.

We probably need a proper method to check if there is any profile with
probe_on_discover that matches the advertising before we allow every
broadcaster to be added as a new device.

> ---
>  src/adapter.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index 491bd7031..fa15030e0 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -7029,6 +7029,13 @@ static bool is_filter_match(GSList *discovery_filt=
er, struct eir_data *eir_data,
>         return got_match;
>  }
>
> +static bool accept_bcast_adv(struct btd_adapter *adapter)
> +{
> +       if ((btd_adapter_has_settings(adapter, MGMT_SETTING_ISO_SYNC_RECE=
IVER)))
> +               return true;
> +
> +       return false;
> +}
>  static void filter_duplicate_data(void *data, void *user_data)
>  {
>         struct discovery_client *client =3D data;
> @@ -7152,6 +7159,9 @@ void btd_adapter_device_found(struct btd_adapter *a=
dapter,
>                         return;
>                 }
>
> +               if (accept_bcast_adv(adapter))
> +                       monitoring =3D true;
> +
>                 if (!discoverable && !monitoring && !eir_data.rsi) {
>                         eir_data_free(&eir_data);
>                         return;
> --
> 2.34.1
>


--=20
Luiz Augusto von Dentz