Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c479a8ec-a134-c209-6bd6-92feaa670c22@svario.it>
Date:   Wed, 9 Aug 2023 08:43:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Content-Language: en-US
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     linux-bluetooth@vger.kernel.org
References: <20230808200022.2001329-1-gioele@svario.it>
 <a22d3ca8-2ec8-4968-801e-2bbc3b8e4d09@molgen.mpg.de>
From:   Gioele Barabucci <gioele@svario.it>
Subject: Re: [PATCH BlueZ v2] configure.ac: Install D-Bus policy in
 /usr/share, not /etc
In-Reply-To: <a22d3ca8-2ec8-4968-801e-2bbc3b8e4d09@molgen.mpg.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 09/08/23 08:02, Paul Menzel wrote:
> Am 08.08.23 um 22:00 schrieb Gioele Barabucci:
>>  From https://bugs.debian.org/1006631:
>>
>>> dbus supports policy files in both `/usr/share/dbus-1/system.d` and
>>> `/etc/dbus-1/systemd`. [The] recently released dbus 1.14.0, officially
>>> deprecates installing packages' default policies into
>>> `/etc/dbus-1/systemd`, instead reserving it for the sysadmin.
>>> This is the same idea as the difference between `/usr/lib/udev/rules.d`
>>> and `/etc/udev/rules.d`.
>> ---
>> v2: bump D-Bus min version, derive DBUS_CONFDIR from datadir
> 
> It’d be great if you mentioned the D-Bus version bump explicitly in the 
> commit message, and the years of the release (2012 and 2015).

Sure. V3 is on its way.

> (Maybe even make it a separate commit.)

No problem. I sent everything in one patch because I read

> 3) Split your patch according to the top-level directories. E.g.: if 
> you added a feature that touches files under 'include/', 'src/' and
> 'drivers/' directories, split in three separated patches, taking care
> not to break compilation.
in HACKING as "don't split too much, we prefer one patch per directory", 
but I now understand that it actually means "touch at most one directory 
per commit".

Regards,

-- 
Gioele Barabucci