Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp441478rwl; Wed, 9 Aug 2023 17:40:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/nsUx7mNPCdUEA5kveXMU10BFNX8l+LA2+e01GC/aSs9e/qHZNCeat15cJiYiM9Zoj/s5 X-Received: by 2002:a05:6a00:39a1:b0:65e:1d92:c0cc with SMTP id fi33-20020a056a0039a100b0065e1d92c0ccmr724886pfb.10.1691628052602; Wed, 09 Aug 2023 17:40:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691628052; cv=none; d=google.com; s=arc-20160816; b=XmqiGRcy63hXs5GpAfr0AxshXQeUq95Z7CxQkqQQ9pZJPCq63ULVmyMScdeu7/yXpa MbWY761BGi+3PL9A5foR8ITd7LD7L9+d4G7XrUKnnc+3simWQWOakzsxaIMfwT2LWGjy CRyVovA1Ysp7M8wdDPo4gEa75zjoaLWGQWM747Mv0QiKaFhH64lKYkYkSVWkTQhk20kG i65N/1/AIn35i6049RASAjFqFX+sRmaC6kq/C/XRxSDXMTegCIodaxyIP8COsTm1bRSH xpe3Tm/5zzPzLhVbtay8HWdqhp3iAsHfTFQr4CcJVTkVheNfYlc55Um9BsgQY9O6/glk mJBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=mxjLwmCkjOSlHjJ//nmGfksWy9yRb2wfkgg5dM3ztbw=; fh=YFwCE0fn4OWtSQ9b3J9JwzcJMZKDaJJZrtP326iYp/s=; b=oHgudLdtjGh6vn8bxTmGbN5Vs9FSiM/mpYMGvZF1Y3OnEYP11Khb1N/u2V3AV+thxD il/qRKddwE6DomYiWMxzHzUKME127wmZLbAA3Y1L79eZLQ6QOZhV9VApaJuvq3iB/nqI rE8qbhIJScLgGNJp4wS6VmOx4+r3BmViyq6SmowcINXdJH1jMdMArz0YVcXH9kFPPR+e 9uBx6AM9gSJNzhj9oO3viZWmDBUJ1yrqO/n2lBK8MGjq7GamlMrmtvb/NDFKz8Z0Iy5m A/3C54zOQQhebVRjD4KebdMI6hKDilHXn2GBfLad26v8GXRXodq80x8Js8+ihO37nEfg WaAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QhLIVs2W; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r3-20020a63fc43000000b0055c86d1e5e6si352793pgk.602.2023.08.09.17.40.38; Wed, 09 Aug 2023 17:40:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QhLIVs2W; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbjHJAK2 (ORCPT + 99 others); Wed, 9 Aug 2023 20:10:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229896AbjHJAKZ (ORCPT ); Wed, 9 Aug 2023 20:10:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ACDB10F5 for ; Wed, 9 Aug 2023 17:10:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6827C6422C for ; Thu, 10 Aug 2023 00:10:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id C9BB1C433CA; Thu, 10 Aug 2023 00:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691626223; bh=4j4sQCxNAtnFEgnDlfIlSEEwhVClq6AiAeCb43gFEQE=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=QhLIVs2WDyJKrPEvwWrGuL39N5vQ0bdJc0qLHycx24mMch7nepk7xDjfahuPJH/qg ZaKdMUK/DuuL1HkLBqadLRTOwfHMrgozwJ3K5jpMtkpP7uQW54gtRUFneANuxkiNtN WDCc+O6KyJxs79FFhk7ZNFyULmyMDPYweQfeBSe55k73Cn3Fp4vrrCF2a5uvwREqwT aNsKa/iTBXKeuNY/u0c3Flce4bwidGaMf8LL/DR/wgKRs8LUwh3jEXvw/J/JG00x1v AAz0dLaVMGTaIk9n0OtTXrgHSDE5GV42G0fTKGmQhMVw3xnL3+x/bVPvNr7e7+fp7R uegJu1qz+ZqmA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id B0425E505D5; Thu, 10 Aug 2023 00:10:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH BlueZ 0/1] fix writes to attributes of size 512 From: patchwork-bot+bluetooth@kernel.org Message-Id: <169162622371.3909.9864804498327871801.git-patchwork-notify@kernel.org> Date: Thu, 10 Aug 2023 00:10:23 +0000 References: <20230809202724.15429-1-bart.philips@inspiro.nl> In-Reply-To: <20230809202724.15429-1-bart.philips@inspiro.nl> To: Bart Philips Cc: linux-bluetooth@vger.kernel.org, bart.philips@inspiro.nl X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz : On Wed, 9 Aug 2023 22:27:22 +0200 you wrote: > writing attributes of length 512 fails, although the Bluetooth spec (Vol 4, Part F, 3.2.9) states that attributes sizes up to 512 are allowed. The check_length calls in write_cb and prep_write_cb in gatt-server.c currently pass the length parameter that include the handle/offset length and therefore fail for attributes of length 512. This patch subtracts the handle/offset length before passing it to the check_length function, allowing writes to attributes up to 512 in size. > > Bart Philips (1): > fix writing attributes of length 512 > > src/shared/gatt-server.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [BlueZ,1/1] fix writing attributes of length 512 https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8bf3a4a265bb You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html