Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3c21153996077c50785660213a174f6a21519aa1.camel@hadess.net>
Subject: Re: [PATCH] Bluetooth: btusb: Fix quirks table naming
From:   Bastien Nocera <hadess@hadess.net>
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     linux-bluetooth@vger.kernel.org
Date:   Tue, 22 Aug 2023 13:43:26 +0200
In-Reply-To: <0c05b814-2ec0-4b54-80a3-fc54d753c0d3@molgen.mpg.de>
References: <20230822102033.1169580-1-hadess@hadess.net>
         <0c05b814-2ec0-4b54-80a3-fc54d753c0d3@molgen.mpg.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-08-22 at 12:41 +0200, Paul Menzel wrote:
> Dear Bastian,
> 
> 
> Thank you for the patch.
> 
> Am 22.08.23 um 12:20 schrieb Bastien Nocera:
> > The quirks table was named "blacklist_table" which isn't a good
> > description for that table as devices detected using it weren't
> > ignored
> > by the driver.
> > 
> > Rename the table to match what it actually does.
> 
> Maybe mention the new name also in the summary to be more specific?
> Maybe:
> 
> Bluetooth: btusb: Rename blacklist_table to quirks_table

I think that's clear enough from the commit message itself.

> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > ---
> >   drivers/bluetooth/btusb.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 764d176e9735..a1be66ef175c 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -175,7 +175,7 @@ static const struct usb_device_id btusb_table[]
> > = {
> >   
> >   MODULE_DEVICE_TABLE(usb, btusb_table);
> >   
> > -static const struct usb_device_id blacklist_table[] = {
> > +static const struct usb_device_id quirks_table[] = {
> >         /* CSR BlueCore devices */
> >         { USB_DEVICE(0x0a12, 0x0001), .driver_info = BTUSB_CSR },
> >   
> > @@ -4113,7 +4113,7 @@ static int btusb_probe(struct usb_interface
> > *intf,
> >         if (!id->driver_info) {
> >                 const struct usb_device_id *match;
> >   
> > -               match = usb_match_id(intf, blacklist_table);
> > +               match = usb_match_id(intf, quirks_table);
> >                 if (match)
> >                         id = match;
> >         }
> 
> Thank you for doing this.
> 
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul