Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Vlad Pruteanu <vlad.pruteanu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com,
        silviu.barbulescu@nxp.com, iulia.tanasescu@nxp.com,
        andrei.istodorescu@nxp.com, Vlad Pruteanu <vlad.pruteanu@nxp.com>
Subject: [PATCH v3 1/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support
Date:   Tue, 12 Sep 2023 09:17:36 +0300
Message-Id: <20230912061736.1181699-2-vlad.pruteanu@nxp.com>
In-Reply-To: <20230912061736.1181699-1-vlad.pruteanu@nxp.com>
References: <20230912061736.1181699-1-vlad.pruteanu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cUXMIFEEBWn4rZ3ZnQsVLFQC2DgdwTftkLfM6rVdigbVe+8pdhthw6zgC0Pj?=
 =?us-ascii?Q?MWZpHRRJXyd2Mr+XkbcE1kKGqLVsK9dlqMl1wSJpaz9A1R+iQQPK1vxaKOXg?=
 =?us-ascii?Q?UMLxYBAjfJDWHA2tSAs5RoZNcb2Vrkiyn2AgvEB7bejKNi68cU8H+GRTtVUW?=
 =?us-ascii?Q?wNJwHnjAmmpHFilfztAlq4pDyVznyt1N58xtq9wyyCLKODi10isCoy+QgO5I?=
 =?us-ascii?Q?ta43ZIhKrF4KXh2NZyotf+2nZCU6GZaaIBjR5Vqs9uGhStUHVY8EyXgpLfcm?=
 =?us-ascii?Q?8ueVqkczRcHLazd1w15umLljn1Ioyj/72zh7IKbe6gIyvDoSmjRFM983Dtxf?=
 =?us-ascii?Q?DObSZzxY2cJqPcO/J8LmvtTGxvo/CzAz+SuVxJENdktdcyQNapVcnCztNA46?=
 =?us-ascii?Q?tbO1+s2LBFE/HxyMaeXC6XIzLKUYxLJ+5y9zb6qL06VIjUY+1UzwG3eik9uj?=
 =?us-ascii?Q?pS6tGoIvTyUsv+hIt9TdVhXNKFBMJU0u6kH+SdVe+koWEuYLCA4vfR1A6+Yk?=
 =?us-ascii?Q?J2tPGvO6xmOCjcTLc/JWoLM6T4OKpMiBGVeKcOu4WLwjzJHNk9v/tecJI5JN?=
 =?us-ascii?Q?kTciFi1hj/QP8eLgOBCrbCnk0Ij7tzcvZh1qfiViFHH6b38r3NVbdw4cOahC?=
 =?us-ascii?Q?GND0i45BhWlP8S1mouq8XRxvAgd9kAtyodC+bId1v3vPsCqqwqV3OrdwHHau?=
 =?us-ascii?Q?tO1u1Q7R7sTCrVtsblf8AUXppPxNLGbG3bvpW25+o37YRZ9mV6GMo6/GrVD5?=
 =?us-ascii?Q?RC8EEzlcE7U7n1lfcBsNv37KusYWo+0C9Q0HtAgD4V8gB2XNBVvSDPHo6Mvk?=
 =?us-ascii?Q?d5KVvOvIXom22tMDuRNrplmN/Q7LfZtT4hwWLjuXT0b3ncHG4paAfn+iMVgE?=
 =?us-ascii?Q?CLBsTTQdF02Q9CrxX2NGreSOdWjX8sDV/Xb/bl5nKPhDT+MbUF1dP9alEBkh?=
 =?us-ascii?Q?NrdEYbdpI55PQHJVhi49QW587xBkPPHJ3cmA5E2F+SFkhJSzWQC1iqYE/yxE?=
 =?us-ascii?Q?b3uaJouf3NIXC0qpnQ6vy8j5Wu2Dg6a43hoMiqoFcZMTAkBTPtLJDyJGWJP2?=
 =?us-ascii?Q?J5a9URR/EIYILzY7Z6FxzloeaCD+x1elNkJ+6FmiWS5JDAk1oUZ3YrPUUG9x?=
 =?us-ascii?Q?B4hnCX9PtoeHdRx8798RhIShlwoU+zCOtDVfqeW3AnlRAZ061ptg8BLmv3kZ?=
 =?us-ascii?Q?BwCLek306qz19QVsE8uhSw+FqeSIA+/lscfo7K1sk1F3POHbqLMLokYiD+3W?=
 =?us-ascii?Q?DGOpzz+lNvhUeS/fuZrps0qdFJuy1p9hQclTlVRf/u6htO/m6clfQsDjFZ3H?=
 =?us-ascii?Q?v1LMAuy2KxxgIju9cGYU9H3EtFyyKq6SWrCkF2Jus3h+QSAermSJJlwY5lsn?=
 =?us-ascii?Q?+Ih73YKaDZFXug4wOu5pJMMCmnNWPgmDLiQXRikO6PLtt8rfztEYVvOSFPtW?=
 =?us-ascii?Q?uWeFETaWfC7exSqnmV0xfz3rc3YzWVTuBqTXs87x6x0eW7+K+AcisNLYMWaa?=
 =?us-ascii?Q?k4A41IH+GHWHSrSS0OsLbR+0r9HXbLTTImo7c3yVipbhCbIJeYHB0Rx1g9jT?=
 =?us-ascii?Q?p/lI6lHr0Qy5n4P3o+9JuoghsTXQJcmEy7bx6/9eHF2Mhz51ZQaUiIuYboj+?=
 =?us-ascii?Q?YA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31004178-1754-4974-8311-08dbb3581ba8
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9398.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 06:18:40.6820
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KQWkyO+QZo6FqyWxJuxW5zdCWAjdnmkSEcFQd5hcACY6hLaOCbChJLihtVX6U/r+DHM5s6ZVcSAP2NEacPvJ/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7092
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 11 Sep 2023 23:18:48 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email

As mentioned in the Bluetooth Specification the full name of this bit is
"Connected Isochronous Stream (Host Support)", thus it should be set only
for CIS capable devices. Currently, it is set for any device that has CIS
or BIS support. In reality, devices that support BIS may not allow that 
bit to be set and so, the HCI bring up fails for them.

This commit fixes this by only setting the bit for CIS capable devices.

Signed-off-by: Vlad Pruteanu <vlad.pruteanu@nxp.com>
---
 net/bluetooth/hci_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index ec4dfc4c5749..1be5763c261c 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4264,12 +4264,12 @@ static int hci_le_set_host_feature_sync(struct hci_dev *hdev)
 {
 	struct hci_cp_le_set_host_feature cp;
 
-	if (!iso_capable(hdev))
+	if (!cis_capable(hdev))
 		return 0;
 
 	memset(&cp, 0, sizeof(cp));
 
-	/* Isochronous Channels (Host Support) */
+	/* Connected Isochronous Channels (Host Support) */
 	cp.bit_number = 32;
 	cp.bit_value = 1;
 
-- 
2.34.1