Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <09443d89e7486d890b346d47ebc5c6a8f5eb30af.1688323254.git.pav@iki.fi>
 <168858002504.7518.9584432839192702711.git-patchwork-notify@kernel.org>
 <CABBYNZ+7kcMqxMCH+VEJgk3x=37RU2Mchdxn3xFuU2uVp7nsqw@mail.gmail.com> <0711a8538290d26724ca39b684cc064eb89ab185.camel@iki.fi>
In-Reply-To: <0711a8538290d26724ca39b684cc064eb89ab185.camel@iki.fi>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 12 Sep 2023 14:04:57 -0700
Message-ID: <CABBYNZKZAcZumCWHhdRf=MY5qHfHp63Ob0+_0bKNLAv+5Qxhaw@mail.gmail.com>
Subject: Re: [PATCH BlueZ v2 1/2] shared/bap: detach io for source ASEs only
 after Stop Ready
To:     Pauli Virtanen <pav@iki.fi>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Pauli,

On Sun, Sep 10, 2023 at 9:31=E2=80=AFAM Pauli Virtanen <pav@iki.fi> wrote:
>
> Hi Luiz,
>
> to, 2023-08-31 kello 14:04 -0700, Luiz Augusto von Dentz kirjoitti:
> > On Wed, Jul 5, 2023 at 11:18=E2=80=AFAM <patchwork-bot+bluetooth@kernel=
.org> wrote:
> > >
> > > Hello:
> > >
> > > This series was applied to bluetooth/bluez.git (master)
> > > by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
> > >
> > > On Sun,  2 Jul 2023 21:43:04 +0300 you wrote:
> > > > The Client may terminate a CIS when sink is in QOS and source in
> > > > Disabling states (BAP v1.0.1 Sec 5.6.5).  It may also terminate it =
when
> > > > Receiver Stop Ready has completed successfully (BAP v1.0.1 Sec 5.6.=
5.1).
> > > >
> > > > It appears Samsung Galaxy Buds2 Pro (R510XXUOAWA5) ignores the Rece=
iver
> > > > Stop Ready command if CIS is already disconnected, and then gets st=
uck
> > > > in disabling state. It works if CIS is disconnected after Receiver =
Stop
> > > > Ready.
> > > >
> > > > [...]
> > >
> > > Here is the summary with links:
> > >   - [BlueZ,v2,1/2] shared/bap: detach io for source ASEs only after S=
top Ready
> > >     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3D7b10e72d=
e6f4
> > >   - [BlueZ,v2,2/2] bap: wait for CIG to become configurable before re=
creating CIS
> > >     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3D8c317019=
0d6f
> > >
> > > You are awesome, thank you!
> > > --
> > > Deet-doot-dot, I am a bot.
> > > https://korg.docs.kernel.org/patchwork/pwbot.html
> >
> > Looks like this one introduces a problem when using the emulator:
> >
> > https://gist.github.com/Vudentz/5c7ef940fc97b054227559dcd47b99f7?permal=
ink_comment_id=3D4677775#gistcomment-4677775
> >
> > If I try to release then acquire then it won't trigger recreate logic,
> > I suspect this is due to bap_io_disconnected being called ahead of
> > states changes.
>
> Sorry for the delay. Was this fixed by d06b912df5ab ("bap: Fix not
> always calling bap_io_close on disconnect")? If not, I'll try to
> reproduce.

Yeah, that should have been fixed already.

> --
> Pauli Virtanen


--=20
Luiz Augusto von Dentz