Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20230912064026.1203509-1-vlad.pruteanu@nxp.com> <20230912064026.1203509-2-vlad.pruteanu@nxp.com>
In-Reply-To: <20230912064026.1203509-2-vlad.pruteanu@nxp.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 12 Sep 2023 11:28:53 -0700
Message-ID: <CABBYNZLKx0_4w5uBuchqCVHL2bubev3bMcq7L-QOFE50DPZpzA@mail.gmail.com>
Subject: Re: [PATCH BlueZ 1/1] client/player: Add command for control of BIS encryption
To:     Vlad Pruteanu <vlad.pruteanu@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org, claudia.rosu@nxp.com,
        mihai-octavian.urzica@nxp.com, silviu.barbulescu@nxp.com,
        iulia.tanasescu@nxp.com, andrei.istodorescu@nxp.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Vlad,

On Mon, Sep 11, 2023 at 11:44=E2=80=AFPM Vlad Pruteanu <vlad.pruteanu@nxp.c=
om> wrote:
>
> Currently there is no way to set the BIS encryption from
> the bluetoothctl application. This commit adds support
> for one.
>
> Usage:
>         encryption [on/off]

Don't really like the idea of having encryption here, I'd prompt the
user asking if he wants encryption as part of endpoint.config when we
detect it is for broadcast and if he responds yes then we can prompt
for the key as well.

> ---
>  client/player.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/client/player.c b/client/player.c
> index 42721c210..b1da5e839 100644
> --- a/client/player.c
> +++ b/client/player.c
> @@ -3196,6 +3196,28 @@ done:
>         return bt_shell_noninteractive_quit(EXIT_SUCCESS);
>  }
>
> +static void cmd_encryption_endpoint(int argc, char *argv[])
> +{
> +
> +       uint8_t value;
> +
> +       if (argc < 2) {
> +               bt_shell_printf("Encryption: %s\n",
> +                               bcast_qos.bcast.encryption ? "on" : "off"=
);
> +               return bt_shell_noninteractive_quit(EXIT_SUCCESS);
> +       }
> +
> +       if (!strcmp(argv[1], "on") || !strcmp(argv[1], "yes"))
> +               value =3D 1;
> +       else if (!strcmp(argv[1], "off") || !strcmp(argv[1], "no"))
> +               value =3D 0;
> +       else
> +               return bt_shell_noninteractive_quit(EXIT_FAILURE);
> +
> +       bcast_qos.bcast.encryption =3D value;
> +       return bt_shell_noninteractive_quit(EXIT_SUCCESS);
> +}
> +
>  static const struct bt_shell_menu endpoint_menu =3D {
>         .name =3D "endpoint",
>         .desc =3D "Media Endpoint Submenu",
> @@ -3221,6 +3243,10 @@ static const struct bt_shell_menu endpoint_menu =
=3D {
>                                                 cmd_presets_endpoint,
>                                                 "List available presets",
>                                                 uuid_generator },
> +       { "encryption",    "[on/off]",
> +                                               cmd_encryption_endpoint,
> +                                               "Enable/disable BIS encry=
ption (mode 3 security)",
> +                                               NULL },
>         {} },
>  };
>
> --
> 2.34.1
>


--=20
Luiz Augusto von Dentz