Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
MIME-Version: 1.0
References: <20230921234738.929423-1-luiz.dentz@gmail.com> <650d08ad.170a0220.dc361.dbe0@mx.google.com>
In-Reply-To: <650d08ad.170a0220.dc361.dbe0@mx.google.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 22 Sep 2023 10:46:45 -0700
Message-ID: <CABBYNZ+2e-b565H5=BtkeSaviUf+8MgXrYOP0LRoxo8pYov-XA@mail.gmail.com>
Subject: Re: [BlueZ,1/5] media-api: Update to reflect the last code changes
To:     linux-bluetooth@vger.kernel.org,
        Vlad Pruteanu <vlad.pruteanu@nxp.com>,
        Claudia Draghicescu <claudia.rosu@nxp.com>,
        iulia-tanasescu <iulia.tanasescu@nxp.com>,
        Silviu Florian Barbulescu <silviu.barbulescu@nxp.com>,
        Pauli Virtanen <pav@iki.fi>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Thu, Sep 21, 2023 at 8:23=E2=80=AFPM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=3D786=
455

Have a look if I capture everything correctly, Ive made sure the
bluetoothctl works with QoS being a single property but we still have
to do the changes at upper layers.

@Pauli Virtanen You can use bluetoothctl as an example how to encode
the QoS property, note that there are multiple containers involved
because the QoS dict becomes the variant portion of the outer
dictionary but you will notice if the daemon is not able to parse it.
I could consider supporting the old format though if you think we
should maintain backwards compatibility.

> ---Test result---
>
> Test Summary:
> CheckPatch                    PASS      2.52 seconds
> GitLint                       FAIL      1.58 seconds
> BuildEll                      PASS      34.31 seconds
> BluezMake                     PASS      1192.51 seconds
> MakeCheck                     PASS      13.44 seconds
> MakeDistcheck                 PASS      195.33 seconds
> CheckValgrind                 PASS      314.03 seconds
> CheckSmatch                   PASS      437.84 seconds
> bluezmakeextell               PASS      131.38 seconds
> IncrementalBuild              PASS      5145.48 seconds
> ScanBuild                     PASS      1374.82 seconds
>
> Details
> ##############################
> Test: GitLint - FAIL
> Desc: Run gitlint
> Output:
> [BlueZ,3/5] client: Make transport.show to print QoS property
>
> WARNING: I3 - ignore-body-lines: gitlint will be switching from using Pyt=
hon regex 'match' (match beginning) to 'search' (match anywhere) semantics.=
 Please review your ignore-body-lines.regex option accordingly. To remove t=
his warning, set general.regex-style-search=3DTrue. More details: https://j=
orisroovers.github.io/gitlint/configuration/#regex-style-search
> 10: B3 Line contains hard tab characters (\t): "        UUID: 00002bcb-00=
00-1000-8000-00805f9b34fb"
> 11: B3 Line contains hard tab characters (\t): "        Codec: 0x06 (6)"
> 12: B3 Line contains hard tab characters (\t): "        Configuration:"
> 14: B3 Line contains hard tab characters (\t): "        Device: /org/blue=
z/hci0/dev_00_AA_01_01_00_03"
> 15: B3 Line contains hard tab characters (\t): "        State: idle"
> 16: B3 Line contains hard tab characters (\t): "        Endpoint: /org/bl=
uez/hci0/dev_00_AA_01_01_00_03/pac_sink0"
> 17: B3 Line contains hard tab characters (\t): "        QoS Key: CIG"
> 18: B3 Line contains hard tab characters (\t): "        QoS Value: 0x00 (=
0)"
> 19: B3 Line contains hard tab characters (\t): "        QoS Key: CIS"
> 20: B3 Line contains hard tab characters (\t): "        QoS Value: 0x00 (=
0)"
> 21: B3 Line contains hard tab characters (\t): "        QoS Key: Framing"
> 22: B3 Line contains hard tab characters (\t): "        QoS Value: 0x00 (=
0)"
> 23: B3 Line contains hard tab characters (\t): "        QoS Key: Presenta=
tionDelay"
> 24: B3 Line contains hard tab characters (\t): "        QoS Value: 0x0000=
9c40 (40000)"
> 25: B3 Line contains hard tab characters (\t): "        QoS Key: Interval=
"
> 26: B3 Line contains hard tab characters (\t): "        QoS Value: 0x0000=
2710 (10000)"
> 27: B3 Line contains hard tab characters (\t): "        QoS Key: Latency"
> 28: B3 Line contains hard tab characters (\t): "        QoS Value: 0x000a=
 (10)"
> 29: B3 Line contains hard tab characters (\t): "        QoS Key: SDU"
> 30: B3 Line contains hard tab characters (\t): "        QoS Value: 0x0028=
 (40)"
> 31: B3 Line contains hard tab characters (\t): "        QoS Key: PHY"
> 32: B3 Line contains hard tab characters (\t): "        QoS Value: 0x02 (=
2)"
> 33: B3 Line contains hard tab characters (\t): "        QoS Key: Retransm=
issions"
> 34: B3 Line contains hard tab characters (\t): "        QoS Value: 0x02 (=
2)"
> 35: B3 Line contains hard tab characters (\t): "        Location: 0x00000=
003 (3)"
> 36: B3 Line contains hard tab characters (\t): "        Links: /org/bluez=
/hci0/dev_00_AA_01_01_00_03/pac_source0/fd0"
>
>
> ---
> Regards,
> Linux Bluetooth
>


--=20
Luiz Augusto von Dentz